Skip to content

refactor(profiling): make StringTable::lookup const #15547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KowalskiThomas merged 1 commit into from
Dec 8, 2025
Merged

refactor(profiling): make StringTable::lookup const #15547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ddtrace/internal/datadog/profiling/stack_v2/echion/echion/strings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,12 @@ class StringTable : public std::unordered_map<uintptr_t, std::string>
return k;
};

[[nodiscard]] inline Result<std::reference_wrapper<std::string>> lookup(Key key)
[[nodiscard]] inline Result<std::reference_wrapper<const std::string>> lookup(Key key) const
{
const std::lock_guard<std::mutex> lock(table_lock);

auto it = this->find(key);
if (it == this->end())
const auto it = this->find(key);
if (it == this->cend())
return ErrorKind::LookupError;

return std::ref(it->second);
Expand All @@ -159,7 +159,7 @@ class StringTable : public std::unordered_map<uintptr_t, std::string>
};

private:
std::mutex table_lock;
mutable std::mutex table_lock;
};

// We make this a reference to a heap-allocated object so that we can avoid
Expand Down
Loading