-
Notifications
You must be signed in to change notification settings - Fork 468
chore(telemetry): fix protocol in otel metrics #15010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 239 ± 2 ms. The average import time from base is: 241 ± 2 ms. The import time difference between this PR and base is: -2.29 ± 0.09 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate munir/fix-otel-telemetry (c9c1e4a) with baseline main (620007d) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.303µs (SLO: <10.000µs 📉 -57.0%) vs baseline: +0.8% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.083µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.3% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 7.099µs (SLO: <10.000µs 📉 -29.0%) vs baseline: 📈 +14.8% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.2% ✅ ospathjoin_noaspectTime: ✅ 2.302µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +1.2% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.567µs (SLO: <10.000µs 📉 -64.3%) vs baseline: +0.8% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.578µs (SLO: <10.000µs 📉 -94.2%) vs baseline: ~same Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.929µs (SLO: <10.000µs 📉 -50.7%) vs baseline: -0.4% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 1.604µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.9% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 3.772µs (SLO: <10.000µs 📉 -62.3%) vs baseline: +1.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 0.695µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.588µs (SLO: <10.000µs 📉 -54.1%) vs baseline: -0.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 1.369µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -1.6% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.517ms (SLO: <22.300ms -8.0%) vs baseline: +0.7% Memory: ✅ 65.216MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.346ms (SLO: <1.450ms -7.2%) vs baseline: +0.2% Memory: ✅ 64.741MB (SLO: <67.000MB -3.4%) vs baseline: +4.9% ✅ iastTime: ✅ 20.492ms (SLO: <22.250ms -7.9%) vs baseline: ~same Memory: ✅ 65.197MB (SLO: <67.000MB -2.7%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.254ms (SLO: <16.550ms -7.8%) vs baseline: -0.3% Memory: ✅ 53.809MB (SLO: <54.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.592ms (SLO: <21.750ms -5.3%) vs baseline: +0.3% Memory: ✅ 65.301MB (SLO: <67.000MB -2.5%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 25.378ms (SLO: <28.200ms 📉 -10.0%) vs baseline: +0.2% Memory: ✅ 67.579MB (SLO: <69.500MB -2.8%) vs baseline: +5.1% ✅ tracerTime: ✅ 20.400ms (SLO: <21.750ms -6.2%) vs baseline: -0.4% Memory: ✅ 65.215MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.002ms (SLO: <23.500ms -6.4%) vs baseline: -0.4% Memory: ✅ 66.732MB (SLO: <67.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ tracer-dont-create-db-spansTime: ✅ 19.272ms (SLO: <21.500ms 📉 -10.4%) vs baseline: ~same Memory: ✅ 65.196MB (SLO: <66.000MB 🟡 -1.2%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.571ms (SLO: <17.500ms -5.3%) vs baseline: ~same Memory: ✅ 65.200MB (SLO: <66.000MB 🟡 -1.2%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.425ms (SLO: <21.750ms -6.1%) vs baseline: -0.4% Memory: ✅ 70.995MB (SLO: <72.500MB -2.1%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.443ms (SLO: <19.650ms -6.1%) vs baseline: +0.2% Memory: ✅ 65.239MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.793ms (SLO: <20.100ms -6.5%) vs baseline: ~same Memory: ✅ 65.141MB (SLO: <67.000MB -2.8%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.118ms (SLO: <21.500ms -6.4%) vs baseline: -0.1% Memory: ✅ 65.240MB (SLO: <67.000MB -2.6%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.295ms (SLO: <22.000ms -7.7%) vs baseline: +0.2% Memory: ✅ 65.219MB (SLO: <67.000MB -2.7%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.070ms (SLO: <19.850ms -9.0%) vs baseline: -0.1% Memory: ✅ 65.338MB (SLO: <66.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ errortracking-enabled-userTime: ✅ 18.074ms (SLO: <19.400ms -6.8%) vs baseline: +0.6% Memory: ✅ 65.240MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.032ms (SLO: <19.450ms -7.3%) vs baseline: +0.2% Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.581ms (SLO: <4.750ms -3.6%) vs baseline: -0.3% Memory: ✅ 61.892MB (SLO: <65.000MB -4.8%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.608ms (SLO: <6.750ms -2.1%) vs baseline: ~same Memory: ✅ 62.030MB (SLO: <65.000MB -4.6%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.579ms (SLO: <4.750ms -3.6%) vs baseline: -0.3% Memory: ✅ 61.873MB (SLO: <65.000MB -4.8%) vs baseline: +4.6% ✅ debuggerTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: ~same Memory: ✅ 45.397MB (SLO: <47.000MB -3.4%) vs baseline: +4.7% ✅ iast-getTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: -0.3% Memory: ✅ 42.349MB (SLO: <49.000MB 📉 -13.6%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.911ms (SLO: <2.100ms -9.0%) vs baseline: -0.2% Memory: ✅ 46.557MB (SLO: <47.000MB 🟡 -0.9%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.371ms (SLO: <3.650ms -7.6%) vs baseline: -0.1% Memory: ✅ 52.219MB (SLO: <53.500MB -2.4%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.356ms (SLO: <3.650ms -8.0%) vs baseline: -0.2% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.366ms (SLO: <3.650ms -7.8%) vs baseline: +0.2% Memory: ✅ 58.382MB (SLO: <60.000MB -2.7%) vs baseline: +5.2% 🟡 packagesupdateimporteddependencies - 24/24✅ import_manyTime: ✅ 155.088µs (SLO: <170.000µs -8.8%) vs baseline: -0.4% Memory: ✅ 37.626MB (SLO: <38.500MB -2.3%) vs baseline: +5.4% ✅ import_many_cachedTime: ✅ 120.847µs (SLO: <130.000µs -7.0%) vs baseline: -0.4% Memory: ✅ 37.367MB (SLO: <38.500MB -2.9%) vs baseline: +5.2% ✅ import_many_stdlibTime: ✅ 1.622ms (SLO: <1.750ms -7.3%) vs baseline: -0.4% Memory: ✅ 37.524MB (SLO: <38.500MB -2.5%) vs baseline: +3.9% ✅ import_many_stdlib_cachedTime: ✅ 0.975ms (SLO: <1.100ms 📉 -11.3%) vs baseline: -0.5% Memory: ✅ 37.423MB (SLO: <38.500MB -2.8%) vs baseline: +4.9% ✅ import_many_unknownTime: ✅ 836.368µs (SLO: <890.000µs -6.0%) vs baseline: +1.2% Memory: ✅ 37.710MB (SLO: <38.500MB -2.1%) vs baseline: +5.7% ✅ import_many_unknown_cachedTime: ✅ 792.092µs (SLO: <870.000µs -9.0%) vs baseline: +0.5% Memory: ✅ 37.643MB (SLO: <38.500MB -2.2%) vs baseline: +4.5% ✅ import_oneTime: ✅ 19.937µs (SLO: <30.000µs 📉 -33.5%) vs baseline: +0.9% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.1% ✅ import_one_cacheTime: ✅ 6.270µs (SLO: <10.000µs 📉 -37.3%) vs baseline: -0.4% Memory: ✅ 37.332MB (SLO: <38.500MB -3.0%) vs baseline: +4.8% ✅ import_one_stdlibTime: ✅ 18.844µs (SLO: <20.000µs -5.8%) vs baseline: +1.4% Memory: ✅ 37.283MB (SLO: <38.500MB -3.2%) vs baseline: +4.6% ✅ import_one_stdlib_cacheTime: ✅ 6.290µs (SLO: <10.000µs 📉 -37.1%) vs baseline: +0.2% Memory: ✅ 37.367MB (SLO: <38.500MB -2.9%) vs baseline: +5.0% ✅ import_one_unknownTime: ✅ 45.444µs (SLO: <50.000µs -9.1%) vs baseline: +0.4% Memory: ✅ 37.776MB (SLO: <38.500MB 🟡 -1.9%) vs baseline: +5.9% ✅ import_one_unknown_cacheTime: ✅ 6.258µs (SLO: <10.000µs 📉 -37.4%) vs baseline: -0.7% Memory: ✅ 37.411MB (SLO: <38.500MB -2.8%) vs baseline: +5.3% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.185µs (SLO: <20.000µs 📉 -84.1%) vs baseline: +8.5% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 203.389µs (SLO: <220.000µs -7.6%) vs baseline: -0.3% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.299µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +0.5% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.800µs (SLO: <220.000µs 🟡 -1.9%) vs baseline: +0.9% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.190µs (SLO: <20.000µs 📉 -89.0%) vs baseline: +1.0% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 138.960µs (SLO: <150.000µs -7.4%) vs baseline: +1.2% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.056µs (SLO: <20.000µs 📉 -84.7%) vs baseline: -0.5% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 215.895µs (SLO: <250.000µs 📉 -13.6%) vs baseline: -0.3% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.711ms (SLO: <22.000ms -5.9%) vs baseline: +1.3% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.304ms (SLO: <2.300ms +0.2%) vs baseline: +2.1% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.429ms (SLO: <1.550ms -7.8%) vs baseline: +1.5% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.267ms (SLO: <2.550ms 📉 -11.1%) vs baseline: +1.2% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.516µs (SLO: <20.000µs 📉 -77.4%) vs baseline: +1.0% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.4% ✅ flush-100-metricsTime: ✅ 173.792µs (SLO: <250.000µs 📉 -30.5%) vs baseline: -0.5% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.8% ✅ flush-1000-metricsTime: ✅ 2.107ms (SLO: <2.500ms 📉 -15.7%) vs baseline: -1.6% Memory: ✅ 32.932MB (SLO: <34.500MB -4.5%) vs baseline: +4.9%
|
## Description Protocol is currently set as "http/protobuf", it should be sent as "http". This PR fixes this. ## Testing This regression was found via system tests. We do not need additional testing. (cherry picked from commit 5fa0681)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.17 3.17
# Navigate to the new working tree
cd .worktrees/backport-3.17
# Create a new branch
git switch --create backport-15010-to-3.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5fa0681232dafc15184cc3a8244f03336444def1
# Push it to GitHub
git push --set-upstream origin backport-15010-to-3.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.17Then, create a pull request where the |
Protocol is currently set as "http/protobuf", it should be sent as "http". This PR fixes this. This regression was found via system tests. We do not need additional testing. (cherry picked from commit 5fa0681)
## Description Protocol is currently set as "http/protobuf", it should be sent as "http". This PR fixes this. ## Testing This regression was found via system tests. We do not need additional testing. (cherry picked from commit 5fa0681)
Protocol is currently set as "http/protobuf", it should be sent as "http". This PR fixes this. This regression was found via system tests. We do not need additional testing. (cherry picked from commit 5fa0681)
Backport 5fa0681 from #15010 to 3.16. ## Description Protocol is currently set as "http/protobuf", it should be sent as "http". This PR fixes this. ## Testing This regression was found via system tests. We do not need additional testing. Co-authored-by: Munir Abdinur <[email protected]>
Backport 5fa0681 from #15010 to 3.17. ## Description Protocol is currently set as "http/protobuf", it should be sent as "http". This PR fixes this. ## Testing This regression was found via system tests. We do not need additional testing. Co-authored-by: Munir Abdinur <[email protected]>
Description
Protocol is currently set as "http/protobuf", it should be sent as "http". This PR fixes this.
Testing
This regression was found via system tests. We do not need additional testing.