-
Notifications
You must be signed in to change notification settings - Fork 469
fix(otel): avoid tracing otlp connections #14984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 239 ± 7 ms. The average import time from base is: 245 ± 9 ms. The import time difference between this PR and base is: -6.0 ± 0.4 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate munir/prevent-otel-connections-from-traced (a77382d) with baseline main (5b6b476) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.399µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.7% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.6% ✅ add_inplace_aspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.4% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 0.322µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.6% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ add_noaspectTime: ✅ 0.275µs (SLO: <10.000µs 📉 -97.3%) vs baseline: -1.4% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ bytearray_aspectTime: ✅ 1.367µs (SLO: <10.000µs 📉 -86.3%) vs baseline: +0.5% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 1.515µs (SLO: <10.000µs 📉 -84.9%) vs baseline: +0.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 0.614µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.5% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.5% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 1.271µs (SLO: <10.000µs 📉 -87.3%) vs baseline: -1.9% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ bytes_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.7% ✅ bytesio_aspectTime: ✅ 1.361µs (SLO: <10.000µs 📉 -86.4%) vs baseline: -0.2% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ bytesio_noaspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ capitalize_aspectTime: ✅ 0.738µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.3% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 0.438µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.7% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 0.735µs (SLO: <10.000µs 📉 -92.7%) vs baseline: ~same Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.0% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 0.728µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.2% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ decode_noaspectTime: ✅ 0.417µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.4% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 0.713µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +1.6% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.0% ✅ encode_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +1.0% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 3.399µs (SLO: <10.000µs 📉 -66.0%) vs baseline: +0.2% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 4.042µs (SLO: <10.000µs 📉 -59.6%) vs baseline: 📈 +11.0% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.9% ✅ format_map_noaspectTime: ✅ 0.781µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.7% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ format_noaspectTime: ✅ 0.596µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.9% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.356µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.4% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: ~same Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ join_aspectTime: ✅ 1.383µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +1.8% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.6% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ ljust_aspectTime: ✅ 2.603µs (SLO: <20.000µs 📉 -87.0%) vs baseline: +1.0% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ ljust_noaspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 2.370µs (SLO: <10.000µs 📉 -76.3%) vs baseline: +9.2% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.9% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.0% ✅ lstrip_aspectTime: ✅ 2.233µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +1.6% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.9% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ modulo_aspectTime: ✅ 0.992µs (SLO: <10.000µs 📉 -90.1%) vs baseline: -1.0% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.551µs (SLO: <10.000µs 📉 -84.5%) vs baseline: ~same Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.977µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +0.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.217µs (SLO: <10.000µs 📉 -87.8%) vs baseline: -0.6% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.1% ✅ modulo_noaspectTime: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +0.1% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 4.933µs (SLO: <10.000µs 📉 -50.7%) vs baseline: +0.5% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 0.463µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.2% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.6% ✅ repr_aspectTime: ✅ 0.908µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ repr_noaspectTime: ✅ 0.417µs (SLO: <10.000µs 📉 -95.8%) vs baseline: ~same Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.1% ✅ rstrip_aspectTime: ✅ 1.915µs (SLO: <20.000µs 📉 -90.4%) vs baseline: ~same Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ rstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.1% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ slice_aspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.449µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.6% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.1% ✅ stringio_aspectTime: ✅ 1.556µs (SLO: <10.000µs 📉 -84.4%) vs baseline: -0.7% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.6% ✅ stringio_noaspectTime: ✅ 0.719µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.2% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ strip_aspectTime: ✅ 2.199µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -0.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 0.388µs (SLO: <10.000µs 📉 -96.1%) vs baseline: -0.4% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ swapcase_aspectTime: ✅ 2.416µs (SLO: <10.000µs 📉 -75.8%) vs baseline: +0.7% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 0.535µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -0.1% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 2.331µs (SLO: <10.000µs 📉 -76.7%) vs baseline: +0.7% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.4% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ translate_aspectTime: ✅ 3.205µs (SLO: <10.000µs 📉 -68.0%) vs baseline: -1.5% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 1.042µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.3% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.6% ✅ upper_aspectTime: ✅ 2.190µs (SLO: <10.000µs 📉 -78.1%) vs baseline: -0.1% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.5% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.980µs (SLO: <20.000µs 📉 -85.1%) vs baseline: +0.9% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 1-count-metrics-100-timesTime: ✅ 204.799µs (SLO: <220.000µs -6.9%) vs baseline: +2.4% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.8% ✅ 1-distribution-metric-1-timesTime: ✅ 3.404µs (SLO: <20.000µs 📉 -83.0%) vs baseline: +3.8% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 213.747µs (SLO: <220.000µs -2.8%) vs baseline: +0.5% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.427µs (SLO: <20.000µs 📉 -87.9%) vs baseline: 📈 +11.3% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.654µs (SLO: <150.000µs -8.9%) vs baseline: +0.1% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 1-rate-metric-1-timesTime: ✅ 3.060µs (SLO: <20.000µs 📉 -84.7%) vs baseline: -1.0% Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 213.601µs (SLO: <250.000µs 📉 -14.6%) vs baseline: ~same Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.6% ✅ 100-count-metrics-100-timesTime: ✅ 20.313ms (SLO: <22.000ms -7.7%) vs baseline: +2.0% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.227ms (SLO: <2.300ms -3.2%) vs baseline: -0.2% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.409ms (SLO: <1.550ms -9.1%) vs baseline: +1.1% Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.1% ✅ 100-rate-metrics-100-timesTime: ✅ 2.215ms (SLO: <2.550ms 📉 -13.1%) vs baseline: +1.9% Memory: ✅ 32.244MB (SLO: <34.000MB -5.2%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.680µs (SLO: <20.000µs 📉 -76.6%) vs baseline: +1.2% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 174.701µs (SLO: <250.000µs 📉 -30.1%) vs baseline: ~same Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.124ms (SLO: <2.500ms 📉 -15.0%) vs baseline: -0.1% Memory: ✅ 32.991MB (SLO: <34.500MB -4.4%) vs baseline: +4.9% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.381ms (SLO: <22.300ms -8.6%) vs baseline: -0.4% Memory: ✅ 66.436MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.340ms (SLO: <1.450ms -7.6%) vs baseline: +0.5% Memory: ✅ 64.627MB (SLO: <67.000MB -3.5%) vs baseline: +4.9% ✅ iastTime: ✅ 20.415ms (SLO: <22.250ms -8.2%) vs baseline: -0.4% Memory: ✅ 66.430MB (SLO: <67.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.461ms (SLO: <16.550ms -6.6%) vs baseline: ~same Memory: ✅ 54.125MB (SLO: <54.500MB 🟡 -0.7%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.534ms (SLO: <21.750ms -5.6%) vs baseline: ~same Memory: ✅ 66.446MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 25.323ms (SLO: <28.200ms 📉 -10.2%) vs baseline: +1.0% Memory: ✅ 68.164MB (SLO: <69.500MB 🟡 -1.9%) vs baseline: +5.7% ✅ tracerTime: ✅ 20.487ms (SLO: <21.750ms -5.8%) vs baseline: +0.2% Memory: ✅ 66.447MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.757ms (SLO: <23.500ms -3.2%) vs baseline: +0.1% Memory: ✅ 67.845MB (SLO: <68.000MB 🟡 -0.2%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.275ms (SLO: <21.500ms 📉 -10.4%) vs baseline: -0.3% Memory: ✅ 66.409MB (SLO: <67.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.605ms (SLO: <17.500ms -5.1%) vs baseline: -0.2% Memory: ✅ 66.423MB (SLO: <67.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.428ms (SLO: <21.750ms -6.1%) vs baseline: ~same Memory: ✅ 72.225MB (SLO: <72.500MB 🟡 -0.4%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.365ms (SLO: <19.650ms -6.5%) vs baseline: -0.6% Memory: ✅ 66.452MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.730ms (SLO: <20.100ms -6.8%) vs baseline: ~same Memory: ✅ 66.487MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +5.0% ✅ tracer-no-middlewareTime: ✅ 20.140ms (SLO: <21.500ms -6.3%) vs baseline: +0.1% Memory: ✅ 66.439MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.209ms (SLO: <22.000ms -8.1%) vs baseline: -0.3% Memory: ✅ 66.469MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.020ms (SLO: <19.850ms -9.2%) vs baseline: -0.2% Memory: ✅ 66.421MB (SLO: <66.500MB 🟡 -0.1%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.039ms (SLO: <19.400ms -7.0%) vs baseline: ~same Memory: ✅ 66.351MB (SLO: <66.500MB 🟡 -0.2%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.020ms (SLO: <19.450ms -7.4%) vs baseline: -0.4% Memory: ✅ 66.276MB (SLO: <66.500MB 🟡 -0.3%) vs baseline: +4.7% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.101ms (SLO: <2.300ms -8.6%) vs baseline: +1.6% Memory: ✅ 52.770MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +5.2% ✅ errortracking-enabled-userTime: ✅ 2.067ms (SLO: <2.250ms -8.1%) vs baseline: ~same Memory: ✅ 52.966MB (SLO: <53.500MB 🟡 -1.0%) vs baseline: +5.4% ✅ tracer-enabledTime: ✅ 2.069ms (SLO: <2.300ms 📉 -10.0%) vs baseline: -0.1% Memory: ✅ 52.829MB (SLO: <53.500MB 🟡 -1.3%) vs baseline: +5.1% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.576ms (SLO: <4.750ms -3.7%) vs baseline: ~same Memory: ✅ 62.777MB (SLO: <65.000MB -3.4%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.610ms (SLO: <6.750ms -2.1%) vs baseline: ~same Memory: ✅ 62.757MB (SLO: <65.000MB -3.5%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.573ms (SLO: <4.750ms -3.7%) vs baseline: -0.2% Memory: ✅ 62.738MB (SLO: <65.000MB -3.5%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 45.357MB (SLO: <47.000MB -3.5%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: -0.5% Memory: ✅ 42.428MB (SLO: <49.000MB 📉 -13.4%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.916ms (SLO: <2.100ms -8.7%) vs baseline: -0.2% Memory: ✅ 46.419MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +3.9% ✅ resource-renamingTime: ✅ 3.355ms (SLO: <3.650ms -8.1%) vs baseline: ~same Memory: ✅ 53.045MB (SLO: <53.500MB 🟡 -0.9%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.349ms (SLO: <3.650ms -8.2%) vs baseline: -0.2% Memory: ✅ 53.045MB (SLO: <53.500MB 🟡 -0.9%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.348ms (SLO: <3.650ms -8.3%) vs baseline: +0.1% Memory: ✅ 58.922MB (SLO: <60.000MB 🟡 -1.8%) vs baseline: +4.8% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.955ms (SLO: <4.200ms -5.8%) vs baseline: +0.4% Memory: ✅ 63.072MB (SLO: <66.000MB -4.4%) vs baseline: +5.0% ✅ iast-enabledTime: ✅ 2.445ms (SLO: <2.800ms 📉 -12.7%) vs baseline: +0.2% Memory: ✅ 59.395MB (SLO: <60.000MB 🟡 -1.0%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 2.054ms (SLO: <2.250ms -8.7%) vs baseline: -0.4% Memory: ✅ 52.966MB (SLO: <54.500MB -2.8%) vs baseline: +4.8%
|
wantsui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only left some nits but this looks good to me.
## Description Prevents OpenTelemetry OTLP exporters from being traced by ddtrace to avoid circular instrumentation. ## Problem When OpenTelemetry metrics/logs exporters send data, ddtrace was instrumenting these internal connections, creating unwanted spans and potential circular tracing issues. ## Solution - Skip tracing gRPC channels with OpenTelemetry OTLP exporter user agents - Skip tracing HTTP requests from OpenTelemetry OTLP exporters - Added detection logic for both gRPC metadata and HTTP headers ## Testing Added tests verifying that OpenTelemetry exporters don't generate spans when `DD_LOGS_OTEL_ENABLED` is enabled. ## Risks Low - only affects OpenTelemetry integration when enabled. (cherry picked from commit c426d0f)
Prevents OpenTelemetry OTLP exporters from being traced by ddtrace to avoid circular instrumentation. When OpenTelemetry metrics/logs exporters send data, ddtrace was instrumenting these internal connections, creating unwanted spans and potential circular tracing issues. - Skip tracing gRPC channels with OpenTelemetry OTLP exporter user agents - Skip tracing HTTP requests from OpenTelemetry OTLP exporters - Added detection logic for both gRPC metadata and HTTP headers Added tests verifying that OpenTelemetry exporters don't generate spans when `DD_LOGS_OTEL_ENABLED` is enabled. Low - only affects OpenTelemetry integration when enabled. (cherry picked from commit c426d0f)
Backport c426d0f from #14984 to 3.17. ## Description Prevents OpenTelemetry OTLP exporters from being traced by ddtrace to avoid circular instrumentation. ## Problem When OpenTelemetry metrics/logs exporters send data, ddtrace was instrumenting these internal connections, creating unwanted spans and potential circular tracing issues. ## Solution - Skip tracing gRPC channels with OpenTelemetry OTLP exporter user agents - Skip tracing HTTP requests from OpenTelemetry OTLP exporters - Added detection logic for both gRPC metadata and HTTP headers ## Testing Added tests verifying that OpenTelemetry exporters don't generate spans when `DD_LOGS_OTEL_ENABLED` is enabled. ## Risks Low - only affects OpenTelemetry integration when enabled. Co-authored-by: Munir Abdinur <[email protected]>
Description
Prevents OpenTelemetry OTLP exporters from being traced by ddtrace to avoid circular instrumentation.
Problem
When OpenTelemetry metrics/logs exporters send data, ddtrace was instrumenting these internal connections, creating unwanted spans and potential circular tracing issues.
Solution
Testing
Added tests verifying that OpenTelemetry exporters don't generate spans when
DD_LOGS_OTEL_ENABLEDis enabled.Risks
Low - only affects OpenTelemetry integration when enabled.