Skip to content

Rename service_name to service in the exposure payload #6825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

Rename service_name to service in the exposure payload #6825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cacae92
Renamed service_name to service in the exposure payload
khanayan123 Nov 3, 2025
edd4c53
Merge branch 'master' into ayan.khan/update-exposures-payload
khanayan123 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions integration-tests/openfeature/openfeature-exposure-events.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe('OpenFeature Remote Config and Exposure Events Integration', () => {
agent.on('exposures', ({ payload, headers }) => {
assert.property(payload, 'context')
assert.property(payload, 'exposures')
assert.equal(payload.context.service_name, 'ffe-test-service')
assert.equal(payload.context.service, 'ffe-test-service')
assert.equal(payload.context.version, '1.2.3')
assert.equal(payload.context.env, 'test')

Expand Down Expand Up @@ -159,7 +159,7 @@ describe('OpenFeature Remote Config and Exposure Events Integration', () => {
agent.on('exposures', ({ payload }) => {
assert.property(payload, 'context')
assert.property(payload, 'exposures')
assert.equal(payload.context.service_name, 'ffe-test-service')
assert.equal(payload.context.service, 'ffe-test-service')
assert.equal(payload.context.version, '1.2.3')
assert.equal(payload.context.env, 'test')

Expand Down
4 changes: 2 additions & 2 deletions packages/dd-trace/src/openfeature/writers/exposures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const {

/**
* @typedef {Object} ExposureContext
* @property {string} service_name - Service name
* @property {string} service - Service name
* @property {string} [version] - Service version
* @property {string} [env] - Service environment
*/
Expand Down Expand Up @@ -127,7 +127,7 @@ class ExposuresWriter extends BaseFFEWriter {
*/
_buildContext () {
const context = {
service_name: this._config.service || 'unknown'
service: this._config.service || 'unknown'
}

// Only include version and env if they are defined
Expand Down
6 changes: 3 additions & 3 deletions packages/dd-trace/test/openfeature/writers/exposures.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ describe('OpenFeature Exposures Writer', () => {
const payload = writer.makePayload(events)

expect(payload.context).to.deep.equal({
service_name: 'test-service',
service: 'test-service',
version: '1.0.0',
env: 'test'
})
Expand Down Expand Up @@ -213,7 +213,7 @@ describe('OpenFeature Exposures Writer', () => {
const payload = writerWithoutOptionals.makePayload(events)

expect(payload.context).to.deep.equal({
service_name: 'test-service'
service: 'test-service'
})
expect(payload.context).to.not.have.property('version')
expect(payload.context).to.not.have.property('env')
Expand Down Expand Up @@ -279,7 +279,7 @@ describe('OpenFeature Exposures Writer', () => {
expect(parsedPayload).to.have.property('exposures')
expect(parsedPayload.exposures).to.be.an('array').with.length(1)
expect(parsedPayload.exposures[0].timestamp).to.exist
expect(parsedPayload.context.service_name).to.equal('test-service')
expect(parsedPayload.context.service).to.equal('test-service')
})

it('should empty buffer after flushing', () => {
Expand Down