Skip to content

Introduce new Config getters #6800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Introduce new Config getters #6800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66b446b
Migrate some CI Vis calls to new Config getters
mtoffl01 Oct 30, 2025
fe44133
fix syntax issue
mtoffl01 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ci/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

/* eslint-disable no-console */
const tracer = require('../packages/dd-trace')
const { isTrue, isFalse } = require('../packages/dd-trace/src/util')
const log = require('../packages/dd-trace/src/log')
const { getEnvironmentVariable } = require('../packages/dd-trace/src/config-helper')
const { isCIVisibilityEnabled, isCiVisibilityAgentlessEnabled, getAPIKey } = require('../packages/dd-trace/src/config')

const PACKAGE_MANAGERS = ['npm', 'yarn', 'pnpm']
const DEFAULT_FLUSH_INTERVAL = 5000
Expand Down Expand Up @@ -42,8 +42,8 @@ const baseOptions = {
flushInterval: isJestWorker ? JEST_FLUSH_INTERVAL : DEFAULT_FLUSH_INTERVAL
}

let shouldInit = !isFalse(getEnvironmentVariable('DD_CIVISIBILITY_ENABLED'))
const isAgentlessEnabled = isTrue(getEnvironmentVariable('DD_CIVISIBILITY_AGENTLESS_ENABLED'))
let shouldInit = isCIVisibilityEnabled()
const isAgentlessEnabled = isCiVisibilityAgentlessEnabled()

if (!isTestWorker && isPackageManager()) {
log.debug('dd-trace is not initialized in a package manager.')
Expand All @@ -57,7 +57,7 @@ if (isTestWorker) {
}
} else {
if (isAgentlessEnabled) {
if (getEnvironmentVariable('DD_API_KEY')) {
if (getAPIKey()) {
baseOptions.experimental = {
exporter: 'datadog'
}
Expand Down
12 changes: 12 additions & 0 deletions packages/dd-trace/src/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1464,6 +1464,18 @@ class Config {
}
}
}

isCIVisibilityEnabled () {
return this.isCiVisibility
}

isCiVisibilityAgentlessEnabled () {
return this.isCiVisibilityAgentless
}

getAPIKey () {
return this.apiKey
}
}

function handleOtel (tagString) {
Expand Down
Loading