Skip to content

Conversation

@nina9753
Copy link

What does this PR do?

  • Add full producer.js with batch message handling
  • Add span link extraction from messages 2-N
  • Add parent context extraction from first message
  • Add batch span creation (pubsub.request)
  • Inject batch metadata into messages (_dd.pubsub_request., _dd.batch.)
  • Add Topic.publishMessage/publish wrappers for trace context injection
  • Inject _dd.p.tid for 128-bit trace ID support

Motivation

Plugin Checklist

Additional Notes

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Overall package size

Self size: 13.17 MB
Deduped: 115.96 MB
No deduping: 118.17 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.11.1 | 9.96 MB | 10.34 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.82 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @opentelemetry/resources | 1.9.1 | 306.54 kB | 1.74 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.207.0 | 201.39 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.12 | 95.11 kB | 401.68 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Oct 29, 2025

Benchmarks

Benchmark execution time: 2025-11-04 21:52:42

Comparing candidate commit f638388 in PR branch nina.rei/SVLS-7168/gcp-pubsub-batch-plugin with baseline commit 5a13644 in branch nina.rei/SVLS-7168/gcp-push-pubsub-plugin.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1605 metrics, 65 unstable metrics.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 56.09756% with 18 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (nina.rei/SVLS-7168/gcp-push-pubsub-plugin@5a13644). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...datadog-plugin-google-cloud-pubsub/src/producer.js 56.09% 18 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##             nina.rei/SVLS-7168/gcp-push-pubsub-plugin    #6782   +/-   ##
============================================================================
  Coverage                                             ?   83.42%           
============================================================================
  Files                                                ?      508           
  Lines                                                ?    21460           
  Branches                                             ?        0           
============================================================================
  Hits                                                 ?    17903           
  Misses                                               ?     3557           
  Partials                                             ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nina9753 nina9753 force-pushed the nina.rei/SVLS-7168/gcp-pubsub-batch-plugin branch from d7f0d5e to 3fdb180 Compare October 29, 2025 20:48
@datadog-datadog-prod-us1

This comment has been minimized.

@nina9753 nina9753 force-pushed the nina.rei/SVLS-7168/gcp-pubsub-batch-plugin branch from 3fdb180 to 6393626 Compare October 30, 2025 13:09
- Add full producer.js with batch message handling
- Add span link extraction from messages 2-N
- Add parent context extraction from first message
- Add batch span creation (pubsub.request)
- Inject batch metadata into messages (_dd.pubsub_request.*, _dd.batch.*)
- Add Topic.publishMessage/publish wrappers for trace context injection
- Inject _dd.p.tid for 128-bit trace ID support
@nina9753 nina9753 force-pushed the nina.rei/SVLS-7168/gcp-pubsub-batch-plugin branch from d76ed3b to f638388 Compare November 4, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants