add middleware enter/exit/finish instrumentations to hono #6756
+212
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longlho
force-pushed
the
10-26-add_middleware_enter_exit_finish_instrumentations_to_hono
branch
from
aa391f9 to
5a85796
Compare
Collaborator
|
@longlho thank you for your contribution, it is strongly appreciated! I am going to see that someone looks into it sometime soon, while I can't give any concrete time for that right now. |
Author
|
Thank you!! |
Author
|
@BridgeAR gentle ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds middleware enter, exit, and finish instrumentations to the Hono plugin. These new instrumentations allow better tracking and visibility into the middleware lifecycle within Hono applications by separately marking when middleware is entered, exited, and completely finished. This improves the granularity of trace data and helps diagnose middleware-related performance issues.
Motivation
The current integration with Hono does not provide detailed visibility into middleware execution. By instrumenting middleware entry, exit, and finish points, users will be able to better observe and debug middleware performance and behavior, which is particularly useful in complex request handling flows or when diagnosing slow middleware execution.
Plugin Checklist
Additional Notes