Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add experimental support for thenables in the scope manager #649

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Aug 14, 2019

What does this PR do?

Adds experimental support for thenables in the scope manager.

Motivation

Users are having issues with thenables that are not native promises such has Knex because of an issue in Node.

@rochdev rochdev requested a review from a team as a code owner August 14, 2019 19:23
@codecov-io
Copy link

codecov-io commented Aug 14, 2019

Codecov Report

Merging #649 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
+ Coverage   96.14%   96.16%   +0.01%     
==========================================
  Files          92       92              
  Lines        3167     3181      +14     
==========================================
+ Hits         3045     3059      +14     
  Misses        122      122
Impacted Files Coverage Δ
packages/dd-trace/src/config.js 100% <ø> (ø) ⬆️
packages/dd-trace/src/scope/async_hooks.js 95.91% <100%> (+1.63%) ⬆️
packages/dd-trace/src/noop/tracer.js 82.35% <100%> (ø) ⬆️
packages/dd-trace/src/tracer.js 93.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb33849...850c5f3. Read the comment docs.

@rochdev rochdev merged commit 94ec213 into master Aug 20, 2019
@rochdev rochdev deleted the await-thenables branch August 20, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants