Skip to content

Conversation

@uurien
Copy link
Collaborator

@uurien uurien commented Apr 26, 2024

What does this PR do?

Executes with node21 tests suites with native modules that are not ready yet to be executed in node 22. (Profiling and iast taint tracking module)

  • appsec and profiling tests changed to run with node21
  • tracer ubuntu tests changed to run with node 21 because there is a test checking that profiling.run method is executed, and it is not executed if node is 22
  • pino test updated, because it had a check NODE_MAJOR != 21 instead of NODE_MAJOR < 21

Motivation

Unblock release without node 22 compatible native modules

@github-actions
Copy link

github-actions bot commented Apr 26, 2024

Overall package size

Self size: 6.43 MB
Deduped: 60.92 MB
No deduping: 61.2 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.7.0 16.71 MB 16.72 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.2.0 8.84 MB 9.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.0 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Apr 26, 2024

Benchmarks

Benchmark execution time: 2024-04-26 10:33:04

Comparing candidate commit ab18e80 in PR branch ugaitz/temporary-ignore-some-tests-in-node22 with baseline commit 0f36e48 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics.

@uurien uurien force-pushed the ugaitz/temporary-ignore-some-tests-in-node22 branch from ba1e3e6 to dcd744c Compare April 26, 2024 08:50
@codecov
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.61%. Comparing base (c11fcfd) to head (ddcdef1).
Report is 1 commits behind head on master.

❗ Current head ddcdef1 differs from pull request most recent head ab18e80. Consider uploading reports for the commit ab18e80 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4267       +/-   ##
===========================================
- Coverage   83.11%   66.61%   -16.50%     
===========================================
  Files         244      242        -2     
  Lines       10255    10187       -68     
  Branches       33       33               
===========================================
- Hits         8523     6786     -1737     
- Misses       1732     3401     +1669     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uurien uurien marked this pull request as ready for review April 26, 2024 10:32
@uurien uurien requested review from a team as code owners April 26, 2024 10:32
@uurien uurien requested a review from wconti27 April 26, 2024 10:32
Copy link
Collaborator

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@uurien uurien enabled auto-merge (squash) April 26, 2024 15:47
@uurien uurien merged commit 2233a4e into master Apr 29, 2024
@uurien uurien deleted the ugaitz/temporary-ignore-some-tests-in-node22 branch April 29, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants