-
Notifications
You must be signed in to change notification settings - Fork 360
Force node21 in test suites with native modules #4267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 6.43 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-04-26 10:33:04 Comparing candidate commit ab18e80 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics. |
ba1e3e6 to
dcd744c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4267 +/- ##
===========================================
- Coverage 83.11% 66.61% -16.50%
===========================================
Files 244 242 -2
Lines 10255 10187 -68
Branches 33 33
===========================================
- Hits 8523 6786 -1737
- Misses 1732 3401 +1669 ☔ View full report in Codecov by Sentry. |
juan-fernandez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
What does this PR do?
Executes with node21 tests suites with native modules that are not ready yet to be executed in node 22. (Profiling and iast taint tracking module)
NODE_MAJOR != 21instead ofNODE_MAJOR < 21Motivation
Unblock release without node 22 compatible native modules