Skip to content

Conversation

@spencergilbert
Copy link
Contributor

@spencergilbert spencergilbert commented Apr 22, 2024

What does this PR do?

The latest stable version of the packaging template now includes a tool dd-pkg. This PR uses this tool to lint the produced DEB and RPM packages.

Motivation

This lint has been run at the time of package promotion, this change moves this step to the left and lets teams identify issues before they're trying to release to production.

Additional Notes

BARX-245

@spencergilbert spencergilbert requested a review from a team as a code owner April 22, 2024 12:07
@spencergilbert spencergilbert self-assigned this Apr 22, 2024
@github-actions
Copy link

github-actions bot commented Apr 22, 2024

Overall package size

Self size: 6.43 MB
Deduped: 60.92 MB
No deduping: 61.2 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.7.0 16.71 MB 16.72 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.2.0 8.84 MB 9.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.0 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Apr 22, 2024

Benchmarks

Benchmark execution time: 2024-04-29 15:51:32

Comparing candidate commit 75f4e4c in PR branch spencergilbert/use-dd-pkg-to-lint-packages with baseline commit 8b0bfb2 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@codecov
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.19%. Comparing base (c11fcfd) to head (d99f356).
Report is 4 commits behind head on master.

❗ Current head d99f356 differs from pull request most recent head 75f4e4c. Consider uploading reports for the commit 75f4e4c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4257       +/-   ##
===========================================
- Coverage   83.11%   69.19%   -13.92%     
===========================================
  Files         244        1      -243     
  Lines       10255      198    -10057     
  Branches       33       33               
===========================================
- Hits         8523      137     -8386     
+ Misses       1732       61     -1671     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spencergilbert
Copy link
Contributor Author

Looks like next fails pretty frequently, can it be ignored for merging?

@tlhunter tlhunter force-pushed the spencergilbert/use-dd-pkg-to-lint-packages branch from 11fdad7 to 75f4e4c Compare April 29, 2024 15:44
@Qard Qard merged commit 29f09b1 into master Apr 30, 2024
@Qard Qard deleted the spencergilbert/use-dd-pkg-to-lint-packages branch April 30, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants