-
Notifications
You must be signed in to change notification settings - Fork 357
[ci-visibility] Fix chrome installation for node 16 #4255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 6.39 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
b626627 to
626540b
Compare
BenchmarksBenchmark execution time: 2024-04-22 10:39:36 Comparing candidate commit 626540b in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 3 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-on-max-18
|
What does this PR do?
Pass
--experimental-fetchflag to node, so thatfetchis defined in node 16 too.Motivation
Selenium tests are failing for node 16: https://github.com/DataDog/dd-trace-js/actions/runs/8781974704/job/24095116325?pr=4253 in the 3.x and 4.x release proposal branches.
This is because
fetchis not defined by default in node 16.