Skip to content

Conversation

@juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Apr 22, 2024

What does this PR do?

Pass --experimental-fetch flag to node, so that fetch is defined in node 16 too.

Motivation

Selenium tests are failing for node 16: https://github.com/DataDog/dd-trace-js/actions/runs/8781974704/job/24095116325?pr=4253 in the 3.x and 4.x release proposal branches.

This is because fetch is not defined by default in node 16.

@github-actions
Copy link

github-actions bot commented Apr 22, 2024

Overall package size

Self size: 6.39 MB
Deduped: 60.89 MB
No deduping: 61.17 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.7.0 16.71 MB 16.72 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.2.0 8.84 MB 9.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.0 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@juan-fernandez juan-fernandez force-pushed the juan-fernandez/fix-script-chrome branch from b626627 to 626540b Compare April 22, 2024 10:31
@juan-fernandez juan-fernandez marked this pull request as ready for review April 22, 2024 10:31
@juan-fernandez juan-fernandez requested a review from a team as a code owner April 22, 2024 10:31
@pr-commenter
Copy link

pr-commenter bot commented Apr 22, 2024

Benchmarks

Benchmark execution time: 2024-04-22 10:39:36

Comparing candidate commit 626540b in PR branch juan-fernandez/fix-script-chrome with baseline commit ffaf35e in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 3 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-111.471MB; -96.921MB] or [-11.847%; -10.301%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-118.138MB; -100.350MB] or [-12.543%; -10.655%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants