Skip to content

Conversation

@rochdev
Copy link
Member

@rochdev rochdev commented Jul 26, 2023

What does this PR do?

Fix disable option for fetch instrumentation.

Motivation

The condition was only in the loop and never worked for fetch.

@rochdev rochdev requested a review from a team as a code owner July 26, 2023 16:49
@github-actions
Copy link

Overall package size

Self size: 4.93 MB
Deduped: 58.03 MB
No deduping: 58.12 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.1.0 10.66 MB 11.5 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #3460 (1116cb4) into master (fc014bb) will increase coverage by 0.06%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3460      +/-   ##
==========================================
+ Coverage   84.60%   84.66%   +0.06%     
==========================================
  Files         219      218       -1     
  Lines        8598     8581      -17     
  Branches       33       33              
==========================================
- Hits         7274     7265       -9     
+ Misses       1324     1316       -8     

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Jul 26, 2023

Benchmarks

Benchmark execution time: 2023-07-26 16:54:19

Comparing candidate commit 1116cb4 in PR branch fetch-instrumentation-disable-option with baseline commit 547164a in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 475 metrics, 15 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟥 max_rss_usage [+114.401KB; +157.403KB] or [+13.913%; +19.143%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟥 max_rss_usage [+146.407KB; +149.553KB] or [+17.929%; +18.314%]

@rochdev rochdev changed the title fix disable options for fetch instrumentation fix disable option for fetch instrumentation Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants