-
Notifications
You must be signed in to change notification settings - Fork 347
Fix service representation config #3419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 4.91 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3419 +/- ##
==========================================
+ Coverage 84.25% 84.28% +0.03%
==========================================
Files 214 214
Lines 8392 8402 +10
Branches 33 33
==========================================
+ Hits 7071 7082 +11
+ Misses 1321 1320 -1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* address and fix edge cases * move to better tracer option name for service name flattening
* address and fix edge cases * move to better tracer option name for service name flattening
* address and fix edge cases * move to better tracer option name for service name flattening
* address and fix edge cases * move to better tracer option name for service name flattening
* address and fix edge cases * move to better tracer option name for service name flattening
* address and fix edge cases * move to better tracer option name for service name flattening
This is missing the typescript definition for the additional config property |
What does this PR do?
Defaults and computation for service representation (mostly peer service flag) were missing tests and had unaccounted for edge cases.