Skip to content

Conversation

@Qard
Copy link
Contributor

@Qard Qard commented Jul 19, 2023

What does this PR do?

Makes the datadog distributed tracing headers take priority over w3c tracecontext.

Motivation

Some cloud providers such as GCP inject their own traceparent headers between services, altering the parentage without reporting that parentage data between them. This results in a break in the connection between the two ends of the request the distributed tracing headers are supposed to link.

@Qard Qard added the bug Something isn't working label Jul 19, 2023
@Qard Qard requested a review from a team as a code owner July 19, 2023 00:37
@github-actions
Copy link

Overall package size

Self size: 4.9 MB
Deduped: 58 MB
No deduping: 58.09 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.1.0 10.66 MB 11.5 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #3414 (9d0a589) into master (3cd0704) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3414   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files         214      214           
  Lines        8398     8398           
  Branches       33       33           
=======================================
  Hits         7077     7077           
  Misses       1321     1321           
Impacted Files Coverage Δ
packages/dd-trace/src/config.js 99.10% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Qard Qard merged commit 87dc2b7 into master Jul 19, 2023
@Qard Qard deleted the fix-distributed-tracing-header-priority branch July 19, 2023 18:06
@szegedi szegedi mentioned this pull request Jul 20, 2023
@szegedi szegedi mentioned this pull request Jul 20, 2023
This was referenced Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants