-
Notifications
You must be signed in to change notification settings - Fork 349
Make datadog distributed tracing header take priority over tracecontext #3414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 4.9 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3414 +/- ##
=======================================
Coverage 84.27% 84.27%
=======================================
Files 214 214
Lines 8398 8398
Branches 33 33
=======================================
Hits 7077 7077
Misses 1321 1321
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
simon-id
approved these changes
Jul 19, 2023
szegedi
pushed a commit
that referenced
this pull request
Jul 20, 2023
Merged
szegedi
pushed a commit
that referenced
this pull request
Jul 20, 2023
Merged
szegedi
pushed a commit
that referenced
this pull request
Jul 20, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jul 21, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jul 21, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the datadog distributed tracing headers take priority over w3c tracecontext.
Motivation
Some cloud providers such as GCP inject their own traceparent headers between services, altering the parentage without reporting that parentage data between them. This results in a break in the connection between the two ends of the request the distributed tracing headers are supposed to link.