-
Notifications
You must be signed in to change notification settings - Fork 351
Ensure OTel span name is copied to resource.name #3412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 4.9 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3412 +/- ##
=======================================
Coverage 84.27% 84.27%
=======================================
Files 214 214
Lines 8398 8399 +1
Branches 33 33
=======================================
+ Hits 7077 7078 +1
Misses 1321 1321
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-07-18 23:12:27 Comparing candidate commit 24c37aa in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 468 metrics, 20 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-off-18
scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-18
|
What does this PR do?
Copies the OTel span name input to the
resource.nametag.Motivation
We plan to change the operation name of the span to better align with how OTel intends it to work. For now, we want to make sure we're capturing the existing value in the
resource.nametag instead so we aren't losing data when the change to operation name happens.