Skip to content

Conversation

@Qard
Copy link
Contributor

@Qard Qard commented Jul 18, 2023

What does this PR do?

Copies the OTel span name input to the resource.name tag.

Motivation

We plan to change the operation name of the span to better align with how OTel intends it to work. For now, we want to make sure we're capturing the existing value in the resource.name tag instead so we aren't losing data when the change to operation name happens.

@Qard Qard requested a review from a team as a code owner July 18, 2023 23:05
@Qard Qard force-pushed the otel-span-name branch from fae3b61 to 24c37aa Compare July 18, 2023 23:05
@github-actions
Copy link

Overall package size

Self size: 4.9 MB
Deduped: 58 MB
No deduping: 58.09 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.1.0 10.66 MB 11.5 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #3412 (24c37aa) into master (3cd0704) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3412   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files         214      214           
  Lines        8398     8399    +1     
  Branches       33       33           
=======================================
+ Hits         7077     7078    +1     
  Misses       1321     1321           
Impacted Files Coverage Δ
packages/dd-trace/src/opentelemetry/span.js 92.59% <100.00%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Jul 18, 2023

Benchmarks

Benchmark execution time: 2023-07-18 23:12:27

Comparing candidate commit 24c37aa in PR branch otel-span-name with baseline commit 3cd0704 in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 468 metrics, 20 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-off-18

  • 🟥 max_rss_usage [+222.567KB; +246.297KB] or [+19.585%; +21.673%]

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟥 max_rss_usage [+136.899KB; +150.681KB] or [+16.717%; +18.400%]

scenario:plugin-graphql-with-depth-off-18

  • 🟥 max_rss_usage [+120.286KB; +161.678KB] or [+14.666%; +19.713%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟥 max_rss_usage [+133.595KB; +150.081KB] or [+16.233%; +18.237%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants