-
Notifications
You must be signed in to change notification settings - Fork 348
Update trivially upgraded dependencies #3409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 4.95 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3409 +/- ##
==========================================
+ Coverage 84.66% 84.72% +0.05%
==========================================
Files 218 218
Lines 8583 8583
Branches 33 33
==========================================
+ Hits 7267 7272 +5
+ Misses 1316 1311 -5 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b1cdb5c
to
94992af
Compare
BenchmarksBenchmark execution time: 2023-07-26 19:00:20 Comparing candidate commit 72ddaed in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 467 metrics, 21 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-off-18
scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-18
|
87e908d
to
b1e1af7
Compare
b1e1af7
to
4d71f79
Compare
@astuyve I seem to be getting consistent failures from the serverless integration test on this now for some reason. Has anything changed there recently? Did I bump any dependencies in here that you're depending on? |
Hey, this looks like a setup function for GCP - the function wasn't deployed correctly and doesn't exist. I'll get someone to look into it, but it's probably safe to ignore. Does this fail on main? |
Doesn't appear to fail on main, no. Just in this PR, so I suspect one of the dependencies I've updated broke something, but I'm not sure what. 🤔 |
4d71f79
to
789c98a
Compare
Looks like this is fixed here: #3418 |
3265fc3
to
ece3d96
Compare
@astuyve Seems to just be failing for a different reason now? |
@Qard Another fix just landed, hopefully it should no longer be flaky. |
ece3d96
to
72ddaed
Compare
What does this PR do?
Updates all dependencies which can be updated without needing code changes to maintain current test status on all active release lines. I've tested this locally on Node.js 12 and everything passes.
Motivation
Trying to figure out the best dependency upgrade strategy to avoid npm/yarn audit errors reporting and/or getting scared off by vulns that aren't really there.