Skip to content

Conversation

juan-fernandez
Copy link
Collaborator

What does this PR do?

I'm not sure why, but accessing event.test.asyncError before the test starts can cause error messages from timeouts not to show up correctly. By accessing event.test.asyncError after a test finishes, things work correctly.

Motivation

Make sure we don't modify what jest reports.

Plugin Checklist

  • Unit tests.

@github-actions
Copy link

github-actions bot commented Jul 17, 2023

Overall package size

Self size: 4.9 MB
Deduped: 57.99 MB
No deduping: 58.09 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.1.0 10.66 MB 11.5 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #3399 (97dedc4) into master (66f1fd3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3399   +/-   ##
=======================================
  Coverage   84.25%   84.25%           
=======================================
  Files         214      214           
  Lines        8392     8392           
  Branches       33       33           
=======================================
  Hits         7071     7071           
  Misses       1321     1321           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@juan-fernandez juan-fernandez marked this pull request as ready for review July 17, 2023 11:20
@juan-fernandez juan-fernandez requested a review from a team as a code owner July 17, 2023 11:20
@pr-commenter
Copy link

pr-commenter bot commented Jul 17, 2023

Benchmarks

Benchmark execution time: 2023-07-17 13:16:05

Comparing candidate commit 97dedc4 in PR branch juan-fernandez/fix-error-message-jest with baseline commit 66f1fd3 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 469 metrics, 20 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟥 max_rss_usage [+124.009KB; +165.915KB] or [+15.170%; +20.297%]

scenario:plugin-graphql-with-depth-off-18

  • 🟥 max_rss_usage [+127.332KB; +136.984KB] or [+15.473%; +16.646%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟥 max_rss_usage [+119.924KB; +172.456KB] or [+14.554%; +20.930%]

@juan-fernandez juan-fernandez requested a review from uurien July 19, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants