-
Notifications
You must be signed in to change notification settings - Fork 348
[ci-visibility] Do not modify how jest reports timeouts #3399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 4.9 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3399 +/- ##
=======================================
Coverage 84.25% 84.25%
=======================================
Files 214 214
Lines 8392 8392
Branches 33 33
=======================================
Hits 7071 7071
Misses 1321 1321 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-07-17 13:16:05 Comparing candidate commit 97dedc4 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 469 metrics, 20 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-18
|
What does this PR do?
I'm not sure why, but accessing
event.test.asyncError
before the test starts can cause error messages from timeouts not to show up correctly. By accessingevent.test.asyncError
after a test finishes, things work correctly.Motivation
Make sure we don't modify what
jest
reports.Plugin Checklist