-
Notifications
You must be signed in to change notification settings - Fork 351
grpc: service representation naming #3327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 4.74 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3327 +/- ##
==========================================
- Coverage 86.04% 85.99% -0.05%
==========================================
Files 200 200
Lines 7787 7791 +4
Branches 33 33
==========================================
Hits 6700 6700
- Misses 1087 1091 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the molecular errors are pretty real. Might it be due to the changes to setup/mocha.js?
178ee2e to
563d365
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the grpc errors are pretty real. I've been thrown off by the withNamingSchema() usage of done before as well.
TypeError: done is not a function
at Object.callback (packages/datadog-plugin-grpc/test/server.spec.js:87:66)
* grpc: service representation naming * fix tests
* grpc: service representation naming * fix tests
* grpc: service representation naming * fix tests
* grpc: service representation naming * fix tests
* grpc: service representation naming * fix tests
* grpc: service representation naming * fix tests
* grpc: service representation naming * fix tests
| .then(done) | ||
| .catch(done) | ||
| spanProducerFn() | ||
| spanProducerFn(done) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a bug? When the .then(done) above calls, it'll execute the done() function. However, when spanProducerFn(done) calls, it will also run done(). Running this function twice results in a test failure. Was it added accidentally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless it's explicitly used for the purpose of failing tests and should always have a truthy argument?
What does this PR do?
This applies the service naming schema logic (see #2941) to
grpc.This PR relies on #3056 for the split into different files according to general area (messaging, storage) and a few optimizations to the service naming computation.
Motivation
Complete the service representation feature
Plugin Checklist
Additional Notes