-
Notifications
You must be signed in to change notification settings - Fork 351
No SameSite cookie vulnerability detection #3246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 4.34 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3246 +/- ##
==========================================
- Coverage 93.75% 86.01% -7.75%
==========================================
Files 63 194 +131
Lines 1923 7510 +5587
Branches 33 33
==========================================
+ Hits 1803 6460 +4657
- Misses 120 1050 +930
... and 130 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CarlesDD
approved these changes
Jun 15, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 20, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 20, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 21, 2023
This was referenced Jun 21, 2023
Merged
Merged
Merged
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It detects a vulnerability when
SameSite=Strictflag is not set in a set-cookie header. It is done in the same way as HttpOnly or Insecure cookie detections. It means that in this PR are more code in test that in source.Additional notes
The
res.cookiemethod from express didn't supportsameSiteparameter at the beginning of 4.x version. That is the reason why I am not testing in versions < 4.15.0.Checklist