Skip to content

Conversation

@nsavoire
Copy link
Collaborator

@nsavoire nsavoire commented Jun 14, 2023

What does this PR do?

Add debug log listing all files for which source maps have been found.
Use pprof version with source map debug info.

Motivation

  • Ease debugging customer issues.
  • Lock pprof-nodejs version in package.json to be make sure that customers use a dd-trace-js/pprof-nodejs combination that is well tested.

@nsavoire nsavoire requested a review from a team as a code owner June 14, 2023 15:54
@github-actions
Copy link

github-actions bot commented Jun 14, 2023

Overall package size

Self size: 4.36 MB
Deduped: 60.72 MB
No deduping: 60.77 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.2 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.3.1 784.66 kB 1.37 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #3242 (aefbb6e) into master (30ca014) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #3242      +/-   ##
==========================================
- Coverage   86.05%   86.05%   -0.01%     
==========================================
  Files         194      194              
  Lines        7517     7520       +3     
  Branches       33       33              
==========================================
+ Hits         6469     6471       +2     
- Misses       1048     1049       +1     
Impacted Files Coverage Δ
packages/dd-trace/src/profiling/profiler.js 93.87% <66.66%> (-0.86%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Jun 14, 2023

Benchmarks

Comparing candidate commit aefbb6e in PR branch nsavoire/debug_source_maps with baseline commit 30ca014 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 468 metrics, 24 unstable metrics.

tlhunter
tlhunter previously approved these changes Jun 14, 2023
@nsavoire nsavoire force-pushed the nsavoire/debug_source_maps branch 3 times, most recently from ae75eb4 to 42e65ee Compare June 14, 2023 17:41
@nsavoire nsavoire force-pushed the nsavoire/debug_source_maps branch from 42e65ee to 48b7b3c Compare June 20, 2023 08:18
@nsavoire nsavoire requested a review from a team June 20, 2023 10:14
@nsavoire nsavoire force-pushed the nsavoire/debug_source_maps branch from 89641c9 to 8917b17 Compare June 20, 2023 11:41
@nsavoire nsavoire changed the title Add debug log listing found source maps [profiling] Add debug log listing found source maps Jun 20, 2023
@nsavoire nsavoire removed the request for review from r1viollet June 20, 2023 13:07
@nsavoire nsavoire force-pushed the nsavoire/debug_source_maps branch from 8917b17 to 3523d57 Compare June 20, 2023 13:12
nsavoire added 2 commits June 20, 2023 15:26
Use pprof version with source map debug info.
Lock pprof version in package.json to be make sure that customers use
a dd-trace-js/pprof-nodejs combination that is well tested.
@nsavoire nsavoire force-pushed the nsavoire/debug_source_maps branch from 3523d57 to aefbb6e Compare June 20, 2023 13:26
@nsavoire nsavoire merged commit baf0a38 into master Jun 20, 2023
@nsavoire nsavoire deleted the nsavoire/debug_source_maps branch June 20, 2023 23:55
nsavoire added a commit that referenced this pull request Jun 21, 2023
* Add debug log listing found source maps

* Bump pprof required version

Use pprof version with source map debug info.
Lock pprof version in package.json to be make sure that customers use
a dd-trace-js/pprof-nodejs combination that is well tested.
nsavoire added a commit that referenced this pull request Jun 21, 2023
* Add debug log listing found source maps

* Bump pprof required version

Use pprof version with source map debug info.
Lock pprof version in package.json to be make sure that customers use
a dd-trace-js/pprof-nodejs combination that is well tested.
nsavoire added a commit that referenced this pull request Jun 21, 2023
* Add debug log listing found source maps

* Bump pprof required version

Use pprof version with source map debug info.
Lock pprof version in package.json to be make sure that customers use
a dd-trace-js/pprof-nodejs combination that is well tested.
This was referenced Jun 21, 2023
nsavoire added a commit that referenced this pull request Jun 21, 2023
* Add debug log listing found source maps

* Bump pprof required version

Use pprof version with source map debug info.
Lock pprof version in package.json to be make sure that customers use
a dd-trace-js/pprof-nodejs combination that is well tested.
nsavoire added a commit that referenced this pull request Jun 21, 2023
* Add debug log listing found source maps

* Bump pprof required version

Use pprof version with source map debug info.
Lock pprof version in package.json to be make sure that customers use
a dd-trace-js/pprof-nodejs combination that is well tested.
nsavoire added a commit that referenced this pull request Jun 21, 2023
* Add debug log listing found source maps

* Bump pprof required version

Use pprof version with source map debug info.
Lock pprof version in package.json to be make sure that customers use
a dd-trace-js/pprof-nodejs combination that is well tested.
nsavoire added a commit that referenced this pull request Jun 21, 2023
* Add debug log listing found source maps

* Bump pprof required version

Use pprof version with source map debug info.
Lock pprof version in package.json to be make sure that customers use
a dd-trace-js/pprof-nodejs combination that is well tested.
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
* Add debug log listing found source maps

* Bump pprof required version

Use pprof version with source map debug info.
Lock pprof version in package.json to be make sure that customers use
a dd-trace-js/pprof-nodejs combination that is well tested.
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
* Add debug log listing found source maps

* Bump pprof required version

Use pprof version with source map debug info.
Lock pprof version in package.json to be make sure that customers use
a dd-trace-js/pprof-nodejs combination that is well tested.
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
* Add debug log listing found source maps

* Bump pprof required version

Use pprof version with source map debug info.
Lock pprof version in package.json to be make sure that customers use
a dd-trace-js/pprof-nodejs combination that is well tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants