-
Notifications
You must be signed in to change notification settings - Fork 354
Add exclusions for weak hash vulnerabilities #3223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 4.25 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
| ] | ||
|
|
||
| const EXCLUDED_PATHS_FROM_STACK = [ | ||
| path.join('node_modules', 'object-hash', path.sep) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last path.sep is to force the directory name and not any other module that can be something like node_modules/object-hash-but-this-is-fake/index.js
Codecov Report
@@ Coverage Diff @@
## master #3223 +/- ##
==========================================
+ Coverage 85.72% 85.77% +0.05%
==========================================
Files 182 182
Lines 7229 7235 +6
Branches 33 33
==========================================
+ Hits 6197 6206 +9
+ Misses 1032 1029 -3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What does this PR do?
Excludes vulnerabilities to be detected preventing some false positives.
Motivation
We are detecting as vulnerability each time that vulnerable hashing algorithm as
sha1is used in the customer application. Sometimes, the use of this kind of algorithms doesn't involve a risk, and we can't prevent the the noise in the UI just excluding it.Plugin Checklist
Additional Notes