Skip to content

Conversation

@juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Jun 5, 2023

What does this PR do?

Fix situations where errors in after, before, beforeEach or afterEach hooks resulted in differences between the cypress and dd-trace reported test statuses.

Motivation

Fix customer issues.

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Overall package size

Self size: 4.3 MB
Deduped: 60.72 MB
No deduping: 60.76 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.10.1 843.35 kB 1.44 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jun 5, 2023

Benchmarks

Comparing candidate commit f24dd44 in PR branch juan-fernandez/fix-after-each-cypress with baseline commit 6f9085e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 439 metrics, 33 unstable metrics.

@juan-fernandez juan-fernandez force-pushed the juan-fernandez/fix-after-each-cypress branch from ff09996 to 51f8e8d Compare June 5, 2023 13:57
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #3214 (f24dd44) into master (6f9085e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3214   +/-   ##
=======================================
  Coverage   85.89%   85.89%           
=======================================
  Files         189      189           
  Lines        7416     7416           
  Branches       33       33           
=======================================
  Hits         6370     6370           
  Misses       1046     1046           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@juan-fernandez juan-fernandez marked this pull request as ready for review June 6, 2023 12:06
@juan-fernandez juan-fernandez requested a review from a team as a code owner June 6, 2023 12:06
@juan-fernandez juan-fernandez merged commit ad0736a into master Jun 9, 2023
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-after-each-cypress branch June 9, 2023 05:14
This was referenced Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants