-
Notifications
You must be signed in to change notification settings - Fork 352
Peer service computation #3177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Peer service computation #3177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 4.36 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
5b86ab7 to
9bb9c32
Compare
Codecov Report
@@ Coverage Diff @@
## master #3177 +/- ##
==========================================
- Coverage 86.02% 85.94% -0.09%
==========================================
Files 194 194
Lines 7514 7534 +20
Branches 33 33
==========================================
+ Hits 6464 6475 +11
- Misses 1050 1059 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1 task
70c8bc2 to
e3603e9
Compare
* add DD_TRACE_SPAN_PEER_SERVICE environment variable * add peer service computation logic * TODO: add tests for config, outbound, tracer (?)
e3603e9 to
e901fdb
Compare
tlhunter
approved these changes
Jun 22, 2023
This was referenced Jun 27, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jun 29, 2023
* introduce peer service computation for outbound edges:
* add DD_TRACE_SPAN_PEER_SERVICE environment variable
* add peer service computation logic
* TODO: add tests for config, outbound, tracer (?)
* provide a helper for testing peer service computation
* defer plugin `finish` to TracingPlugin in children
tlhunter
pushed a commit
that referenced
this pull request
Jun 29, 2023
* introduce peer service computation for outbound edges:
* add DD_TRACE_SPAN_PEER_SERVICE environment variable
* add peer service computation logic
* TODO: add tests for config, outbound, tracer (?)
* provide a helper for testing peer service computation
* defer plugin `finish` to TracingPlugin in children
tlhunter
pushed a commit
that referenced
this pull request
Jun 29, 2023
* introduce peer service computation for outbound edges:
* add DD_TRACE_SPAN_PEER_SERVICE environment variable
* add peer service computation logic
* TODO: add tests for config, outbound, tracer (?)
* provide a helper for testing peer service computation
* defer plugin `finish` to TracingPlugin in children
tlhunter
pushed a commit
that referenced
this pull request
Jun 29, 2023
* introduce peer service computation for outbound edges:
* add DD_TRACE_SPAN_PEER_SERVICE environment variable
* add peer service computation logic
* TODO: add tests for config, outbound, tracer (?)
* provide a helper for testing peer service computation
* defer plugin `finish` to TracingPlugin in children
tlhunter
pushed a commit
that referenced
this pull request
Jun 29, 2023
* introduce peer service computation for outbound edges:
* add DD_TRACE_SPAN_PEER_SERVICE environment variable
* add peer service computation logic
* TODO: add tests for config, outbound, tracer (?)
* provide a helper for testing peer service computation
* defer plugin `finish` to TracingPlugin in children
Merged
1 task
tlhunter
pushed a commit
that referenced
this pull request
Jun 30, 2023
* introduce peer service computation for outbound edges:
* add DD_TRACE_SPAN_PEER_SERVICE environment variable
* add peer service computation logic
* TODO: add tests for config, outbound, tracer (?)
* provide a helper for testing peer service computation
* defer plugin `finish` to TracingPlugin in children
tlhunter
pushed a commit
that referenced
this pull request
Jun 30, 2023
* introduce peer service computation for outbound edges:
* add DD_TRACE_SPAN_PEER_SERVICE environment variable
* add peer service computation logic
* TODO: add tests for config, outbound, tracer (?)
* provide a helper for testing peer service computation
* defer plugin `finish` to TracingPlugin in children
tlhunter
pushed a commit
that referenced
this pull request
Jun 30, 2023
* introduce peer service computation for outbound edges:
* add DD_TRACE_SPAN_PEER_SERVICE environment variable
* add peer service computation logic
* TODO: add tests for config, outbound, tracer (?)
* provide a helper for testing peer service computation
* defer plugin `finish` to TracingPlugin in children
tlhunter
pushed a commit
that referenced
this pull request
Jun 30, 2023
* introduce peer service computation for outbound edges:
* add DD_TRACE_SPAN_PEER_SERVICE environment variable
* add peer service computation logic
* TODO: add tests for config, outbound, tracer (?)
* provide a helper for testing peer service computation
* defer plugin `finish` to TracingPlugin in children
tlhunter
pushed a commit
that referenced
this pull request
Jun 30, 2023
* introduce peer service computation for outbound edges:
* add DD_TRACE_SPAN_PEER_SERVICE environment variable
* add peer service computation logic
* TODO: add tests for config, outbound, tracer (?)
* provide a helper for testing peer service computation
* defer plugin `finish` to TracingPlugin in children
tlhunter
pushed a commit
that referenced
this pull request
Jun 30, 2023
* introduce peer service computation for outbound edges:
* add DD_TRACE_SPAN_PEER_SERVICE environment variable
* add peer service computation logic
* TODO: add tests for config, outbound, tracer (?)
* provide a helper for testing peer service computation
* defer plugin `finish` to TracingPlugin in children
This was referenced Jul 3, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add peer service API for all spans of outgoing types, i.e. all
clientandproducerspans.Motivation
Introducing tags to provide the data necessary for a better service map with less fake services.
peer.service: the new source of truth for the service map, computed from precursor tags_dd.peer.service.source: the name of the tag use to get the value of peer serviceThese tags are added:
v0if the environment variableDD_TRACE_SPAN_PEER_SERVICEis set to a truthy valueComputing these uses the existing plugin hierarchy, with an optional
peerServicePrecursorsgetter on classes which have more precursors than the default OTel/DDogout.host/net.peer.hosttag.This PR enables the computation of peer service for all
ClientPluginchildren, but not all of them have tests for peer service. This is because they (mostly databases) do not all have the correct precursors yet, or precursor sources need to be added - currently, only common tags are present, although the mechanism to add more tags is available.Plugin Checklist
Additional Notes