Skip to content

Conversation

@simon-id
Copy link
Member

@simon-id simon-id commented May 17, 2023

What does this PR do?

Fix a bug where the ASM_DD remote config product would not be applied correctly when unapplied and applied in the same batch.

@simon-id simon-id self-assigned this May 17, 2023
@github-actions
Copy link

github-actions bot commented May 17, 2023

Overall package size

Self size: 4.16 MB
Deduped: 58.29 MB
No deduping: 58.34 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.1.0 13.31 MB 13.32 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #3165 (2da1953) into master (ca96946) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3165      +/-   ##
==========================================
+ Coverage   86.56%   86.59%   +0.03%     
==========================================
  Files         328      328              
  Lines       11873    11872       -1     
  Branches       33       33              
==========================================
+ Hits        10278    10281       +3     
+ Misses       1595     1591       -4     
Impacted Files Coverage Δ
packages/dd-trace/src/appsec/rule_manager.js 92.59% <100.00%> (+3.60%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented May 17, 2023

Benchmarks

Comparing candidate commit 2da1953 in PR branch fix_asmdd_batching with baseline commit ca96946 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 442 metrics, 30 unstable metrics.

@simon-id simon-id changed the title implement RC custom rules Fix ASM_DD batch update May 17, 2023
@simon-id simon-id marked this pull request as ready for review May 22, 2023 16:07
@simon-id simon-id requested a review from a team as a code owner May 22, 2023 16:07
@simon-id simon-id merged commit 4555ef6 into master May 23, 2023
thedavl pushed a commit that referenced this pull request May 30, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
This was referenced Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
@simon-id simon-id deleted the fix_asmdd_batching branch January 8, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants