Skip to content

Conversation

@rochdev
Copy link
Member

@rochdev rochdev commented May 12, 2023

What does this PR do?

Update readme for v4 and remove semver for version feature flags.

Motivation

Minor improvements now that 4.0 was just released.

@rochdev rochdev requested a review from a team as a code owner May 12, 2023 15:36
@rochdev rochdev marked this pull request as draft May 12, 2023 15:36
@github-actions
Copy link

github-actions bot commented May 12, 2023

Overall package size

Self size: 4.12 MB
Deduped: 58.25 MB
No deduping: 58.3 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.1.0 13.31 MB 13.32 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #3148 (b0f4b9f) into master (0aa6c48) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3148      +/-   ##
==========================================
- Coverage   87.12%   86.95%   -0.17%     
==========================================
  Files         322      322              
  Lines       11764    11763       -1     
  Branches       33       33              
==========================================
- Hits        10249    10229      -20     
- Misses       1515     1534      +19     
Impacted Files Coverage Δ
packages/datadog-instrumentations/src/jest.js 71.67% <100.00%> (-8.25%) ⬇️
packages/datadog-instrumentations/src/next.js 93.97% <100.00%> (ø)
packages/dd-trace/src/tracer.js 97.29% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rochdev rochdev changed the title update readme to include v4 update readme for v4 and remove semver for version feature flags May 12, 2023
@rochdev rochdev marked this pull request as ready for review May 12, 2023 15:56
@pr-commenter
Copy link

pr-commenter bot commented May 12, 2023

Benchmarks

Comparing candidate commit b0f4b9f in PR branch readme-v4 with baseline commit 0aa6c48 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 446 metrics, 26 unstable metrics.

@rochdev rochdev merged commit 563729a into master May 12, 2023
@rochdev rochdev deleted the readme-v4 branch May 12, 2023 16:17
thedavl pushed a commit that referenced this pull request May 30, 2023
* update readme to include v4

* use version module instead of semver to match library version
uurien pushed a commit that referenced this pull request Jun 1, 2023
* update readme to include v4

* use version module instead of semver to match library version
uurien pushed a commit that referenced this pull request Jun 2, 2023
* update readme to include v4

* use version module instead of semver to match library version
nsavoire pushed a commit that referenced this pull request Jun 20, 2023
* update readme to include v4

* use version module instead of semver to match library version
nsavoire pushed a commit that referenced this pull request Jun 21, 2023
* update readme to include v4

* use version module instead of semver to match library version
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
* update readme to include v4

* use version module instead of semver to match library version
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
* update readme to include v4

* use version module instead of semver to match library version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants