Skip to content

Conversation

@rochdev
Copy link
Member

@rochdev rochdev commented May 11, 2023

What does this PR do?

Update postgres tests to run on also latest Node.

Motivation

It makes it more difficult to bump the minimum version for 4.x otherwise. It's also tech debt we've had for a while as everything should be tested on latest Node.

@github-actions
Copy link

Overall package size

Self size: 4.11 MB
Deduped: 58.24 MB
No deduping: 58.29 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.1.0 13.31 MB 13.32 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #3142 (5b5bf5b) into master (29ebdad) will increase coverage by 2.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3142      +/-   ##
==========================================
+ Coverage   87.56%   89.92%   +2.35%     
==========================================
  Files         323      223     -100     
  Lines       11509     8685    -2824     
  Branches       33       33              
==========================================
- Hits        10078     7810    -2268     
+ Misses       1431      875     -556     

see 108 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rochdev rochdev marked this pull request as ready for review May 11, 2023 21:29
@rochdev rochdev requested a review from a team as a code owner May 11, 2023 21:29
@rochdev
Copy link
Member Author

rochdev commented May 11, 2023

Looks like the version range we support already supported newer Node versions, so this PR just cleans up the CI job.

@pr-commenter
Copy link

pr-commenter bot commented May 11, 2023

Benchmarks

Comparing candidate commit 5b5bf5b in PR branch pg-16 with baseline commit 29ebdad in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 665 metrics, 43 unstable metrics.

@rochdev rochdev merged commit f4fdf25 into master May 11, 2023
@rochdev rochdev deleted the pg-16 branch May 11, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants