Skip to content

Conversation

@rochdev
Copy link
Member

@rochdev rochdev commented May 11, 2023

What does this PR do?

Add migration guide for 3.x to 4.x.

Motivation

With 4.0 around the corner, we need a migration guide for upgrading from 3.x.

@rochdev rochdev requested a review from a team as a code owner May 11, 2023 12:24
@github-actions
Copy link

github-actions bot commented May 11, 2023

Overall package size

Self size: 4.11 MB
Deduped: 58.24 MB
No deduping: 58.29 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.1.0 13.31 MB 13.32 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #3137 (286ba98) into master (4e7da80) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3137      +/-   ##
==========================================
+ Coverage   87.15%   87.37%   +0.22%     
==========================================
  Files         316      326      +10     
  Lines       11585    11845     +260     
  Branches       33       33              
==========================================
+ Hits        10097    10350     +253     
- Misses       1488     1495       +7     

see 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

juan-fernandez
juan-fernandez previously approved these changes May 11, 2023
Copy link
Collaborator

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from ci visibility's perspective. Only two minor comments

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>
rochdev and others added 2 commits May 11, 2023 11:10
Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>
Co-authored-by: Ugaitz Urien <[email protected]>
@pr-commenter
Copy link

pr-commenter bot commented May 11, 2023

Benchmarks

Comparing candidate commit 286ba98 in PR branch migration-3-to-4 with baseline commit 4e7da80 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 670 metrics, 37 unstable metrics.

scenario:plugin-graphql-control-14

  • 🟥 execution_time [+0.356s; +0.559s] or [+13.514%; +21.254%]

@rochdev rochdev merged commit 0aa6c48 into master May 12, 2023
@rochdev rochdev deleted the migration-3-to-4 branch May 12, 2023 15:20
thedavl pushed a commit that referenced this pull request May 30, 2023
* add migration guide for 3.x to 4.x

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update README.md

Co-authored-by: Ugaitz Urien <[email protected]>

---------

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>
Co-authored-by: Ugaitz Urien <[email protected]>
uurien added a commit that referenced this pull request Jun 1, 2023
* add migration guide for 3.x to 4.x

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update README.md

Co-authored-by: Ugaitz Urien <[email protected]>

---------

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>
Co-authored-by: Ugaitz Urien <[email protected]>
uurien added a commit that referenced this pull request Jun 2, 2023
* add migration guide for 3.x to 4.x

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update README.md

Co-authored-by: Ugaitz Urien <[email protected]>

---------

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>
Co-authored-by: Ugaitz Urien <[email protected]>
nsavoire pushed a commit that referenced this pull request Jun 20, 2023
* add migration guide for 3.x to 4.x

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update README.md

Co-authored-by: Ugaitz Urien <[email protected]>

---------

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>
Co-authored-by: Ugaitz Urien <[email protected]>
nsavoire pushed a commit that referenced this pull request Jun 21, 2023
* add migration guide for 3.x to 4.x

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update README.md

Co-authored-by: Ugaitz Urien <[email protected]>

---------

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>
Co-authored-by: Ugaitz Urien <[email protected]>
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
* add migration guide for 3.x to 4.x

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update README.md

Co-authored-by: Ugaitz Urien <[email protected]>

---------

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>
Co-authored-by: Ugaitz Urien <[email protected]>
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
* add migration guide for 3.x to 4.x

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Update README.md

Co-authored-by: Ugaitz Urien <[email protected]>

---------

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>
Co-authored-by: Ugaitz Urien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants