-
Notifications
You must be signed in to change notification settings - Fork 351
Revert "Introduce service naming framework (#2941)" #3093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 4.01 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3093 +/- ##
==========================================
+ Coverage 86.83% 87.13% +0.29%
==========================================
Files 323 318 -5
Lines 11645 11565 -80
Branches 33 33
==========================================
- Hits 10112 10077 -35
+ Misses 1533 1488 -45
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
I'm still looking at profiles, won't merge unless we get a confirmation one way or the other. I reran the benchmarks, but the |
26162ec to
68a73cc
Compare
This is normal as we now always run only 1 benchmark per job so that everything can run in parallel. This warning should probably be removed from the benchmarking platform. |
This reverts commit 1de7a30.
68a73cc to
b2f922b
Compare
This reverts commit 1de7a30.
What does this PR do?
Revert #2941.
Motivation
#2941 seems to create mysterious benchmark instability. Reverting until I figure out what's wrong with it.