Skip to content

Conversation

@jbertran
Copy link
Contributor

@jbertran jbertran commented May 2, 2023

This reverts commit 1de7a30.

What does this PR do?

Revert #2941.

Motivation

#2941 seems to create mysterious benchmark instability. Reverting until I figure out what's wrong with it.

@jbertran jbertran requested a review from a team as a code owner May 2, 2023 09:50
@github-actions
Copy link

github-actions bot commented May 2, 2023

Overall package size

Self size: 4.01 MB
Deduped: 64.23 MB
No deduping: 64.27 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.4.0 14.89 MB 14.9 MB
@datadog/pprof 2.2.0 13.71 MB 14.59 MB
@datadog/native-appsec 3.1.0 13.31 MB 13.32 MB
@datadog/native-metrics 1.6.0 7.88 MB 7.89 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #3093 (b2f922b) into master (fc10e91) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3093      +/-   ##
==========================================
+ Coverage   86.83%   87.13%   +0.29%     
==========================================
  Files         323      318       -5     
  Lines       11645    11565      -80     
  Branches       33       33              
==========================================
- Hits        10112    10077      -35     
+ Misses       1533     1488      -45     
Impacted Files Coverage Δ
packages/dd-trace/src/config.js 98.81% <ø> (-0.06%) ⬇️
packages/dd-trace/src/plugin_manager.js 98.41% <ø> (-0.05%) ⬇️
packages/dd-trace/src/plugins/tracing.js 63.33% <ø> (+6.19%) ⬆️
packages/datadog-plugin-amqp10/src/consumer.js 88.88% <100.00%> (ø)
packages/datadog-plugin-amqp10/src/producer.js 90.90% <100.00%> (ø)
packages/datadog-plugin-amqplib/src/client.js 100.00% <100.00%> (ø)
packages/datadog-plugin-amqplib/src/consumer.js 100.00% <100.00%> (ø)
packages/datadog-plugin-amqplib/src/producer.js 100.00% <100.00%> (ø)
...s/datadog-plugin-google-cloud-pubsub/src/client.js 100.00% <100.00%> (ø)
...datadog-plugin-google-cloud-pubsub/src/consumer.js 100.00% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented May 2, 2023

Benchmarks

Comparing candidate commit b2f922b in PR branch jbertran/revert-svc-naming with baseline commit fc10e91 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 660 metrics, 48 unstable metrics.

@tlhunter
Copy link
Member

tlhunter commented May 2, 2023

I'm still not sure that this PR introduces the benchmark issues. It might be #2654 but I'm still trying to find out for sure.

@jbertran
Copy link
Contributor Author

jbertran commented May 3, 2023

I'm still not sure that this PR introduces the benchmark issues. It might be #2654 but I'm still trying to find out for sure.

I'm still looking at profiles, won't merge unless we get a confirmation one way or the other. I reran the benchmarks, but the pr-commenter stage warns that there was only one benchmark for each job, so I'm rebasing to check if we can get a full bench run + reports this way.

@jbertran jbertran force-pushed the jbertran/revert-svc-naming branch from 26162ec to 68a73cc Compare May 3, 2023 13:13
@rochdev
Copy link
Member

rochdev commented May 3, 2023

but the pr-commenter stage warns that there was only one benchmark for each job

This is normal as we now always run only 1 benchmark per job so that everything can run in parallel. This warning should probably be removed from the benchmarking platform.

@tlhunter tlhunter force-pushed the jbertran/revert-svc-naming branch from 68a73cc to b2f922b Compare May 3, 2023 20:07
@jbertran jbertran merged commit 4f2fb47 into master May 4, 2023
jbertran added a commit that referenced this pull request May 4, 2023
jbertran added a commit that referenced this pull request May 4, 2023
jbertran added a commit that referenced this pull request May 4, 2023
jbertran added a commit that referenced this pull request May 5, 2023
jbertran added a commit that referenced this pull request May 5, 2023
@tlhunter tlhunter deleted the jbertran/revert-svc-naming branch January 19, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants