-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-visibility] Keep functionality with .asyncResource
#2756
[ci-visibility] Keep functionality with .asyncResource
#2756
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2756 +/- ##
==========================================
- Coverage 89.24% 89.23% -0.02%
==========================================
Files 314 314
Lines 10863 10865 +2
Branches 33 33
==========================================
Hits 9695 9695
- Misses 1168 1170 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Overall package sizeSelf size: 3.73 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksComparing candidate commit 59eb796 in PR branch Found 1 performance improvements and 2 performance regressions! Performance is the same for 1197 cases. scenario:plugin-graphql-with-depth-on-max-16
scenario:encoders-0.4-18
scenario:plugin-http-server-with-tracer-18
|
What does this PR do?
Add
.asyncResource
if it's not there.Motivation
nodejs/node#46432 is going to deprecate
.asyncResource
property from the returned value fromasyncResource.bind
. This PR is for keeping the current functionality in themocha
plugin.