-
Notifications
You must be signed in to change notification settings - Fork 354
OTel SDK #2498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTel SDK #2498
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2498 +/- ##
==========================================
+ Coverage 85.72% 85.89% +0.17%
==========================================
Files 182 189 +7
Lines 7229 7416 +187
Branches 33 33
==========================================
+ Hits 6197 6370 +173
- Misses 1032 1046 +14
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksComparing candidate commit 02b475c in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 443 metrics, 28 unstable metrics. scenario:startup-control-everything-18
|
Overall package sizeSelf size: 4.3 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
c919a37 to
2f77127
Compare
86e3920 to
61340eb
Compare
|
This is all working now and passing all the system tests here: DataDog/system-tests#1237 As far as I can tell the only remaining thing missing is telemetry, but that should be straightforward. |
55c6b32 to
f039861
Compare
| interface winston extends Integration {} | ||
| } | ||
|
|
||
| export namespace opentelemetry { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's probably a way we could just link to OTel's API docs instead of including it directly here, but this should suffice for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typedoc would do that automatically, but I believe we turned that capability off to prevent OpenTracing from showing docs for features we didn't support. Which I suppose if we wanted to continue in that direction some of the docs for opentelemetry should be removed too as there are some interfaces we have to not break compatibility but are just no-ops currently.
What does this PR do?
Adds OpenTelemetry support to the tracer.
Motivation
We want a smooth way for users to integrate OpenTelemetry systems with dd-trace.