[ci-app] Add JUnit XML Report Upload #1367
Conversation
juan-fernandez
force-pushed
the
juan-fernandez/ci-app-core-tests-dogfood
branch
from
fda5b49
to
ae170db
Compare
Codecov Report
@@ Coverage Diff @@
## master #1367 +/- ##
=======================================
Coverage 94.23% 94.23%
=======================================
Files 155 155
Lines 6265 6265
=======================================
Hits 5904 5904
Misses 361 361 Continue to review full report at Codecov.
|
.circleci/config.yml
Outdated
| - run: | ||
| name: Upload JUnit XML Report | ||
| command: | | ||
| if [ -n "$CIRCLE_PR_NUMBER" ]; then |
There was a problem hiding this comment.
| return | ||
| } | ||
| if (process.env.CIRCLE_PR_NUMBER) { | ||
| console.log('Running in a fork. Skipping step.') |
There was a problem hiding this comment.
package.json
Outdated
| "codecov": "codecov" | ||
| "codecov": "codecov", | ||
| "junit:upload:ci": "node ./scripts/junit_report.js", | ||
| "junit:upload": "datadog-ci junit upload --tags runtime.version:$CI_NODE_VERSION --service dd-trace-js-core-tests ./test-results.xml" |
There was a problem hiding this comment.
Where does datadog-ci come from when running this if it's not in the dependencies?
There was a problem hiding this comment.
Also, what's the benefit of ever running this locally? Is there a way to differentiate between local and CI runs?
There was a problem hiding this comment.
yeah I'll just remove this and run it on the junit_report script file
|
any other concern @rochdev ? |
What does this PR do?
Add a step to upload the jUnit XML report from core unit tests to Datadog.
Motivation