-
Notifications
You must be signed in to change notification settings - Fork 318
Set benchmarking jobs to be interruptible outside master #9994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set benchmarking jobs to be interruptible outside master #9994
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~3684c74f7d, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1103043
Total [baseline] (8.853 s) : 0, 8852889
Agent [candidate] (1.104 s) : 0, 1104211
Total [candidate] (8.864 s) : 0, 8864331
section iast
Agent [baseline] (1.256 s) : 0, 1256451
Total [baseline] (9.586 s) : 0, 9585832
Agent [candidate] (1.244 s) : 0, 1244041
Total [candidate] (9.59 s) : 0, 9589652
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~3684c74f7d, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (708.749 ms) : 0, 708749
BytebuddyAgent [candidate] (709.837 ms) : 0, 709837
GlobalTracer [baseline] (249.791 ms) : 0, 249791
GlobalTracer [candidate] (250.187 ms) : 0, 250187
AppSec [baseline] (32.124 ms) : 0, 32124
AppSec [candidate] (32.184 ms) : 0, 32184
Debugger [baseline] (63.181 ms) : 0, 63181
Debugger [candidate] (62.886 ms) : 0, 62886
Remote Config [baseline] (634.081 µs) : 0, 634
Remote Config [candidate] (636.122 µs) : 0, 636
Telemetry [baseline] (8.331 ms) : 0, 8331
Telemetry [candidate] (8.299 ms) : 0, 8299
Flare Poller [baseline] (3.719 ms) : 0, 3719
Flare Poller [candidate] (3.733 ms) : 0, 3733
section iast
crashtracking [baseline] (1.496 ms) : 0, 1496
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (846.242 ms) : 0, 846242
BytebuddyAgent [candidate] (834.999 ms) : 0, 834999
GlobalTracer [baseline] (239.249 ms) : 0, 239249
GlobalTracer [candidate] (239.555 ms) : 0, 239555
AppSec [baseline] (32.561 ms) : 0, 32561
AppSec [candidate] (31.564 ms) : 0, 31564
Debugger [baseline] (60.208 ms) : 0, 60208
Debugger [candidate] (59.688 ms) : 0, 59688
Remote Config [baseline] (552.431 µs) : 0, 552
Remote Config [candidate] (532.773 µs) : 0, 533
Telemetry [baseline] (7.625 ms) : 0, 7625
Telemetry [candidate] (7.576 ms) : 0, 7576
Flare Poller [baseline] (3.557 ms) : 0, 3557
Flare Poller [candidate] (3.478 ms) : 0, 3478
IAST [baseline] (29.573 ms) : 0, 29573
IAST [candidate] (30.246 ms) : 0, 30246
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~3684c74f7d, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.114 s) : 0, 1113982
Total [baseline] (10.875 s) : 0, 10875466
Agent [candidate] (1.105 s) : 0, 1104724
Total [candidate] (10.804 s) : 0, 10804466
section appsec
Agent [baseline] (1.286 s) : 0, 1285821
Total [baseline] (11.137 s) : 0, 11137133
Agent [candidate] (1.293 s) : 0, 1292897
Total [candidate] (11.174 s) : 0, 11174356
section iast
Agent [baseline] (1.241 s) : 0, 1240725
Total [baseline] (11.265 s) : 0, 11265160
Agent [candidate] (1.266 s) : 0, 1266307
Total [candidate] (11.288 s) : 0, 11288445
section profiling
Agent [baseline] (1.239 s) : 0, 1239391
Total [baseline] (11.21 s) : 0, 11210244
Agent [candidate] (1.234 s) : 0, 1234413
Total [candidate] (11.24 s) : 0, 11240441
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~3684c74f7d, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (715.697 ms) : 0, 715697
BytebuddyAgent [candidate] (710.005 ms) : 0, 710005
GlobalTracer [baseline] (251.722 ms) : 0, 251722
GlobalTracer [candidate] (249.672 ms) : 0, 249672
AppSec [baseline] (32.379 ms) : 0, 32379
AppSec [candidate] (32.106 ms) : 0, 32106
Debugger [baseline] (64.757 ms) : 0, 64757
Debugger [candidate] (63.942 ms) : 0, 63942
Remote Config [baseline] (637.165 µs) : 0, 637
Remote Config [candidate] (642.841 µs) : 0, 643
Telemetry [baseline] (8.346 ms) : 0, 8346
Telemetry [candidate] (8.265 ms) : 0, 8265
Flare Poller [baseline] (3.737 ms) : 0, 3737
Flare Poller [candidate] (3.706 ms) : 0, 3706
section appsec
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (734.229 ms) : 0, 734229
BytebuddyAgent [candidate] (737.814 ms) : 0, 737814
GlobalTracer [baseline] (241.268 ms) : 0, 241268
GlobalTracer [candidate] (242.731 ms) : 0, 242731
AppSec [baseline] (174.922 ms) : 0, 174922
AppSec [candidate] (174.969 ms) : 0, 174969
Debugger [baseline] (61.346 ms) : 0, 61346
Debugger [candidate] (62.655 ms) : 0, 62655
Remote Config [baseline] (671.474 µs) : 0, 671
Remote Config [candidate] (675.228 µs) : 0, 675
Telemetry [baseline] (8.13 ms) : 0, 8130
Telemetry [candidate] (8.423 ms) : 0, 8423
Flare Poller [baseline] (3.843 ms) : 0, 3843
Flare Poller [candidate] (3.927 ms) : 0, 3927
IAST [baseline] (24.823 ms) : 0, 24823
IAST [candidate] (25.091 ms) : 0, 25091
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.495 ms) : 0, 1495
BytebuddyAgent [baseline] (832.276 ms) : 0, 832276
BytebuddyAgent [candidate] (853.437 ms) : 0, 853437
GlobalTracer [baseline] (237.875 ms) : 0, 237875
GlobalTracer [candidate] (240.269 ms) : 0, 240269
AppSec [baseline] (33.984 ms) : 0, 33984
AppSec [candidate] (34.179 ms) : 0, 34179
Debugger [baseline] (61.147 ms) : 0, 61147
Debugger [candidate] (61.222 ms) : 0, 61222
Remote Config [baseline] (553.329 µs) : 0, 553
Remote Config [candidate] (546.649 µs) : 0, 547
Telemetry [baseline] (7.619 ms) : 0, 7619
Telemetry [candidate] (7.765 ms) : 0, 7765
Flare Poller [baseline] (3.488 ms) : 0, 3488
Flare Poller [candidate] (3.536 ms) : 0, 3536
IAST [baseline] (27.368 ms) : 0, 27368
IAST [candidate] (28.37 ms) : 0, 28370
section profiling
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (737.578 ms) : 0, 737578
BytebuddyAgent [candidate] (735.071 ms) : 0, 735071
GlobalTracer [baseline] (224.511 ms) : 0, 224511
GlobalTracer [candidate] (223.34 ms) : 0, 223340
AppSec [baseline] (32.378 ms) : 0, 32378
AppSec [candidate] (32.101 ms) : 0, 32101
Debugger [baseline] (63.777 ms) : 0, 63777
Debugger [candidate] (63.03 ms) : 0, 63030
Remote Config [baseline] (663.488 µs) : 0, 663
Remote Config [candidate] (658.437 µs) : 0, 658
Telemetry [baseline] (8.127 ms) : 0, 8127
Telemetry [candidate] (8.05 ms) : 0, 8050
Flare Poller [baseline] (3.802 ms) : 0, 3802
Flare Poller [candidate] (3.803 ms) : 0, 3803
ProfilingAgent [baseline] (96.942 ms) : 0, 96942
ProfilingAgent [candidate] (97.083 ms) : 0, 97083
Profiling [baseline] (97.528 ms) : 0, 97528
Profiling [candidate] (97.668 ms) : 0, 97668
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~3684c74f7d, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section baseline
no_agent (19.23 ms) : 19031, 19428
. : milestone, 19230,
appsec (18.807 ms) : 18613, 19001
. : milestone, 18807,
code_origins (18.137 ms) : 17956, 18319
. : milestone, 18137,
iast (18.71 ms) : 18523, 18897
. : milestone, 18710,
profiling (19.433 ms) : 19232, 19633
. : milestone, 19433,
tracing (17.529 ms) : 17351, 17706
. : milestone, 17529,
section candidate
no_agent (18.439 ms) : 18252, 18627
. : milestone, 18439,
appsec (18.864 ms) : 18670, 19058
. : milestone, 18864,
code_origins (18.815 ms) : 18626, 19004
. : milestone, 18815,
iast (17.877 ms) : 17699, 18055
. : milestone, 17877,
profiling (20.775 ms) : 20567, 20984
. : milestone, 20775,
tracing (17.61 ms) : 17429, 17791
. : milestone, 17610,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~3684c74f7d, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section baseline
no_agent (1.207 ms) : 1196, 1219
. : milestone, 1207,
iast (3.234 ms) : 3191, 3276
. : milestone, 3234,
iast_FULL (5.857 ms) : 5799, 5916
. : milestone, 5857,
iast_GLOBAL (3.605 ms) : 3544, 3666
. : milestone, 3605,
profiling (2.115 ms) : 2095, 2135
. : milestone, 2115,
tracing (1.807 ms) : 1792, 1823
. : milestone, 1807,
section candidate
no_agent (1.207 ms) : 1195, 1219
. : milestone, 1207,
iast (3.249 ms) : 3206, 3291
. : milestone, 3249,
iast_FULL (5.974 ms) : 5914, 6034
. : milestone, 5974,
iast_GLOBAL (3.64 ms) : 3575, 3705
. : milestone, 3640,
profiling (2.139 ms) : 2118, 2160
. : milestone, 2139,
tracing (1.818 ms) : 1803, 1833
. : milestone, 1818,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~3684c74f7d, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section baseline
no_agent (14.912 s) : 14912000, 14912000
. : milestone, 14912000,
appsec (15.04 s) : 15040000, 15040000
. : milestone, 15040000,
iast (18.401 s) : 18401000, 18401000
. : milestone, 18401000,
iast_GLOBAL (17.953 s) : 17953000, 17953000
. : milestone, 17953000,
profiling (14.671 s) : 14671000, 14671000
. : milestone, 14671000,
tracing (14.939 s) : 14939000, 14939000
. : milestone, 14939000,
section candidate
no_agent (15.377 s) : 15377000, 15377000
. : milestone, 15377000,
appsec (14.689 s) : 14689000, 14689000
. : milestone, 14689000,
iast (18.306 s) : 18306000, 18306000
. : milestone, 18306000,
iast_GLOBAL (17.946 s) : 17946000, 17946000
. : milestone, 17946000,
profiling (14.681 s) : 14681000, 14681000
. : milestone, 14681000,
tracing (14.716 s) : 14716000, 14716000
. : milestone, 14716000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~3684c74f7d, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.743 ms) : 3523, 3963
. : milestone, 3743,
iast (2.225 ms) : 2160, 2290
. : milestone, 2225,
iast_GLOBAL (2.277 ms) : 2211, 2342
. : milestone, 2277,
profiling (2.068 ms) : 2016, 2120
. : milestone, 2068,
tracing (2.051 ms) : 2000, 2102
. : milestone, 2051,
section candidate
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (3.726 ms) : 3507, 3945
. : milestone, 3726,
iast (2.22 ms) : 2155, 2285
. : milestone, 2220,
iast_GLOBAL (2.271 ms) : 2205, 2336
. : milestone, 2271,
profiling (2.11 ms) : 2056, 2164
. : milestone, 2110,
tracing (2.063 ms) : 2011, 2114
. : milestone, 2063,
|
…ct-interrupt-policy
|
🎯 Code Coverage 🔗 Commit SHA: 3684c74 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
* set benchmarking jobs to be interruptible outside master * remove interruptible: true from benchmarks.yml * set macrobenchmarking jobs to be interuptible outside master * test interruptibility
What Does This Do
master..benchmarksand.macrobenchmarksare concerned. Kafka benchmarks and debugger benchmarks are not included, since they do not run onmaster.Motivation
APMSP-2369
#incident-45572
Additional Notes
Testing: benchmarking jobs being interrupted after a "test interruptibility" commit, a1649f3.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMSP-2369