-
Notifications
You must be signed in to change notification settings - Fork 319
Add springboot smoke tests for the open feature SDK #9961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add springboot smoke tests for the open feature SDK #9961
Conversation
fdda03b to
d926f7a
Compare
6fcda55 to
188fdc6
Compare
188fdc6 to
de1816f
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~1d5d526566, baseline=1.57.0-SNAPSHOT~2229c621bd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080256
Total [baseline] (10.834 s) : 0, 10834275
Agent [candidate] (1.082 s) : 0, 1081767
Total [candidate] (10.892 s) : 0, 10892066
section appsec
Agent [baseline] (1.266 s) : 0, 1265961
Total [baseline] (11.14 s) : 0, 11139584
Agent [candidate] (1.262 s) : 0, 1261809
Total [candidate] (11.142 s) : 0, 11142428
section iast
Agent [baseline] (1.23 s) : 0, 1230354
Total [baseline] (11.205 s) : 0, 11205429
Agent [candidate] (1.23 s) : 0, 1229537
Total [candidate] (11.204 s) : 0, 11203949
section profiling
Agent [baseline] (1.206 s) : 0, 1206403
Total [baseline] (11.039 s) : 0, 11038506
Agent [candidate] (1.203 s) : 0, 1203391
Total [candidate] (11.02 s) : 0, 11020227
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~1d5d526566, baseline=1.57.0-SNAPSHOT~2229c621bd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (648.142 ms) : 0, 648142
BytebuddyAgent [candidate] (648.19 ms) : 0, 648190
GlobalTracer [baseline] (281.45 ms) : 0, 281450
GlobalTracer [candidate] (282.036 ms) : 0, 282036
AppSec [baseline] (32.409 ms) : 0, 32409
AppSec [candidate] (32.339 ms) : 0, 32339
Debugger [baseline] (68.137 ms) : 0, 68137
Debugger [candidate] (68.938 ms) : 0, 68938
Remote Config [baseline] (645.774 µs) : 0, 646
Remote Config [candidate] (656.975 µs) : 0, 657
Telemetry [baseline] (8.965 ms) : 0, 8965
Telemetry [candidate] (9.137 ms) : 0, 9137
Flare Poller [baseline] (3.769 ms) : 0, 3769
Flare Poller [candidate] (3.817 ms) : 0, 3817
section appsec
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (689.66 ms) : 0, 689660
BytebuddyAgent [candidate] (687.243 ms) : 0, 687243
GlobalTracer [baseline] (259.571 ms) : 0, 259571
GlobalTracer [candidate] (258.573 ms) : 0, 258573
IAST [baseline] (24.589 ms) : 0, 24589
IAST [candidate] (24.543 ms) : 0, 24543
AppSec [baseline] (174.451 ms) : 0, 174451
AppSec [candidate] (174.79 ms) : 0, 174790
Debugger [baseline] (67.116 ms) : 0, 67116
Debugger [candidate] (66.457 ms) : 0, 66457
Remote Config [baseline] (696.884 µs) : 0, 697
Remote Config [candidate] (714.514 µs) : 0, 715
Telemetry [baseline] (9.085 ms) : 0, 9085
Telemetry [candidate] (9.047 ms) : 0, 9047
Flare Poller [baseline] (3.856 ms) : 0, 3856
Flare Poller [candidate] (3.836 ms) : 0, 3836
section iast
crashtracking [baseline] (1.24 ms) : 0, 1240
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (795.683 ms) : 0, 795683
BytebuddyAgent [candidate] (795.74 ms) : 0, 795740
GlobalTracer [baseline] (256.453 ms) : 0, 256453
GlobalTracer [candidate] (255.802 ms) : 0, 255802
IAST [baseline] (27.188 ms) : 0, 27188
IAST [candidate] (27.164 ms) : 0, 27164
AppSec [baseline] (35.522 ms) : 0, 35522
AppSec [candidate] (34.618 ms) : 0, 34618
Debugger [baseline] (66.172 ms) : 0, 66172
Debugger [candidate] (66.815 ms) : 0, 66815
Remote Config [baseline] (558.625 µs) : 0, 559
Remote Config [candidate] (584.16 µs) : 0, 584
Telemetry [baseline] (8.417 ms) : 0, 8417
Telemetry [candidate] (8.418 ms) : 0, 8418
Flare Poller [baseline] (3.452 ms) : 0, 3452
Flare Poller [candidate] (3.467 ms) : 0, 3467
section profiling
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (702.373 ms) : 0, 702373
BytebuddyAgent [candidate] (701.254 ms) : 0, 701254
GlobalTracer [baseline] (221.24 ms) : 0, 221240
GlobalTracer [candidate] (220.54 ms) : 0, 220540
AppSec [baseline] (32.393 ms) : 0, 32393
AppSec [candidate] (32.158 ms) : 0, 32158
Debugger [baseline] (68.253 ms) : 0, 68253
Debugger [candidate] (67.825 ms) : 0, 67825
Remote Config [baseline] (608.46 µs) : 0, 608
Remote Config [candidate] (613.68 µs) : 0, 614
Telemetry [baseline] (8.969 ms) : 0, 8969
Telemetry [candidate] (9.001 ms) : 0, 9001
Flare Poller [baseline] (3.773 ms) : 0, 3773
Flare Poller [candidate] (3.792 ms) : 0, 3792
ProfilingAgent [baseline] (97.993 ms) : 0, 97993
ProfilingAgent [candidate] (97.403 ms) : 0, 97403
Profiling [baseline] (98.569 ms) : 0, 98569
Profiling [candidate] (97.977 ms) : 0, 97977
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~1d5d526566, baseline=1.57.0-SNAPSHOT~2229c621bd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080314
Total [baseline] (8.774 s) : 0, 8774119
Agent [candidate] (1.088 s) : 0, 1087763
Total [candidate] (8.744 s) : 0, 8744388
section iast
Agent [baseline] (1.222 s) : 0, 1221952
Total [baseline] (9.429 s) : 0, 9429296
Agent [candidate] (1.219 s) : 0, 1219024
Total [candidate] (9.428 s) : 0, 9427525
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~1d5d526566, baseline=1.57.0-SNAPSHOT~2229c621bd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (648.239 ms) : 0, 648239
BytebuddyAgent [candidate] (653.352 ms) : 0, 653352
GlobalTracer [baseline] (282.084 ms) : 0, 282084
GlobalTracer [candidate] (283.587 ms) : 0, 283587
AppSec [baseline] (32.497 ms) : 0, 32497
AppSec [candidate] (32.715 ms) : 0, 32715
Debugger [baseline] (67.353 ms) : 0, 67353
Debugger [candidate] (66.791 ms) : 0, 66791
Remote Config [baseline] (678.331 µs) : 0, 678
Remote Config [candidate] (1.485 ms) : 0, 1485
Telemetry [baseline] (8.968 ms) : 0, 8968
Telemetry [candidate] (9.118 ms) : 0, 9118
Flare Poller [baseline] (3.76 ms) : 0, 3760
Flare Poller [candidate] (3.832 ms) : 0, 3832
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (788.409 ms) : 0, 788409
BytebuddyAgent [candidate] (788.437 ms) : 0, 788437
GlobalTracer [baseline] (256.475 ms) : 0, 256475
GlobalTracer [candidate] (255.156 ms) : 0, 255156
IAST [baseline] (27.172 ms) : 0, 27172
IAST [candidate] (27.564 ms) : 0, 27564
AppSec [baseline] (34.729 ms) : 0, 34729
AppSec [candidate] (34.441 ms) : 0, 34441
Debugger [baseline] (66.047 ms) : 0, 66047
Debugger [candidate] (64.362 ms) : 0, 64362
Remote Config [baseline] (592.11 µs) : 0, 592
Remote Config [candidate] (578.848 µs) : 0, 579
Telemetry [baseline] (8.425 ms) : 0, 8425
Telemetry [candidate] (8.403 ms) : 0, 8403
Flare Poller [baseline] (3.463 ms) : 0, 3463
Flare Poller [candidate] (3.497 ms) : 0, 3497
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~1d5d526566, baseline=1.57.0-SNAPSHOT~2229c621bd
dateFormat X
axisFormat %s
section baseline
no_agent (1.207 ms) : 1195, 1219
. : milestone, 1207,
iast (3.282 ms) : 3235, 3330
. : milestone, 3282,
iast_FULL (5.719 ms) : 5662, 5775
. : milestone, 5719,
iast_GLOBAL (3.659 ms) : 3600, 3718
. : milestone, 3659,
profiling (2.293 ms) : 2270, 2317
. : milestone, 2293,
tracing (1.894 ms) : 1876, 1912
. : milestone, 1894,
section candidate
no_agent (1.179 ms) : 1168, 1191
. : milestone, 1179,
iast (3.241 ms) : 3198, 3284
. : milestone, 3241,
iast_FULL (6.007 ms) : 5946, 6068
. : milestone, 6007,
iast_GLOBAL (3.528 ms) : 3476, 3579
. : milestone, 3528,
profiling (2.009 ms) : 1992, 2025
. : milestone, 2009,
tracing (1.8 ms) : 1785, 1816
. : milestone, 1800,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~1d5d526566, baseline=1.57.0-SNAPSHOT~2229c621bd
dateFormat X
axisFormat %s
section baseline
no_agent (18.175 ms) : 17990, 18359
. : milestone, 18175,
appsec (18.643 ms) : 18453, 18833
. : milestone, 18643,
code_origins (18.072 ms) : 17894, 18250
. : milestone, 18072,
iast (17.969 ms) : 17788, 18150
. : milestone, 17969,
profiling (19.649 ms) : 19449, 19849
. : milestone, 19649,
tracing (17.654 ms) : 17480, 17828
. : milestone, 17654,
section candidate
no_agent (19.065 ms) : 18872, 19258
. : milestone, 19065,
appsec (19.131 ms) : 18938, 19324
. : milestone, 19131,
code_origins (17.894 ms) : 17715, 18072
. : milestone, 17894,
iast (18.162 ms) : 17981, 18343
. : milestone, 18162,
profiling (18.999 ms) : 18804, 19195
. : milestone, 18999,
tracing (17.869 ms) : 17688, 18050
. : milestone, 17869,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~1d5d526566, baseline=1.57.0-SNAPSHOT~2229c621bd
dateFormat X
axisFormat %s
section baseline
no_agent (15.082 s) : 15082000, 15082000
. : milestone, 15082000,
appsec (14.698 s) : 14698000, 14698000
. : milestone, 14698000,
iast (18.288 s) : 18288000, 18288000
. : milestone, 18288000,
iast_GLOBAL (17.894 s) : 17894000, 17894000
. : milestone, 17894000,
profiling (14.507 s) : 14507000, 14507000
. : milestone, 14507000,
tracing (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
section candidate
no_agent (15.33 s) : 15330000, 15330000
. : milestone, 15330000,
appsec (14.552 s) : 14552000, 14552000
. : milestone, 14552000,
iast (18.339 s) : 18339000, 18339000
. : milestone, 18339000,
iast_GLOBAL (17.866 s) : 17866000, 17866000
. : milestone, 17866000,
profiling (14.54 s) : 14540000, 14540000
. : milestone, 14540000,
tracing (14.853 s) : 14853000, 14853000
. : milestone, 14853000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~1d5d526566, baseline=1.57.0-SNAPSHOT~2229c621bd
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.687 ms) : 3471, 3904
. : milestone, 3687,
iast (2.218 ms) : 2154, 2282
. : milestone, 2218,
iast_GLOBAL (2.268 ms) : 2203, 2332
. : milestone, 2268,
profiling (2.071 ms) : 2018, 2123
. : milestone, 2071,
tracing (2.059 ms) : 2008, 2110
. : milestone, 2059,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.718 ms) : 3496, 3940
. : milestone, 3718,
iast (2.227 ms) : 2163, 2292
. : milestone, 2227,
iast_GLOBAL (2.264 ms) : 2199, 2328
. : milestone, 2264,
profiling (2.092 ms) : 2038, 2146
. : milestone, 2092,
tracing (2.064 ms) : 2013, 2115
. : milestone, 2064,
|
d926f7a to
6d05d9a
Compare
6fea068 to
c73df5f
Compare
This comment has been minimized.
This comment has been minimized.
ddb9b65 to
cf1db21
Compare
8e8f321 to
6b99c46
Compare
effa6c3 to
0f57d15
Compare
6b99c46 to
6f66fc2
Compare
7550227 to
b65cb5e
Compare
359af31 to
61689a5
Compare
6fd2957 to
31a1f96
Compare
61689a5 to
52aa2a3
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 praise: Thanks for adding smoke tests
The app looks to crash at startup though 🤔
40b9326 to
fd73966
Compare
Thanks for the review. Yes, I forgot to remove the debugging configuration which I use locally to troubleshoot issues, should be fine by now 😄 |
c48da34 to
76eaefb
Compare
76eaefb to
cf018b2
Compare
What Does This Do
Adds smoke tests for the OpenFeature Java provider (PR)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]