-
Notifications
You must be signed in to change notification settings - Fork 319
move datastax cassandra to a super module #9454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ":dd-java-agent:instrumentation:datastax-cassandra-3", | ||
| ":dd-java-agent:instrumentation:datastax-cassandra-3.8", | ||
| ":dd-java-agent:instrumentation:datastax-cassandra-4", | ||
| ":dd-java-agent:instrumentation:datastax-cassandra:datastax-cassandra-3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: Does it make sense to change the last digit by an x (or else) to indicate it's a range? E.g.
| ":dd-java-agent:instrumentation:datastax-cassandra:datastax-cassandra-3.0", | |
| ":dd-java-agent:instrumentation:datastax-cassandra:datastax-cassandra-3.+", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a nice suggestion I didn't know it was possible. I personally prefer to explicitly put every module here but I don't know if it makes sense
|
🎯 Code Coverage 🔗 Commit SHA: 167d11a | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~167d11a07e, baseline=1.53.0-SNAPSHOT~0a4e9d0069
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050127
Total [baseline] (10.74 s) : 0, 10740440
Agent [candidate] (1.057 s) : 0, 1057057
Total [candidate] (10.76 s) : 0, 10759503
section appsec
Agent [baseline] (1.225 s) : 0, 1225253
Total [baseline] (10.793 s) : 0, 10793270
Agent [candidate] (1.222 s) : 0, 1222445
Total [candidate] (10.871 s) : 0, 10870974
section iast
Agent [baseline] (1.183 s) : 0, 1182987
Total [baseline] (10.92 s) : 0, 10919650
Agent [candidate] (1.181 s) : 0, 1180550
Total [candidate] (10.978 s) : 0, 10978015
section profiling
Agent [baseline] (1.198 s) : 0, 1198047
Total [baseline] (10.949 s) : 0, 10948952
Agent [candidate] (1.197 s) : 0, 1197115
Total [candidate] (10.917 s) : 0, 10917444
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~167d11a07e, baseline=1.53.0-SNAPSHOT~0a4e9d0069
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (734.132 ms) : 0, 734132
BytebuddyAgent [candidate] (740.067 ms) : 0, 740067
GlobalTracer [baseline] (242.985 ms) : 0, 242985
GlobalTracer [candidate] (244.761 ms) : 0, 244761
AppSec [baseline] (30.067 ms) : 0, 30067
AppSec [candidate] (30.438 ms) : 0, 30438
Debugger [baseline] (6.036 ms) : 0, 6036
Debugger [candidate] (6.083 ms) : 0, 6083
Remote Config [baseline] (671.478 µs) : 0, 671
Remote Config [candidate] (672.008 µs) : 0, 672
Telemetry [baseline] (13.69 ms) : 0, 13690
Telemetry [candidate] (12.366 ms) : 0, 12366
section appsec
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (756.609 ms) : 0, 756609
BytebuddyAgent [candidate] (754.967 ms) : 0, 754967
GlobalTracer [baseline] (235.797 ms) : 0, 235797
GlobalTracer [candidate] (235.447 ms) : 0, 235447
AppSec [baseline] (168.017 ms) : 0, 168017
AppSec [candidate] (170.145 ms) : 0, 170145
Debugger [baseline] (8.011 ms) : 0, 8011
Debugger [candidate] (6.526 ms) : 0, 6526
Remote Config [baseline] (639.769 µs) : 0, 640
Remote Config [candidate] (666.838 µs) : 0, 667
Telemetry [baseline] (10.008 ms) : 0, 10008
Telemetry [candidate] (8.527 ms) : 0, 8527
IAST [baseline] (23.594 ms) : 0, 23594
IAST [candidate] (23.6 ms) : 0, 23600
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (853.821 ms) : 0, 853821
BytebuddyAgent [candidate] (851.877 ms) : 0, 851877
GlobalTracer [baseline] (233.62 ms) : 0, 233620
GlobalTracer [candidate] (233.04 ms) : 0, 233040
AppSec [baseline] (26.89 ms) : 0, 26890
AppSec [candidate] (27.958 ms) : 0, 27958
Debugger [baseline] (5.803 ms) : 0, 5803
Debugger [candidate] (7.566 ms) : 0, 7566
Remote Config [baseline] (603.969 µs) : 0, 604
Remote Config [candidate] (605.576 µs) : 0, 606
Telemetry [baseline] (8.367 ms) : 0, 8367
Telemetry [candidate] (8.334 ms) : 0, 8334
IAST [baseline] (31.363 ms) : 0, 31363
IAST [candidate] (28.604 ms) : 0, 28604
section profiling
ProfilingAgent [baseline] (107.94 ms) : 0, 107940
ProfilingAgent [candidate] (108.406 ms) : 0, 108406
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (762.406 ms) : 0, 762406
BytebuddyAgent [candidate] (761.699 ms) : 0, 761699
GlobalTracer [baseline] (222.429 ms) : 0, 222429
GlobalTracer [candidate] (222.662 ms) : 0, 222662
AppSec [baseline] (30.042 ms) : 0, 30042
AppSec [candidate] (29.979 ms) : 0, 29979
Debugger [baseline] (6.26 ms) : 0, 6260
Debugger [candidate] (6.322 ms) : 0, 6322
Remote Config [baseline] (718.822 µs) : 0, 719
Remote Config [candidate] (697.19 µs) : 0, 697
Telemetry [baseline] (16.327 ms) : 0, 16327
Telemetry [candidate] (15.542 ms) : 0, 15542
Profiling [baseline] (108.624 ms) : 0, 108624
Profiling [candidate] (109.056 ms) : 0, 109056
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~167d11a07e, baseline=1.53.0-SNAPSHOT~0a4e9d0069
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049273
Total [baseline] (8.634 s) : 0, 8634338
Agent [candidate] (1.049 s) : 0, 1049452
Total [candidate] (8.641 s) : 0, 8640658
section iast
Agent [baseline] (1.187 s) : 0, 1186856
Total [baseline] (9.336 s) : 0, 9336161
Agent [candidate] (1.178 s) : 0, 1178367
Total [candidate] (9.311 s) : 0, 9311280
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~167d11a07e, baseline=1.53.0-SNAPSHOT~0a4e9d0069
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (733.942 ms) : 0, 733942
BytebuddyAgent [candidate] (734.22 ms) : 0, 734220
GlobalTracer [baseline] (242.999 ms) : 0, 242999
GlobalTracer [candidate] (242.963 ms) : 0, 242963
AppSec [baseline] (30.261 ms) : 0, 30261
AppSec [candidate] (30.137 ms) : 0, 30137
Debugger [baseline] (6.055 ms) : 0, 6055
Debugger [candidate] (6.061 ms) : 0, 6061
Remote Config [baseline] (672.406 µs) : 0, 672
Remote Config [candidate] (670.27 µs) : 0, 670
Telemetry [baseline] (12.893 ms) : 0, 12893
Telemetry [candidate] (12.933 ms) : 0, 12933
section iast
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (857.41 ms) : 0, 857410
BytebuddyAgent [candidate] (850.457 ms) : 0, 850457
GlobalTracer [baseline] (233.841 ms) : 0, 233841
GlobalTracer [candidate] (232.741 ms) : 0, 232741
IAST [baseline] (27.091 ms) : 0, 27091
IAST [candidate] (32.03 ms) : 0, 32030
AppSec [baseline] (31.049 ms) : 0, 31049
AppSec [candidate] (26.004 ms) : 0, 26004
Debugger [baseline] (5.813 ms) : 0, 5813
Debugger [candidate] (5.812 ms) : 0, 5812
Remote Config [baseline] (630.458 µs) : 0, 630
Remote Config [candidate] (596.846 µs) : 0, 597
Telemetry [baseline] (8.469 ms) : 0, 8469
Telemetry [candidate] (8.272 ms) : 0, 8272
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~167d11a07e, baseline=1.53.0-SNAPSHOT~0a4e9d0069
dateFormat X
axisFormat %s
section baseline
no_agent (38.324 ms) : 38004, 38645
. : milestone, 38324,
appsec (47.282 ms) : 46863, 47701
. : milestone, 47282,
code_origins (44.977 ms) : 44586, 45368
. : milestone, 44977,
iast (46.113 ms) : 45714, 46512
. : milestone, 46113,
profiling (48.296 ms) : 47801, 48791
. : milestone, 48296,
tracing (43.391 ms) : 43020, 43762
. : milestone, 43391,
section candidate
no_agent (37.61 ms) : 37306, 37915
. : milestone, 37610,
appsec (48.74 ms) : 48292, 49189
. : milestone, 48740,
code_origins (46.094 ms) : 45685, 46502
. : milestone, 46094,
iast (45.413 ms) : 45027, 45799
. : milestone, 45413,
profiling (50.977 ms) : 50511, 51442
. : milestone, 50977,
tracing (44.738 ms) : 44354, 45122
. : milestone, 44738,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~167d11a07e, baseline=1.53.0-SNAPSHOT~0a4e9d0069
dateFormat X
axisFormat %s
section baseline
no_agent (4.415 ms) : 4363, 4468
. : milestone, 4415,
iast (9.357 ms) : 9205, 9510
. : milestone, 9357,
iast_FULL (13.753 ms) : 13478, 14029
. : milestone, 13753,
iast_GLOBAL (10.249 ms) : 10070, 10428
. : milestone, 10249,
profiling (8.263 ms) : 8139, 8388
. : milestone, 8263,
tracing (7.836 ms) : 7723, 7949
. : milestone, 7836,
section candidate
no_agent (4.467 ms) : 4417, 4517
. : milestone, 4467,
iast (9.252 ms) : 9096, 9408
. : milestone, 9252,
iast_FULL (13.966 ms) : 13688, 14244
. : milestone, 13966,
iast_GLOBAL (10.31 ms) : 10126, 10493
. : milestone, 10310,
profiling (8.755 ms) : 8612, 8898
. : milestone, 8755,
tracing (7.65 ms) : 7541, 7759
. : milestone, 7650,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~167d11a07e, baseline=1.53.0-SNAPSHOT~0a4e9d0069
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.666 ms) : 3449, 3884
. : milestone, 3666,
iast (2.193 ms) : 2130, 2255
. : milestone, 2193,
iast_GLOBAL (2.243 ms) : 2179, 2307
. : milestone, 2243,
profiling (2.491 ms) : 2322, 2659
. : milestone, 2491,
tracing (2.012 ms) : 1963, 2061
. : milestone, 2012,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.471 ms) : 2417, 2524
. : milestone, 2471,
iast (2.202 ms) : 2139, 2266
. : milestone, 2202,
iast_GLOBAL (2.24 ms) : 2177, 2303
. : milestone, 2240,
profiling (2.041 ms) : 1990, 2092
. : milestone, 2041,
tracing (2.026 ms) : 1977, 2076
. : milestone, 2026,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~167d11a07e, baseline=1.53.0-SNAPSHOT~0a4e9d0069
dateFormat X
axisFormat %s
section baseline
no_agent (15.506 s) : 15506000, 15506000
. : milestone, 15506000,
appsec (14.851 s) : 14851000, 14851000
. : milestone, 14851000,
iast (18.181 s) : 18181000, 18181000
. : milestone, 18181000,
iast_GLOBAL (17.956 s) : 17956000, 17956000
. : milestone, 17956000,
profiling (15.479 s) : 15479000, 15479000
. : milestone, 15479000,
tracing (14.836 s) : 14836000, 14836000
. : milestone, 14836000,
section candidate
no_agent (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
appsec (14.796 s) : 14796000, 14796000
. : milestone, 14796000,
iast (18.373 s) : 18373000, 18373000
. : milestone, 18373000,
iast_GLOBAL (17.998 s) : 17998000, 17998000
. : milestone, 17998000,
profiling (15.378 s) : 15378000, 15378000
. : milestone, 15378000,
tracing (14.797 s) : 14797000, 14797000
. : milestone, 14797000,
|
What Does This Do
Regroup cassandra instrumentation under a common folder
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]