Skip to content

Conversation

@randomanderson
Copy link
Contributor

What Does This Do

Properly runs tests using the default test_matrix.

There's an interaction where parallel isn't being used for test splitting but just for separate jvms. he script sees CI_NODE_TOTAL=12 and CI_NODE_INDEX=1, because is a test_matrix (8, 11, 17, etc). It then uses our modulo test splitting to assign tests to nodes and sees that no tests are assigned to the current node. By explicitly setting 1/1, no tests are improperly skipped.

Motivation

For test_debugging and test_profiling, many tests were skipped that should not have been.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@randomanderson randomanderson requested a review from jpbempel July 25, 2025 19:29
@randomanderson randomanderson added the tag: no release notes Changes to exclude from release notes label Jul 25, 2025
@randomanderson randomanderson requested a review from a team as a code owner July 25, 2025 19:29
@randomanderson randomanderson added the comp: tooling Build & Tooling label Jul 25, 2025
@randomanderson randomanderson requested review from TonyCTHsu and removed request for a team July 25, 2025 19:29
@randomanderson randomanderson enabled auto-merge (squash) July 25, 2025 19:29
@randomanderson randomanderson merged commit ae34f27 into master Jul 25, 2025
505 checks passed
@randomanderson randomanderson deleted the landerson/fix-test-split branch July 25, 2025 21:51
@github-actions github-actions bot added this to the 1.52.0 milestone Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants