Fix CI_SPLIT for base case test matrix #9248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Properly runs tests using the default
test_matrix.There's an interaction where
parallelisn't being used for test splitting but just for separate jvms. he script sees CI_NODE_TOTAL=12 and CI_NODE_INDEX=1, because is a test_matrix (8, 11, 17, etc). It then uses our modulo test splitting to assign tests to nodes and sees that no tests are assigned to the current node. By explicitly setting1/1, no tests are improperly skipped.Motivation
For
test_debuggingandtest_profiling, many tests were skipped that should not have been.Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]