Skip to content

Change primary client stats configuration key #9196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Change primary client stats configuration key #9196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dd-trace-api/src/main/java/datadog/trace/api/config/GeneralConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public final class GeneralConfig {
public static final String HEALTH_METRICS_STATSD_PORT = "trace.health.metrics.statsd.port";
public static final String PERF_METRICS_ENABLED = "trace.perf.metrics.enabled";

public static final String TRACE_STATS_COMPUTATION_ENABLED = "trace.stats.computation.enabled";
public static final String TRACER_METRICS_ENABLED = "trace.tracer.metrics.enabled";
Copy link
Contributor

@bric3 bric3 Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be marked as deprecated ?

Copy link
Contributor Author

@amarziali amarziali Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good point. I can do another follow up PR for this (as soon as we deprecate it in the public doc btw). Sorry it automerged

public static final String TRACER_METRICS_BUFFERING_ENABLED =
"trace.tracer.metrics.buffering.enabled";
Expand Down
2 changes: 1 addition & 1 deletion dd-trace-core/src/test/groovy/datadog/trace/common/metrics/MetricsReliabilityTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class MetricsReliabilityTest extends DDCoreSpecification {
agent.start()
def props = new Properties()
props.put("trace.agent.url", agent.getAddress().toString())
props.put("trace.tracer.metrics.enabled", "true")
props.put("trace.stats.computation.enabled", "true")
def config = Config.get(props)
def sharedComm = new SharedCommunicationObjects()
sharedComm.createRemaining(config)
Expand Down
5 changes: 4 additions & 1 deletion internal-api/src/main/java/datadog/trace/api/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@
import static datadog.trace.api.config.GeneralConfig.TRACER_METRICS_MAX_AGGREGATES;
import static datadog.trace.api.config.GeneralConfig.TRACER_METRICS_MAX_PENDING;
import static datadog.trace.api.config.GeneralConfig.TRACE_DEBUG;
import static datadog.trace.api.config.GeneralConfig.TRACE_STATS_COMPUTATION_ENABLED;
import static datadog.trace.api.config.GeneralConfig.TRACE_TAGS;
import static datadog.trace.api.config.GeneralConfig.TRACE_TRIAGE;
import static datadog.trace.api.config.GeneralConfig.TRIAGE_REPORT_DIR;
Expand Down Expand Up @@ -1785,7 +1786,9 @@ private Config(final ConfigProvider configProvider, final InstrumenterConfig ins
&& configProvider.getBoolean(PERF_METRICS_ENABLED, DEFAULT_PERF_METRICS_ENABLED);

// Enable tracer computed trace metrics by default for Azure Functions
tracerMetricsEnabled = configProvider.getBoolean(TRACER_METRICS_ENABLED, azureFunctions);
tracerMetricsEnabled =
configProvider.getBoolean(
TRACE_STATS_COMPUTATION_ENABLED, azureFunctions, TRACER_METRICS_ENABLED);
tracerMetricsBufferingEnabled =
configProvider.getBoolean(TRACER_METRICS_BUFFERING_ENABLED, false);
tracerMetricsMaxAggregates = configProvider.getInteger(TRACER_METRICS_MAX_AGGREGATES, 2048);
Expand Down