spark plan test looks at consistent naming vs actual node values #9182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobuchowski
force-pushed
the
mobuchowski/spark-remap-node-ids
branch
2 times, most recently
from
a70f763 to
5ce4bf0
Compare
amarziali
added
comp: testing
amarziali
approved these changes
Jul 16, 2025
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
[email protected] unqueued this merge request |
Contributor
Author
|
/remove |
|
View all feedbacks in Devflow UI.
|
dd-devflow
bot
added
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
Signed-off-by: Maciej Obuchowski <[email protected]>
mobuchowski
force-pushed
the
mobuchowski/spark-remap-node-ids
branch
from
5ce4bf0 to
58491b3
Compare
aboitreaud
approved these changes
Jul 16, 2025
mhlidd
pushed a commit
that referenced
this pull request
Jul 17, 2025
Signed-off-by: Maciej Obuchowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Instead of looking at the hardcoded nodeId values, that are hashes of node
toStringmethod which can vary, we only check whether the nodeId naming captured by the instrumentation is consistent - so, whether value between plans that refer to the same node has the same id.This is done by remapping the ids to sequential
nodeId_Xvalues if they haven't been seen already, and assigning the value if it has been seen before.