Refactored build scripts to use Spock version from catalog. #9164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyKuznetsov-DD
added
type: enhancement
AlexeyKuznetsov-DD
requested review from
PerfectSlayer,
bric3,
dougqh,
jandro996,
robertpi and
smola
bric3
reviewed
Jul 11, 2025
Comment on lines
67
to
69
| latestDepBootTestImplementation group: 'org.spockframework', name: 'spock-core', version: libs.versions.spock24.get() | ||
| latestDepBootTestImplementation group: 'org.spockframework', name: 'spock-junit4', version: libs.versions.spock24.get() | ||
| latestDepBootTestImplementation group: 'org.spockframework', name: 'spock-spring', version: libs.versions.spock24.get() |
Contributor
There was a problem hiding this comment.
suggestion: Might be replaced by a catalog bundle.
Contributor
Author
There was a problem hiding this comment.
Refactored to use bundle.
Contributor
There was a problem hiding this comment.
I would avoid using the library catalog for instrumentation dependencies as it will get messy real quick
As far as I know there is no instrumentation related dependency from this catalog and I would rather keep the default one to the platform / base components only.
We can create dedicated ones within instrumentation folder if it's better though. But reusing the main one will be extra tedious for future platform update and understanding which libraries are effectively used / bundle.
Contributor
There was a problem hiding this comment.
Gradle allows to declarare custom catalog, so we could craft an instrumentation specific catalog.
Is that what you meant?
Contributor
There was a problem hiding this comment.
Yes, if we want to move to version catalog for instrumentation, better use a dedicate one to split the concern. Would you be able to follow up with that change?
Contributor
There was a problem hiding this comment.
👍 I will write in my plan, either me or @AlexeyKuznetsov-DD can proceed
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~44175d28d0, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.0 s) : 0, 1000429
Total [baseline] (8.582 s) : 0, 8581902
Agent [candidate] (993.957 ms) : 0, 993957
Total [candidate] (8.573 s) : 0, 8572671
section iast
Agent [baseline] (1.133 s) : 0, 1133123
Total [baseline] (9.332 s) : 0, 9332288
Agent [candidate] (1.139 s) : 0, 1139403
Total [candidate] (9.307 s) : 0, 9306814
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~44175d28d0, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.932 ms) : 0, 690932
BytebuddyAgent [candidate] (686.121 ms) : 0, 686121
GlobalTracer [baseline] (243.527 ms) : 0, 243527
GlobalTracer [candidate] (241.94 ms) : 0, 241940
AppSec [baseline] (30.219 ms) : 0, 30219
AppSec [candidate] (30.302 ms) : 0, 30302
Debugger [baseline] (6.005 ms) : 0, 6005
Debugger [candidate] (5.973 ms) : 0, 5973
Remote Config [baseline] (684.911 µs) : 0, 685
Remote Config [candidate] (676.398 µs) : 0, 676
Telemetry [baseline] (8.235 ms) : 0, 8235
Telemetry [candidate] (8.199 ms) : 0, 8199
section iast
BytebuddyAgent [baseline] (807.518 ms) : 0, 807518
BytebuddyAgent [candidate] (812.106 ms) : 0, 812106
GlobalTracer [baseline] (232.707 ms) : 0, 232707
GlobalTracer [candidate] (233.439 ms) : 0, 233439
IAST [baseline] (26.492 ms) : 0, 26492
IAST [candidate] (27.613 ms) : 0, 27613
AppSec [baseline] (29.68 ms) : 0, 29680
AppSec [candidate] (30.153 ms) : 0, 30153
Debugger [baseline] (7.455 ms) : 0, 7455
Debugger [candidate] (6.649 ms) : 0, 6649
Remote Config [baseline] (577.611 µs) : 0, 578
Remote Config [candidate] (598.941 µs) : 0, 599
Telemetry [baseline] (7.917 ms) : 0, 7917
Telemetry [candidate] (8.002 ms) : 0, 8002
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~44175d28d0, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (995.988 ms) : 0, 995988
Total [baseline] (10.656 s) : 0, 10656437
Agent [candidate] (995.306 ms) : 0, 995306
Total [candidate] (10.626 s) : 0, 10626486
section appsec
Agent [baseline] (1.177 s) : 0, 1176630
Total [baseline] (10.74 s) : 0, 10739728
Agent [candidate] (1.174 s) : 0, 1174457
Total [candidate] (10.771 s) : 0, 10770863
section iast
Agent [baseline] (1.128 s) : 0, 1128002
Total [baseline] (10.88 s) : 0, 10880449
Agent [candidate] (1.131 s) : 0, 1130726
Total [candidate] (10.874 s) : 0, 10874159
section profiling
Agent [baseline] (1.251 s) : 0, 1250720
Total [baseline] (11.008 s) : 0, 11008135
Agent [candidate] (1.242 s) : 0, 1241869
Total [candidate] (10.95 s) : 0, 10950112
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~44175d28d0, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.221 ms) : 0, 687221
BytebuddyAgent [candidate] (686.746 ms) : 0, 686746
GlobalTracer [baseline] (242.448 ms) : 0, 242448
GlobalTracer [candidate] (242.58 ms) : 0, 242580
AppSec [baseline] (30.51 ms) : 0, 30510
AppSec [candidate] (30.247 ms) : 0, 30247
Debugger [baseline] (6.019 ms) : 0, 6019
Debugger [candidate] (6.012 ms) : 0, 6012
Remote Config [baseline] (678.382 µs) : 0, 678
Remote Config [candidate] (677.268 µs) : 0, 677
Telemetry [baseline] (8.245 ms) : 0, 8245
Telemetry [candidate] (8.191 ms) : 0, 8191
section appsec
BytebuddyAgent [baseline] (710.099 ms) : 0, 710099
BytebuddyAgent [candidate] (709.396 ms) : 0, 709396
GlobalTracer [baseline] (235.636 ms) : 0, 235636
GlobalTracer [candidate] (235.291 ms) : 0, 235291
IAST [baseline] (23.686 ms) : 0, 23686
IAST [candidate] (23.479 ms) : 0, 23479
AppSec [baseline] (171.93 ms) : 0, 171930
AppSec [candidate] (170.986 ms) : 0, 170986
Debugger [baseline] (5.753 ms) : 0, 5753
Debugger [candidate] (5.753 ms) : 0, 5753
Remote Config [baseline] (596.059 µs) : 0, 596
Remote Config [candidate] (596.946 µs) : 0, 597
Telemetry [baseline] (8.01 ms) : 0, 8010
Telemetry [candidate] (8.038 ms) : 0, 8038
section iast
BytebuddyAgent [baseline] (803.537 ms) : 0, 803537
BytebuddyAgent [candidate] (805.463 ms) : 0, 805463
GlobalTracer [baseline] (231.77 ms) : 0, 231770
GlobalTracer [candidate] (232.604 ms) : 0, 232604
IAST [baseline] (28.931 ms) : 0, 28931
IAST [candidate] (26.463 ms) : 0, 26463
AppSec [baseline] (28.086 ms) : 0, 28086
AppSec [candidate] (31.253 ms) : 0, 31253
Debugger [baseline] (6.599 ms) : 0, 6599
Debugger [candidate] (5.718 ms) : 0, 5718
Remote Config [baseline] (576.182 µs) : 0, 576
Remote Config [candidate] (576.734 µs) : 0, 577
Telemetry [baseline] (7.823 ms) : 0, 7823
Telemetry [candidate] (7.892 ms) : 0, 7892
section profiling
BytebuddyAgent [baseline] (681.356 ms) : 0, 681356
BytebuddyAgent [candidate] (676.399 ms) : 0, 676399
GlobalTracer [baseline] (363.022 ms) : 0, 363022
GlobalTracer [candidate] (360.968 ms) : 0, 360968
AppSec [baseline] (34.77 ms) : 0, 34770
AppSec [candidate] (33.135 ms) : 0, 33135
Debugger [baseline] (9.813 ms) : 0, 9813
Debugger [candidate] (9.105 ms) : 0, 9105
Remote Config [baseline] (672.342 µs) : 0, 672
Remote Config [candidate] (661.067 µs) : 0, 661
Telemetry [baseline] (8.035 ms) : 0, 8035
Telemetry [candidate] (10.223 ms) : 0, 10223
ProfilingAgent [baseline] (104.211 ms) : 0, 104211
ProfilingAgent [candidate] (102.753 ms) : 0, 102753
Profiling [baseline] (104.236 ms) : 0, 104236
Profiling [candidate] (102.778 ms) : 0, 102778
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~44175d28d0, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section baseline
no_agent (4.47 ms) : 4419, 4521
. : milestone, 4470,
iast (9.426 ms) : 9272, 9581
. : milestone, 9426,
iast_FULL (13.758 ms) : 13485, 14031
. : milestone, 13758,
iast_GLOBAL (10.395 ms) : 10213, 10577
. : milestone, 10395,
profiling (8.689 ms) : 8548, 8830
. : milestone, 8689,
tracing (7.628 ms) : 7523, 7733
. : milestone, 7628,
section candidate
no_agent (4.423 ms) : 4373, 4474
. : milestone, 4423,
iast (9.169 ms) : 9015, 9323
. : milestone, 9169,
iast_FULL (13.816 ms) : 13547, 14086
. : milestone, 13816,
iast_GLOBAL (10.211 ms) : 10032, 10390
. : milestone, 10211,
profiling (8.607 ms) : 8472, 8741
. : milestone, 8607,
tracing (7.555 ms) : 7441, 7669
. : milestone, 7555,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~44175d28d0, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section baseline
no_agent (36.912 ms) : 36606, 37219
. : milestone, 36912,
appsec (47.728 ms) : 47295, 48161
. : milestone, 47728,
code_origins (43.889 ms) : 43531, 44246
. : milestone, 43889,
iast (43.036 ms) : 42658, 43413
. : milestone, 43036,
profiling (46.206 ms) : 45807, 46606
. : milestone, 46206,
tracing (42.669 ms) : 42318, 43021
. : milestone, 42669,
section candidate
no_agent (37.595 ms) : 37291, 37899
. : milestone, 37595,
appsec (46.821 ms) : 46413, 47229
. : milestone, 46821,
code_origins (44.017 ms) : 43610, 44424
. : milestone, 44017,
iast (43.352 ms) : 42984, 43721
. : milestone, 43352,
profiling (48.197 ms) : 47748, 48646
. : milestone, 48197,
tracing (44.51 ms) : 44118, 44902
. : milestone, 44510,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~44175d28d0, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section baseline
no_agent (15.584 s) : 15584000, 15584000
. : milestone, 15584000,
appsec (14.771 s) : 14771000, 14771000
. : milestone, 14771000,
iast (18.577 s) : 18577000, 18577000
. : milestone, 18577000,
iast_GLOBAL (18.006 s) : 18006000, 18006000
. : milestone, 18006000,
profiling (14.941 s) : 14941000, 14941000
. : milestone, 14941000,
tracing (14.699 s) : 14699000, 14699000
. : milestone, 14699000,
section candidate
no_agent (15.221 s) : 15221000, 15221000
. : milestone, 15221000,
appsec (14.821 s) : 14821000, 14821000
. : milestone, 14821000,
iast (18.08 s) : 18080000, 18080000
. : milestone, 18080000,
iast_GLOBAL (18.131 s) : 18131000, 18131000
. : milestone, 18131000,
profiling (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
tracing (15.058 s) : 15058000, 15058000
. : milestone, 15058000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~44175d28d0, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.417 ms) : 2367, 2467
. : milestone, 2417,
iast (2.192 ms) : 2130, 2255
. : milestone, 2192,
iast_GLOBAL (2.244 ms) : 2181, 2306
. : milestone, 2244,
profiling (2.458 ms) : 2290, 2626
. : milestone, 2458,
tracing (2.013 ms) : 1964, 2062
. : milestone, 2013,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.426 ms) : 2376, 2476
. : milestone, 2426,
iast (2.196 ms) : 2134, 2258
. : milestone, 2196,
iast_GLOBAL (2.253 ms) : 2190, 2315
. : milestone, 2253,
profiling (2.053 ms) : 2003, 2104
. : milestone, 2053,
tracing (2.02 ms) : 1972, 2068
. : milestone, 2020,
|
bric3
approved these changes
Jul 14, 2025
mhlidd
pushed a commit
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Refactored build scripts to use Spock version from catalog.
Motivation
It is better to have versions to be in single place. This will simplify migration to next version.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]