Skip to content

Remove GHCR prune workflow #8985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PerfectSlayer merged 1 commit into from
Jul 1, 2025
Merged

Remove GHCR prune workflow #8985

PerfectSlayer merged 1 commit into from
Jul 1, 2025

Conversation

@PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Jun 13, 2025 •
edited
Loading

What Does This Do

  • delete the workflow for pruning GHCR images
  • update the GitHub workflows README

Motivation

Follow up PR of #8965

Use the topic to text codex. End up being slower than doing it myself 🤷

https://chatgpt.com/codex/tasks/task_b_684c7e72672c8322b09418ae3bbba043

@PerfectSlayer PerfectSlayer requested a review from a team as a code owner June 13, 2025 19:43
@PerfectSlayer PerfectSlayer requested review from dougqh and removed request for a team June 13, 2025 19:43
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 13, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jun 13, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master codex/remove-ghcr-pruning-workflow
git_commit_date 1751046924 1751275945
git_commit_sha 46d0949 40e5ac7
release_version 1.51.0-SNAPSHOT~46d09492c9 1.51.0-SNAPSHOT~40e5ac7881
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1751277712 1751277712
ci_job_id 1004445222 1004445222
ci_pipeline_id 69120506 69120506
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zdpr8-wv-project-304-concurrent-0-4d0edk0x 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zdpr8-wv-project-304-concurrent-0-4d0edk0x 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~40e5ac7881, baseline=1.51.0-SNAPSHOT~46d09492c9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (994.751 ms) : 0, 994751
Total [baseline] (10.617 s) : 0, 10616718
Agent [candidate] (1.008 s) : 0, 1008277
Total [candidate] (10.727 s) : 0, 10726923
section appsec
Agent [baseline] (1.174 s) : 0, 1173822
Total [baseline] (10.76 s) : 0, 10759714
Agent [candidate] (1.175 s) : 0, 1174677
Total [candidate] (10.745 s) : 0, 10745237
section iast
Agent [baseline] (1.132 s) : 0, 1132401
Total [baseline] (10.883 s) : 0, 10882837
Agent [candidate] (1.132 s) : 0, 1132071
Total [candidate] (10.875 s) : 0, 10875378
section profiling
Agent [baseline] (1.251 s) : 0, 1251126
Total [baseline] (11.007 s) : 0, 11007490
Agent [candidate] (1.252 s) : 0, 1251595
Total [candidate] (10.987 s) : 0, 10986589
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 994.751 ms -
Agent appsec 1.174 s 179.071 ms (18.0%)
Agent iast 1.132 s 137.65 ms (13.8%)
Agent profiling 1.251 s 256.374 ms (25.8%)
Total tracing 10.617 s -
Total appsec 10.76 s 142.996 ms (1.3%)
Total iast 10.883 s 266.119 ms (2.5%)
Total profiling 11.007 s 390.772 ms (3.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.008 s -
Agent appsec 1.175 s 166.399 ms (16.5%)
Agent iast 1.132 s 123.794 ms (12.3%)
Agent profiling 1.252 s 243.317 ms (24.1%)
Total tracing 10.727 s -
Total appsec 10.745 s 18.314 ms (0.2%)
Total iast 10.875 s 148.456 ms (1.4%)
Total profiling 10.987 s 259.666 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~40e5ac7881, baseline=1.51.0-SNAPSHOT~46d09492c9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.863 ms) : 0, 686863
BytebuddyAgent [candidate] (697.2 ms) : 0, 697200
GlobalTracer [baseline] (242.037 ms) : 0, 242037
GlobalTracer [candidate] (244.159 ms) : 0, 244159
AppSec [baseline] (30.175 ms) : 0, 30175
AppSec [candidate] (30.76 ms) : 0, 30760
Debugger [baseline] (6.045 ms) : 0, 6045
Debugger [candidate] (6.099 ms) : 0, 6099
Remote Config [baseline] (679.274 µs) : 0, 679
Remote Config [candidate] (676.299 µs) : 0, 676
Telemetry [baseline] (8.223 ms) : 0, 8223
Telemetry [candidate] (8.287 ms) : 0, 8287
section appsec
BytebuddyAgent [baseline] (709.504 ms) : 0, 709504
BytebuddyAgent [candidate] (710.812 ms) : 0, 710812
GlobalTracer [baseline] (235.691 ms) : 0, 235691
GlobalTracer [candidate] (236.059 ms) : 0, 236059
IAST [baseline] (22.087 ms) : 0, 22087
IAST [candidate] (22.132 ms) : 0, 22132
AppSec [baseline] (171.22 ms) : 0, 171220
AppSec [candidate] (170.329 ms) : 0, 170329
Debugger [baseline] (5.801 ms) : 0, 5801
Debugger [candidate] (5.797 ms) : 0, 5797
Remote Config [baseline] (611.762 µs) : 0, 612
Remote Config [candidate] (622.342 µs) : 0, 622
Telemetry [baseline] (8.145 ms) : 0, 8145
Telemetry [candidate] (8.108 ms) : 0, 8108
section iast
BytebuddyAgent [baseline] (807.577 ms) : 0, 807577
BytebuddyAgent [candidate] (808.422 ms) : 0, 808422
GlobalTracer [baseline] (233.809 ms) : 0, 233809
GlobalTracer [candidate] (233.056 ms) : 0, 233056
IAST [baseline] (28.837 ms) : 0, 28837
IAST [candidate] (30.401 ms) : 0, 30401
AppSec [baseline] (26.886 ms) : 0, 26886
AppSec [candidate] (25.102 ms) : 0, 25102
Debugger [baseline] (5.859 ms) : 0, 5859
Debugger [candidate] (5.823 ms) : 0, 5823
Remote Config [baseline] (581.401 µs) : 0, 581
Remote Config [candidate] (572.106 µs) : 0, 572
Telemetry [baseline] (8.057 ms) : 0, 8057
Telemetry [candidate] (7.907 ms) : 0, 7907
section profiling
BytebuddyAgent [baseline] (682.622 ms) : 0, 682622
BytebuddyAgent [candidate] (681.419 ms) : 0, 681419
GlobalTracer [baseline] (363.131 ms) : 0, 363131
GlobalTracer [candidate] (363.243 ms) : 0, 363243
AppSec [baseline] (31.054 ms) : 0, 31054
AppSec [candidate] (31.85 ms) : 0, 31850
Debugger [baseline] (12.053 ms) : 0, 12053
Debugger [candidate] (13.181 ms) : 0, 13181
Remote Config [baseline] (1.364 ms) : 0, 1364
Remote Config [candidate] (668.02 µs) : 0, 668
Telemetry [baseline] (8.769 ms) : 0, 8769
Telemetry [candidate] (8.094 ms) : 0, 8094
ProfilingAgent [baseline] (103.287 ms) : 0, 103287
ProfilingAgent [candidate] (104.203 ms) : 0, 104203
Profiling [baseline] (103.313 ms) : 0, 103313
Profiling [candidate] (104.229 ms) : 0, 104229
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~40e5ac7881, baseline=1.51.0-SNAPSHOT~46d09492c9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.009 s) : 0, 1008627
Total [baseline] (8.583 s) : 0, 8583305
Agent [candidate] (1.003 s) : 0, 1002534
Total [candidate] (8.578 s) : 0, 8577838
section iast
Agent [baseline] (1.133 s) : 0, 1133416
Total [baseline] (9.265 s) : 0, 9265096
Agent [candidate] (1.132 s) : 0, 1132381
Total [candidate] (9.29 s) : 0, 9289915
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.009 s -
Agent iast 1.133 s 124.789 ms (12.4%)
Total tracing 8.583 s -
Total iast 9.265 s 681.791 ms (7.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.003 s -
Agent iast 1.132 s 129.847 ms (13.0%)
Total tracing 8.578 s -
Total iast 9.29 s 712.077 ms (8.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~40e5ac7881, baseline=1.51.0-SNAPSHOT~46d09492c9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.451 ms) : 0, 697451
BytebuddyAgent [candidate] (692.002 ms) : 0, 692002
GlobalTracer [baseline] (244.599 ms) : 0, 244599
GlobalTracer [candidate] (244.029 ms) : 0, 244029
AppSec [baseline] (30.481 ms) : 0, 30481
AppSec [candidate] (30.544 ms) : 0, 30544
Debugger [baseline] (6.087 ms) : 0, 6087
Debugger [candidate] (6.114 ms) : 0, 6114
Remote Config [baseline] (703.159 µs) : 0, 703
Remote Config [candidate] (672.314 µs) : 0, 672
Telemetry [baseline] (8.289 ms) : 0, 8289
Telemetry [candidate] (8.31 ms) : 0, 8310
section iast
BytebuddyAgent [baseline] (809.983 ms) : 0, 809983
BytebuddyAgent [candidate] (808.731 ms) : 0, 808731
GlobalTracer [baseline] (232.874 ms) : 0, 232874
GlobalTracer [candidate] (233.021 ms) : 0, 233021
AppSec [baseline] (27.518 ms) : 0, 27518
AppSec [candidate] (28.297 ms) : 0, 28297
Debugger [baseline] (5.849 ms) : 0, 5849
Debugger [candidate] (5.825 ms) : 0, 5825
Remote Config [baseline] (581.274 µs) : 0, 581
Remote Config [candidate] (577.555 µs) : 0, 578
Telemetry [baseline] (7.983 ms) : 0, 7983
Telemetry [candidate] (8.032 ms) : 0, 8032
IAST [baseline] (27.761 ms) : 0, 27761
IAST [candidate] (27.11 ms) : 0, 27110
Loading

Load

Dacapo

@PerfectSlayer PerfectSlayer added tag: ai generated Largely based on code generated by an AI or LLM and removed codex labels Jun 13, 2025
@PerfectSlayer PerfectSlayer force-pushed the codex/remove-ghcr-pruning-workflow branch 2 times, most recently from 9289758 to b130ffe Compare June 26, 2025 14:12
@PerfectSlayer PerfectSlayer enabled auto-merge (squash) June 26, 2025 14:17
@PerfectSlayer PerfectSlayer force-pushed the codex/remove-ghcr-pruning-workflow branch from b130ffe to 40e5ac7 Compare June 30, 2025 09:32
@PerfectSlayer PerfectSlayer merged commit 848b075 into master Jul 1, 2025
508 checks passed
@PerfectSlayer PerfectSlayer deleted the codex/remove-ghcr-pruning-workflow branch July 1, 2025 03:41
@github-actions github-actions bot added this to the 1.51.0 milestone Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes

@bric3 bric3 bric3 approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-lang-platform-java

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.51.0

Development

Successfully merging this pull request may close these issues.

5 participants

@PerfectSlayer @smola @bric3 @bm1549