-
Notifications
You must be signed in to change notification settings - Fork 318
LLM Obs SDK use context API for parent children span linkage #8711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+64
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~8c083043c5, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.883 ms) : 0, 996883
Total [baseline] (8.569 s) : 0, 8568504
Agent [candidate] (1.001 s) : 0, 1001097
Total [candidate] (8.575 s) : 0, 8575239
section iast
Agent [baseline] (1.138 s) : 0, 1138103
Total [baseline] (9.264 s) : 0, 9264276
Agent [candidate] (1.136 s) : 0, 1136074
Total [candidate] (9.287 s) : 0, 9287121
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~8c083043c5, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.555 ms) : 0, 688555
BytebuddyAgent [candidate] (691.485 ms) : 0, 691485
GlobalTracer [baseline] (242.175 ms) : 0, 242175
GlobalTracer [candidate] (243.244 ms) : 0, 243244
AppSec [baseline] (30.268 ms) : 0, 30268
AppSec [candidate] (30.475 ms) : 0, 30475
Debugger [baseline] (6.136 ms) : 0, 6136
Debugger [candidate] (6.083 ms) : 0, 6083
Remote Config [baseline] (694.866 µs) : 0, 695
Remote Config [candidate] (679.19 µs) : 0, 679
Telemetry [baseline] (8.241 ms) : 0, 8241
Telemetry [candidate] (8.261 ms) : 0, 8261
section iast
BytebuddyAgent [baseline] (813.041 ms) : 0, 813041
BytebuddyAgent [candidate] (810.633 ms) : 0, 810633
GlobalTracer [baseline] (232.211 ms) : 0, 232211
GlobalTracer [candidate] (232.518 ms) : 0, 232518
AppSec [baseline] (31.384 ms) : 0, 31384
AppSec [candidate] (30.531 ms) : 0, 30531
Debugger [baseline] (5.845 ms) : 0, 5845
Debugger [candidate] (5.829 ms) : 0, 5829
Remote Config [baseline] (571.942 µs) : 0, 572
Remote Config [candidate] (575.892 µs) : 0, 576
Telemetry [baseline] (7.977 ms) : 0, 7977
Telemetry [candidate] (8.015 ms) : 0, 8015
IAST [baseline] (26.224 ms) : 0, 26224
IAST [candidate] (27.121 ms) : 0, 27121
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~8c083043c5, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.002 s) : 0, 1001943
Total [baseline] (10.775 s) : 0, 10775197
Agent [candidate] (997.054 ms) : 0, 997054
Total [candidate] (10.695 s) : 0, 10695473
section appsec
Agent [baseline] (1.201 s) : 0, 1200517
Total [baseline] (10.856 s) : 0, 10856386
Agent [candidate] (1.177 s) : 0, 1177127
Total [candidate] (10.742 s) : 0, 10742345
section iast
Agent [baseline] (1.134 s) : 0, 1134350
Total [baseline] (10.89 s) : 0, 10890412
Agent [candidate] (1.132 s) : 0, 1132019
Total [candidate] (10.861 s) : 0, 10861225
section profiling
Agent [baseline] (1.256 s) : 0, 1256236
Total [baseline] (10.954 s) : 0, 10954008
Agent [candidate] (1.246 s) : 0, 1246184
Total [candidate] (10.94 s) : 0, 10940263
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~8c083043c5, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.209 ms) : 0, 691209
BytebuddyAgent [candidate] (688.524 ms) : 0, 688524
GlobalTracer [baseline] (243.383 ms) : 0, 243383
GlobalTracer [candidate] (242.312 ms) : 0, 242312
AppSec [baseline] (30.534 ms) : 0, 30534
AppSec [candidate] (30.368 ms) : 0, 30368
Debugger [baseline] (6.127 ms) : 0, 6127
Debugger [candidate] (6.058 ms) : 0, 6058
Remote Config [baseline] (692.311 µs) : 0, 692
Remote Config [candidate] (680.098 µs) : 0, 680
Telemetry [baseline] (9.046 ms) : 0, 9046
Telemetry [candidate] (8.222 ms) : 0, 8222
section appsec
BytebuddyAgent [baseline] (727.685 ms) : 0, 727685
BytebuddyAgent [candidate] (711.406 ms) : 0, 711406
GlobalTracer [baseline] (239.3 ms) : 0, 239300
GlobalTracer [candidate] (235.543 ms) : 0, 235543
AppSec [baseline] (173.664 ms) : 0, 173664
AppSec [candidate] (171.452 ms) : 0, 171452
Debugger [baseline] (5.861 ms) : 0, 5861
Debugger [candidate] (5.822 ms) : 0, 5822
Remote Config [baseline] (613.585 µs) : 0, 614
Remote Config [candidate] (612.353 µs) : 0, 612
Telemetry [baseline] (8.163 ms) : 0, 8163
Telemetry [candidate] (8.181 ms) : 0, 8181
IAST [baseline] (23.978 ms) : 0, 23978
IAST [candidate] (23.21 ms) : 0, 23210
section iast
BytebuddyAgent [baseline] (808.491 ms) : 0, 808491
BytebuddyAgent [candidate] (807.219 ms) : 0, 807219
GlobalTracer [baseline] (232.934 ms) : 0, 232934
GlobalTracer [candidate] (232.013 ms) : 0, 232013
AppSec [baseline] (29.777 ms) : 0, 29777
AppSec [candidate] (30.463 ms) : 0, 30463
Debugger [baseline] (5.873 ms) : 0, 5873
Debugger [candidate] (5.872 ms) : 0, 5872
Remote Config [baseline] (578.944 µs) : 0, 579
Remote Config [candidate] (586.537 µs) : 0, 587
Telemetry [baseline] (8.061 ms) : 0, 8061
Telemetry [candidate] (7.918 ms) : 0, 7918
IAST [baseline] (27.819 ms) : 0, 27819
IAST [candidate] (27.105 ms) : 0, 27105
section profiling
BytebuddyAgent [baseline] (685.973 ms) : 0, 685973
BytebuddyAgent [candidate] (678.096 ms) : 0, 678096
GlobalTracer [baseline] (363.618 ms) : 0, 363618
GlobalTracer [candidate] (362.133 ms) : 0, 362133
AppSec [baseline] (31.711 ms) : 0, 31711
AppSec [candidate] (33.12 ms) : 0, 33120
Debugger [baseline] (11.32 ms) : 0, 11320
Debugger [candidate] (9.92 ms) : 0, 9920
Remote Config [baseline] (661.694 µs) : 0, 662
Remote Config [candidate] (667.507 µs) : 0, 668
Telemetry [baseline] (9.532 ms) : 0, 9532
Telemetry [candidate] (8.823 ms) : 0, 8823
ProfilingAgent [baseline] (104.364 ms) : 0, 104364
ProfilingAgent [candidate] (104.789 ms) : 0, 104789
Profiling [baseline] (104.388 ms) : 0, 104388
Profiling [candidate] (104.813 ms) : 0, 104813
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 12 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~8c083043c5, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section baseline
no_agent (36.411 ms) : 36117, 36705
. : milestone, 36411,
appsec (46.131 ms) : 45729, 46532
. : milestone, 46131,
code_origins (44.659 ms) : 44274, 45043
. : milestone, 44659,
iast (43.923 ms) : 43528, 44318
. : milestone, 43923,
profiling (49.724 ms) : 49219, 50230
. : milestone, 49724,
tracing (42.552 ms) : 42202, 42901
. : milestone, 42552,
section candidate
no_agent (37.319 ms) : 37014, 37623
. : milestone, 37319,
appsec (46.548 ms) : 46137, 46959
. : milestone, 46548,
code_origins (44.976 ms) : 44595, 45357
. : milestone, 44976,
iast (44.491 ms) : 44104, 44878
. : milestone, 44491,
profiling (49.166 ms) : 48714, 49618
. : milestone, 49166,
tracing (43.014 ms) : 42661, 43367
. : milestone, 43014,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~8c083043c5, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section baseline
no_agent (4.47 ms) : 4418, 4522
. : milestone, 4470,
iast (9.278 ms) : 9128, 9428
. : milestone, 9278,
iast_FULL (14.133 ms) : 13859, 14407
. : milestone, 14133,
iast_GLOBAL (10.046 ms) : 9872, 10220
. : milestone, 10046,
profiling (8.784 ms) : 8650, 8918
. : milestone, 8784,
tracing (7.426 ms) : 7307, 7545
. : milestone, 7426,
section candidate
no_agent (4.36 ms) : 4307, 4412
. : milestone, 4360,
iast (9.337 ms) : 9185, 9490
. : milestone, 9337,
iast_FULL (13.852 ms) : 13578, 14126
. : milestone, 13852,
iast_GLOBAL (10.371 ms) : 10190, 10551
. : milestone, 10371,
profiling (9.028 ms) : 8886, 9171
. : milestone, 9028,
tracing (7.195 ms) : 7092, 7298
. : milestone, 7195,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~8c083043c5, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section baseline
no_agent (15.526 s) : 15526000, 15526000
. : milestone, 15526000,
appsec (15.023 s) : 15023000, 15023000
. : milestone, 15023000,
iast (18.456 s) : 18456000, 18456000
. : milestone, 18456000,
iast_GLOBAL (17.698 s) : 17698000, 17698000
. : milestone, 17698000,
profiling (15.738 s) : 15738000, 15738000
. : milestone, 15738000,
tracing (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
section candidate
no_agent (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
appsec (14.884 s) : 14884000, 14884000
. : milestone, 14884000,
iast (18.477 s) : 18477000, 18477000
. : milestone, 18477000,
iast_GLOBAL (17.895 s) : 17895000, 17895000
. : milestone, 17895000,
profiling (15.127 s) : 15127000, 15127000
. : milestone, 15127000,
tracing (14.825 s) : 14825000, 14825000
. : milestone, 14825000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~8c083043c5, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.394 ms) : 2345, 2444
. : milestone, 2394,
iast (2.179 ms) : 2117, 2241
. : milestone, 2179,
iast_GLOBAL (2.231 ms) : 2168, 2293
. : milestone, 2231,
profiling (2.033 ms) : 1983, 2083
. : milestone, 2033,
tracing (1.995 ms) : 1947, 2043
. : milestone, 1995,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.4 ms) : 2351, 2450
. : milestone, 2400,
iast (2.193 ms) : 2131, 2256
. : milestone, 2193,
iast_GLOBAL (2.23 ms) : 2167, 2293
. : milestone, 2230,
profiling (2.039 ms) : 1989, 2089
. : milestone, 2039,
tracing (1.996 ms) : 1948, 2044
. : milestone, 1996,
|
06e220a to
7c16dd2
Compare
gary-huang
added a commit
that referenced
this pull request
Jul 9, 2025
* add APIs for llm obs * add llm message class to support llm spans * add llm message class to support llm spans * impl llmobs agent and llmobs apis * support llm messages with tool calls * handle default model name and provider * rm unneeded file * impl llmobs agent and llmobs apis * impl llmobs agent * working writer * add support for llm message and tool calls * impl llmobs agent and llmobs apis * use new ctx api to track parent span * cleaned up whitespace * resolve merge conflicts * remaining merge conflicts * fix bad method call * fixed llmobs intake creation if llmobs not enabled * removed print statements * ran spotless * added tests for llmobsspanmapper * fixed coverage for tags --------- Co-authored-by: Nayeem Kamal <[email protected]> Co-authored-by: Nayeem Kamal <[email protected]>
nayeem-kamal
added a commit
that referenced
this pull request
Jul 9, 2025
* add APIs for llm obs sdk (#8135) * add APIs for llm obs * add llm message class to support llm spans * follow java convention of naming Id instead of ID * add codeowners * implement LLM Obs SDK spans APIs (#8390) * add APIs for llm obs * add llm message class to support llm spans * add llm message class to support llm spans * impl llmobs agent and llmobs apis * support llm messages with tool calls * handle default model name and provider * rm unneeded file * spotless * add APIs for llm obs sdk (#8135) * add APIs for llm obs * add llm message class to support llm spans * follow java convention of naming Id instead of ID * add codeowners * rename ID to Id according to java naming conventions * Undo change to integrations-core submodule * fix build gradle * rm empty line * fix test * LLM Obs SDK Mapper (#8372) * add APIs for llm obs * add llm message class to support llm spans * add llm message class to support llm spans * impl llmobs agent and llmobs apis * support llm messages with tool calls * handle default model name and provider * rm unneeded file * impl llmobs agent and llmobs apis * impl llmobs agent * working writer * add support for llm message and tool calls * cleaned up whitespace * resolve merge conflicts * remaining merge conflicts * fix bad method call * fixed llmobs intake creation if llmobs not enabled * removed print statements * added tests for llmobsspanmapper * fixed coverage for tags --------- Co-authored-by: Nayeem Kamal <[email protected]> * updated to master submodule * LLM Obs SDK use context API for parent children span linkage (#8711) * add APIs for llm obs * add llm message class to support llm spans * add llm message class to support llm spans * impl llmobs agent and llmobs apis * support llm messages with tool calls * handle default model name and provider * rm unneeded file * impl llmobs agent and llmobs apis * impl llmobs agent * working writer * add support for llm message and tool calls * impl llmobs agent and llmobs apis * use new ctx api to track parent span * cleaned up whitespace * resolve merge conflicts * remaining merge conflicts * fix bad method call * fixed llmobs intake creation if llmobs not enabled * removed print statements * ran spotless * added tests for llmobsspanmapper * fixed coverage for tags --------- Co-authored-by: Nayeem Kamal <[email protected]> Co-authored-by: Nayeem Kamal <[email protected]> * LLM Obs SDK evaluation metrics submission (#8688) * add APIs for llm obs * add llm message class to support llm spans * add llm message class to support llm spans * impl llmobs agent and llmobs apis * support llm messages with tool calls * handle default model name and provider * rm unneeded file * impl llmobs agent and llmobs apis * impl llmobs agent * working writer * add support for llm message and tool calls * impl llmobs agent and llmobs apis * use new ctx api to track parent span * add api for evals * working impl supporting both agentless and agent * handle null tags and default to default ml app if null or empty string provided in the override * cleaned up whitespace * resolve merge conflicts * remaining merge conflicts * fix bad method call * fixed llmobs intake creation if llmobs not enabled * removed print statements * ran spotless * ran spotless * added tests for llmobsspanmapper * fixed coverage for tags --------- Co-authored-by: Nayeem Kamal <[email protected]> Co-authored-by: Nayeem Kamal <[email protected]> * fix CODEOWNERS --------- Co-authored-by: Nayeem Kamal <[email protected]> Co-authored-by: Nayeem Kamal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]