Skip to content

Disable debugger by default if CI Visibility is enabled #8506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Disable debugger by default if CI Visibility is enabled #8506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e848f5a
Disable debugger by default if CI Visibility is enabled
nikita-tkachenko-datadog Mar 4, 2025
d4436e5
Merge branch 'master' into nikita-tkachenko/ci-vis-disable-debugger-b…
nikita-tkachenko-datadog Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Agent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,6 +1121,14 @@ && isExplicitlyDisabled(TraceInstrumentationConfig.CODE_ORIGIN_FOR_SPANS_ENABLED
&& isExplicitlyDisabled(DebuggerConfig.DISTRIBUTED_DEBUGGER_ENABLED)) {
return;
}
if (ciVisibilityEnabled
&& !dynamicInstrumentationEnabled
&& !exceptionReplayEnabled
&& !codeOriginEnabled
&& !distributedDebuggerEnabled) {
// if CI Visibility is enabled, debugger should be disabled by default
return;
}
if (!remoteConfigEnabled) {
log.warn("Cannot enable Dynamic Instrumentation because Remote Configuration is not enabled");
return;
Expand Down