Add configurable Dependency service resolution period #8079

jandro996 · 2024-12-12T09:11:38Z

What Does This Do

Add new APPSEC_DEPENDENCY_RESOLUTION_PERIOD_MILLIS env variable to be able to configure the dependency service resolution period

Motivation

For testing environments the default 1 second period is excessive

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2024-12-12T09:11:54Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Remove the tag from the pull request title

If you need help, please check our contributing guidelines.

internal-api/src/main/java/datadog/trace/api/Config.java

pr-commenter · 2024-12-12T09:51:09Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/sca-jar-delay
git_commit_date	1734012159	1734016377
git_commit_sha	`4573a38`	`7b102dc`
release_version	1.44.0-SNAPSHOT~4573a38b9e	1.45.0-SNAPSHOT~7b102dc873

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1734018798	1734018798
ci_job_id	736809687	736809687
ci_pipeline_id	50964069	50964069
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~7b102dc873, baseline=1.44.0-SNAPSHOT~4573a38b9e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1092809
Total [baseline] (8.649 s) : 0, 8649487
Agent [candidate] (1.095 s) : 0, 1095027
Total [candidate] (8.707 s) : 0, 8707141
section iast
Agent [baseline] (1.227 s) : 0, 1227193
Total [baseline] (9.225 s) : 0, 9224974
Agent [candidate] (1.23 s) : 0, 1230248
Total [candidate] (9.211 s) : 0, 9210819
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.231 s) : 0, 1230533
Total [baseline] (9.208 s) : 0, 9208296
Agent [candidate] (1.239 s) : 0, 1239371
Total [candidate] (9.226 s) : 0, 9226129
section iast_TELEMETRY_OFF
Agent [baseline] (1.23 s) : 0, 1230009
Total [baseline] (9.231 s) : 0, 9231435
Agent [candidate] (1.217 s) : 0, 1217434
Total [candidate] (9.168 s) : 0, 9168463

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.093 s	-
Agent	iast	1.227 s	134.384 ms (12.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.231 s	137.724 ms (12.6%)
Agent	iast_TELEMETRY_OFF	1.23 s	137.2 ms (12.6%)
Total	tracing	8.649 s	-
Total	iast	9.225 s	575.487 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.208 s	558.81 ms (6.5%)
Total	iast_TELEMETRY_OFF	9.231 s	581.949 ms (6.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.095 s	-
Agent	iast	1.23 s	135.221 ms (12.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.239 s	144.344 ms (13.2%)
Agent	iast_TELEMETRY_OFF	1.217 s	122.407 ms (11.2%)
Total	tracing	8.707 s	-
Total	iast	9.211 s	503.677 ms (5.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.226 s	518.988 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.168 s	461.322 ms (5.3%)

gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~7b102dc873, baseline=1.44.0-SNAPSHOT~4573a38b9e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.157 ms) : 0, 697157
BytebuddyAgent [candidate] (696.851 ms) : 0, 696851
GlobalTracer [baseline] (317.563 ms) : 0, 317563
GlobalTracer [candidate] (317.027 ms) : 0, 317027
AppSec [baseline] (54.33 ms) : 0, 54330
AppSec [candidate] (54.506 ms) : 0, 54506
Remote Config [baseline] (746.824 µs) : 0, 747
Remote Config [candidate] (687.341 µs) : 0, 687
Telemetry [baseline] (9.274 ms) : 0, 9274
Telemetry [candidate] (12.2 ms) : 0, 12200
section iast
BytebuddyAgent [baseline] (819.161 ms) : 0, 819161
BytebuddyAgent [candidate] (823.216 ms) : 0, 823216
GlobalTracer [baseline] (306.981 ms) : 0, 306981
GlobalTracer [candidate] (307.061 ms) : 0, 307061
AppSec [baseline] (57.986 ms) : 0, 57986
AppSec [candidate] (57.209 ms) : 0, 57209
IAST [baseline] (21.076 ms) : 0, 21076
IAST [candidate] (20.814 ms) : 0, 20814
Remote Config [baseline] (613.62 µs) : 0, 614
Remote Config [candidate] (634.125 µs) : 0, 634
Telemetry [baseline] (7.443 ms) : 0, 7443
Telemetry [candidate] (7.41 ms) : 0, 7410
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (821.076 ms) : 0, 821076
BytebuddyAgent [candidate] (827.001 ms) : 0, 827001
GlobalTracer [baseline] (307.837 ms) : 0, 307837
GlobalTracer [candidate] (309.885 ms) : 0, 309885
AppSec [baseline] (58.471 ms) : 0, 58471
AppSec [candidate] (57.813 ms) : 0, 57813
IAST [baseline] (21.272 ms) : 0, 21272
IAST [candidate] (22.397 ms) : 0, 22397
Remote Config [baseline] (617.228 µs) : 0, 617
Remote Config [candidate] (632.653 µs) : 0, 633
Telemetry [baseline] (7.447 ms) : 0, 7447
Telemetry [candidate] (7.535 ms) : 0, 7535
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (820.788 ms) : 0, 820788
BytebuddyAgent [candidate] (811.137 ms) : 0, 811137
GlobalTracer [baseline] (307.77 ms) : 0, 307770
GlobalTracer [candidate] (305.912 ms) : 0, 305912
AppSec [baseline] (57.987 ms) : 0, 57987
AppSec [candidate] (57.2 ms) : 0, 57200
IAST [baseline] (21.571 ms) : 0, 21571
IAST [candidate] (21.448 ms) : 0, 21448
Remote Config [baseline] (634.82 µs) : 0, 635
Remote Config [candidate] (622.909 µs) : 0, 623
Telemetry [baseline] (7.382 ms) : 0, 7382
Telemetry [candidate] (7.337 ms) : 0, 7337

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~7b102dc873, baseline=1.44.0-SNAPSHOT~4573a38b9e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1101396
Total [baseline] (10.431 s) : 0, 10431074
Agent [candidate] (1.09 s) : 0, 1090095
Total [candidate] (10.377 s) : 0, 10376597
section appsec
Agent [baseline] (1.226 s) : 0, 1225941
Total [baseline] (10.74 s) : 0, 10739758
Agent [candidate] (1.226 s) : 0, 1226165
Total [candidate] (10.689 s) : 0, 10689452
section iast
Agent [baseline] (1.218 s) : 0, 1217551
Total [baseline] (10.921 s) : 0, 10920810
Agent [candidate] (1.222 s) : 0, 1221759
Total [candidate] (10.959 s) : 0, 10958658
section profiling
Agent [baseline] (1.315 s) : 0, 1314561
Total [baseline] (10.758 s) : 0, 10758207
Agent [candidate] (1.316 s) : 0, 1316128
Total [candidate] (10.776 s) : 0, 10775542

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.101 s	-
Agent	appsec	1.226 s	124.545 ms (11.3%)
Agent	iast	1.218 s	116.154 ms (10.5%)
Agent	profiling	1.315 s	213.165 ms (19.4%)
Total	tracing	10.431 s	-
Total	appsec	10.74 s	308.684 ms (3.0%)
Total	iast	10.921 s	489.736 ms (4.7%)
Total	profiling	10.758 s	327.133 ms (3.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.09 s	-
Agent	appsec	1.226 s	136.07 ms (12.5%)
Agent	iast	1.222 s	131.663 ms (12.1%)
Agent	profiling	1.316 s	226.032 ms (20.7%)
Total	tracing	10.377 s	-
Total	appsec	10.689 s	312.855 ms (3.0%)
Total	iast	10.959 s	582.061 ms (5.6%)
Total	profiling	10.776 s	398.944 ms (3.8%)

gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~7b102dc873, baseline=1.44.0-SNAPSHOT~4573a38b9e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (702.143 ms) : 0, 702143
BytebuddyAgent [candidate] (694.272 ms) : 0, 694272
GlobalTracer [baseline] (320.254 ms) : 0, 320254
GlobalTracer [candidate] (317.083 ms) : 0, 317083
AppSec [baseline] (54.58 ms) : 0, 54580
AppSec [candidate] (54.511 ms) : 0, 54511
Remote Config [baseline] (678.473 µs) : 0, 678
Remote Config [candidate] (684.041 µs) : 0, 684
Telemetry [baseline] (9.955 ms) : 0, 9955
Telemetry [candidate] (9.832 ms) : 0, 9832
section appsec
BytebuddyAgent [baseline] (712.942 ms) : 0, 712942
BytebuddyAgent [candidate] (713.188 ms) : 0, 713188
GlobalTracer [baseline] (314.029 ms) : 0, 314029
GlobalTracer [candidate] (313.818 ms) : 0, 313818
AppSec [baseline] (167.353 ms) : 0, 167353
AppSec [candidate] (166.704 ms) : 0, 166704
IAST [baseline] (19.018 ms) : 0, 19018
IAST [candidate] (19.774 ms) : 0, 19774
Remote Config [baseline] (638.57 µs) : 0, 639
Remote Config [candidate] (639.298 µs) : 0, 639
Telemetry [baseline] (7.768 ms) : 0, 7768
Telemetry [candidate] (8.186 ms) : 0, 8186
section iast
BytebuddyAgent [baseline] (811.694 ms) : 0, 811694
BytebuddyAgent [candidate] (814.292 ms) : 0, 814292
GlobalTracer [baseline] (305.727 ms) : 0, 305727
GlobalTracer [candidate] (306.732 ms) : 0, 306732
AppSec [baseline] (56.653 ms) : 0, 56653
AppSec [candidate] (57.834 ms) : 0, 57834
IAST [baseline] (21.755 ms) : 0, 21755
IAST [candidate] (21.106 ms) : 0, 21106
Remote Config [baseline] (619.718 µs) : 0, 620
Remote Config [candidate] (616.245 µs) : 0, 616
Telemetry [baseline] (7.436 ms) : 0, 7436
Telemetry [candidate] (7.442 ms) : 0, 7442
section profiling
BytebuddyAgent [baseline] (688.682 ms) : 0, 688682
BytebuddyAgent [candidate] (689.195 ms) : 0, 689195
GlobalTracer [baseline] (432.529 ms) : 0, 432529
GlobalTracer [candidate] (431.269 ms) : 0, 431269
AppSec [baseline] (53.167 ms) : 0, 53167
AppSec [candidate] (53.68 ms) : 0, 53680
Remote Config [baseline] (670.753 µs) : 0, 671
Remote Config [candidate] (665.761 µs) : 0, 666
Telemetry [baseline] (7.618 ms) : 0, 7618
Telemetry [candidate] (7.643 ms) : 0, 7643
ProfilingAgent [baseline] (92.797 ms) : 0, 92797
ProfilingAgent [candidate] (94.462 ms) : 0, 94462
Profiling [baseline] (92.821 ms) : 0, 92821
Profiling [candidate] (94.486 ms) : 0, 94486

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-12-12T15:25:37	2024-12-12T15:32:35
git_branch	master	alejandro.gonzalez/sca-jar-delay
git_commit_date	1734012159	1734016377
git_commit_sha	`4573a38`	`7b102dc`
release_version	1.44.0-SNAPSHOT~4573a38b9e	1.45.0-SNAPSHOT~7b102dc873
start_time	2024-12-12T15:25:24	2024-12-12T15:32:21

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1734017908	1734017908
ci_job_id	736809688	736809688
ci_pipeline_id	50964069	50964069
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~7b102dc873, baseline=1.44.0-SNAPSHOT~4573a38b9e
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.806 µs) : 355, 396
.   : milestone, 376,
iast (486.772 µs) : 466, 508
.   : milestone, 487,
iast_FULL (654.851 µs) : 633, 676
.   : milestone, 655,
iast_GLOBAL (522.822 µs) : 500, 545
.   : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (490.585 µs) : 469, 512
.   : milestone, 491,
iast_INACTIVE (454.71 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (479.978 µs) : 458, 502
.   : milestone, 480,
tracing (447.729 µs) : 426, 469
.   : milestone, 448,
section candidate
no_agent (374.046 µs) : 354, 394
.   : milestone, 374,
iast (492.332 µs) : 471, 514
.   : milestone, 492,
iast_FULL (651.989 µs) : 630, 673
.   : milestone, 652,
iast_GLOBAL (518.108 µs) : 496, 540
.   : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (491.832 µs) : 470, 513
.   : milestone, 492,
iast_INACTIVE (455.756 µs) : 434, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (479.866 µs) : 458, 501
.   : milestone, 480,
tracing (453.148 µs) : 432, 475
.   : milestone, 453,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	375.806 µs [355.48 µs, 396.132 µs]	-
iast	486.772 µs [465.549 µs, 507.994 µs]	110.965 µs (29.5%)
iast_FULL	654.851 µs [633.346 µs, 676.356 µs]	279.044 µs (74.3%)
iast_GLOBAL	522.822 µs [500.288 µs, 545.356 µs]	147.016 µs (39.1%)
iast_HARDCODED_SECRET_DISABLED	490.585 µs [468.858 µs, 512.312 µs]	114.779 µs (30.5%)
iast_INACTIVE	454.71 µs [433.615 µs, 475.804 µs]	78.903 µs (21.0%)
iast_TELEMETRY_OFF	479.978 µs [457.962 µs, 501.994 µs]	104.171 µs (27.7%)
tracing	447.729 µs [426.499 µs, 468.959 µs]	71.923 µs (19.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	374.046 µs [354.419 µs, 393.673 µs]	-
iast	492.332 µs [470.941 µs, 513.723 µs]	118.286 µs (31.6%)
iast_FULL	651.989 µs [630.491 µs, 673.486 µs]	277.943 µs (74.3%)
iast_GLOBAL	518.108 µs [496.167 µs, 540.05 µs]	144.062 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED	491.832 µs [470.387 µs, 513.277 µs]	117.786 µs (31.5%)
iast_INACTIVE	455.756 µs [434.122 µs, 477.391 µs]	81.71 µs (21.8%)
iast_TELEMETRY_OFF	479.866 µs [458.275 µs, 501.457 µs]	105.82 µs (28.3%)
tracing	453.148 µs [431.514 µs, 474.782 µs]	79.102 µs (21.1%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~7b102dc873, baseline=1.44.0-SNAPSHOT~4573a38b9e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.356 ms) : 1337, 1375
.   : milestone, 1356,
appsec (1.752 ms) : 1729, 1775
.   : milestone, 1752,
appsec_no_iast (1.751 ms) : 1727, 1775
.   : milestone, 1751,
iast (1.491 ms) : 1468, 1513
.   : milestone, 1491,
profiling (1.513 ms) : 1491, 1536
.   : milestone, 1513,
tracing (1.473 ms) : 1448, 1498
.   : milestone, 1473,
section candidate
no_agent (1.356 ms) : 1336, 1376
.   : milestone, 1356,
appsec (1.745 ms) : 1721, 1769
.   : milestone, 1745,
appsec_no_iast (1.747 ms) : 1723, 1771
.   : milestone, 1747,
iast (1.504 ms) : 1482, 1526
.   : milestone, 1504,
profiling (1.537 ms) : 1512, 1562
.   : milestone, 1537,
tracing (1.492 ms) : 1468, 1516
.   : milestone, 1492,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.337 ms, 1.375 ms]	-
appsec	1.752 ms [1.729 ms, 1.775 ms]	396.335 µs (29.2%)
appsec_no_iast	1.751 ms [1.727 ms, 1.775 ms]	394.671 µs (29.1%)
iast	1.491 ms [1.468 ms, 1.513 ms]	134.467 µs (9.9%)
profiling	1.513 ms [1.491 ms, 1.536 ms]	157.337 µs (11.6%)
tracing	1.473 ms [1.448 ms, 1.498 ms]	116.995 µs (8.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.336 ms, 1.376 ms]	-
appsec	1.745 ms [1.721 ms, 1.769 ms]	388.908 µs (28.7%)
appsec_no_iast	1.747 ms [1.723 ms, 1.771 ms]	390.898 µs (28.8%)
iast	1.504 ms [1.482 ms, 1.526 ms]	148.087 µs (10.9%)
profiling	1.537 ms [1.512 ms, 1.562 ms]	180.971 µs (13.3%)
tracing	1.492 ms [1.468 ms, 1.516 ms]	136.083 µs (10.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/sca-jar-delay
git_commit_date	1734012159	1734016377
git_commit_sha	`4573a38`	`7b102dc`
release_version	1.44.0-SNAPSHOT~4573a38b9e	1.45.0-SNAPSHOT~7b102dc873

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1734018318	1734018318
ci_job_id	736809689	736809689
ci_pipeline_id	50964069	50964069
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~7b102dc873, baseline=1.44.0-SNAPSHOT~4573a38b9e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1485
.   : milestone, 1473,
appsec (2.344 ms) : 2302, 2385
.   : milestone, 2344,
iast (2.08 ms) : 2027, 2133
.   : milestone, 2080,
iast_GLOBAL (2.124 ms) : 2070, 2177
.   : milestone, 2124,
profiling (1.949 ms) : 1906, 1991
.   : milestone, 1949,
tracing (1.927 ms) : 1887, 1968
.   : milestone, 1927,
section candidate
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.339 ms) : 2297, 2380
.   : milestone, 2339,
iast (2.087 ms) : 2034, 2139
.   : milestone, 2087,
iast_GLOBAL (2.115 ms) : 2062, 2168
.   : milestone, 2115,
profiling (1.945 ms) : 1903, 1988
.   : milestone, 1945,
tracing (1.925 ms) : 1884, 1965
.   : milestone, 1925,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.485 ms]	-
appsec	2.344 ms [2.302 ms, 2.385 ms]	870.689 µs (59.1%)
iast	2.08 ms [2.027 ms, 2.133 ms]	607.161 µs (41.2%)
iast_GLOBAL	2.124 ms [2.07 ms, 2.177 ms]	650.679 µs (44.2%)
profiling	1.949 ms [1.906 ms, 1.991 ms]	475.771 µs (32.3%)
tracing	1.927 ms [1.887 ms, 1.968 ms]	454.453 µs (30.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.455 ms, 1.478 ms]	-
appsec	2.339 ms [2.297 ms, 2.38 ms]	872.116 µs (59.5%)
iast	2.087 ms [2.034 ms, 2.139 ms]	620.011 µs (42.3%)
iast_GLOBAL	2.115 ms [2.062 ms, 2.168 ms]	648.626 µs (44.2%)
profiling	1.945 ms [1.903 ms, 1.988 ms]	478.792 µs (32.6%)
tracing	1.925 ms [1.884 ms, 1.965 ms]	457.976 µs (31.2%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~7b102dc873, baseline=1.44.0-SNAPSHOT~4573a38b9e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.208 s) : 15208000, 15208000
.   : milestone, 15208000,
appsec (14.858 s) : 14858000, 14858000
.   : milestone, 14858000,
iast (18.968 s) : 18968000, 18968000
.   : milestone, 18968000,
iast_GLOBAL (18.002 s) : 18002000, 18002000
.   : milestone, 18002000,
profiling (15.078 s) : 15078000, 15078000
.   : milestone, 15078000,
tracing (14.783 s) : 14783000, 14783000
.   : milestone, 14783000,
section candidate
no_agent (14.926 s) : 14926000, 14926000
.   : milestone, 14926000,
appsec (15.194 s) : 15194000, 15194000
.   : milestone, 15194000,
iast (18.81 s) : 18810000, 18810000
.   : milestone, 18810000,
iast_GLOBAL (18.044 s) : 18044000, 18044000
.   : milestone, 18044000,
profiling (15.616 s) : 15616000, 15616000
.   : milestone, 15616000,
tracing (15.129 s) : 15129000, 15129000
.   : milestone, 15129000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.208 s [15.208 s, 15.208 s]	-
appsec	14.858 s [14.858 s, 14.858 s]	-350.0 ms (-2.3%)
iast	18.968 s [18.968 s, 18.968 s]	3.76 s (24.7%)
iast_GLOBAL	18.002 s [18.002 s, 18.002 s]	2.794 s (18.4%)
profiling	15.078 s [15.078 s, 15.078 s]	-130.0 ms (-0.9%)
tracing	14.783 s [14.783 s, 14.783 s]	-425.0 ms (-2.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.926 s [14.926 s, 14.926 s]	-
appsec	15.194 s [15.194 s, 15.194 s]	268.0 ms (1.8%)
iast	18.81 s [18.81 s, 18.81 s]	3.884 s (26.0%)
iast_GLOBAL	18.044 s [18.044 s, 18.044 s]	3.118 s (20.9%)
profiling	15.616 s [15.616 s, 15.616 s]	690.0 ms (4.6%)
tracing	15.129 s [15.129 s, 15.129 s]	203.0 ms (1.4%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.50.0` -> `2.50.1` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.59.0` -> `2.59.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.45.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.45.0): 1.45.0 ##### Breaking changes > \[!WARNING]\ > Support for custom scope manager using OpenTelemetry tracer artifact (`dd-trace-ot`) is dropped. > Tracing with OpenTracing API and custom scope manager will continue to work on 1.44.x releases. ##### Components ##### Application Security Management (IAST) - ✨ Add propagation to URI#toURL method ([#8146](DataDog/dd-trace-java#8146) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Increase IAST propagation to StringBuilder setLength ([#8119](DataDog/dd-trace-java#8119) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuffer append ([#8082](DataDog/dd-trace-java#8082) - [@Mariovido](https://github.com/Mariovido)) - ✨ Handle IAST security controls custom validation and sanitization methods ([#7997](DataDog/dd-trace-java#7997) - [@jandro996](https://github.com/jandro996)) ##### Application Security Management (WAF) - ✨ Update user lifecycle tracking to V3 ([#8108](DataDog/dd-trace-java#8108) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Exploit prevention for Shell Injection / Command Injection ([#7615](DataDog/dd-trace-java#7615) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 💡 Support instrumentation of repackaged libraries ([#8153](DataDog/dd-trace-java#8153) - [@mcculls](https://github.com/mcculls)) - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### Database Monitoring - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Dynamic Instrumentation - 🐛 make local var hoisting disabled by default ([#8158](DataDog/dd-trace-java#8158) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix var hoisting issue when no previous store ([#8122](DataDog/dd-trace-java#8122) - [@jpbempel](https://github.com/jpbempel)) - ✨ Only decorate spans without code origin information ([#8105](DataDog/dd-trace-java#8105) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix suspend Kotlin methods instrumentation ([#8080](DataDog/dd-trace-java#8080) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix class file version detection ([#8057](DataDog/dd-trace-java#8057) - [@jpbempel](https://github.com/jpbempel)) ##### GraalVM native-image - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### ML Observability (LLMObs) - ✨🧪 Add LLMObs configuration ([#8076](DataDog/dd-trace-java#8076) - [@gary-huang](https://github.com/gary-huang)) ##### Metrics - Bump integrations-core submodule to 7.60.0 ([#8098](DataDog/dd-trace-java#8098) - [@mcculls](https://github.com/mcculls)) - Upgrade to java-dogstatsd-client v4.4.3 ([#8096](DataDog/dd-trace-java#8096) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - ⚠️🧹 Remove custom scope manager support ([#8164](DataDog/dd-trace-java#8164) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Telemetry - ✨ Retry telemetry requests if CI Visibility is enabled ([#8147](DataDog/dd-trace-java#8147) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add configurable Dependency service resolution period ([#8079](DataDog/dd-trace-java#8079) - [@jandro996](https://github.com/jandro996)) ##### Testing - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### Tracer core - ✨ Defer remote components to avoid OkHttp class-loading side-effects ([#8131](DataDog/dd-trace-java#8131) - [@mcculls](https://github.com/mcculls)) - ✨ Improve Context API null handling and Javadoc ([#8129](DataDog/dd-trace-java#8129) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🐛⚡ Avoid performing blocking I/O operation on application thread ([#8120](DataDog/dd-trace-java#8120) - [@mcculls](https://github.com/mcculls)) - 💡 Introduce a shared context component, independent of tracing ([#8117](DataDog/dd-trace-java#8117) - [@mcculls](https://github.com/mcculls)) - ✨ Improves ServiceNameCollector ([#8109](DataDog/dd-trace-java#8109) - [@amarziali](https://github.com/amarziali)) - Upgrade to ASM 9.7.1 (adds new constant for Java 24) ([#8097](DataDog/dd-trace-java#8097) - [@mcculls](https://github.com/mcculls)) - 🐛 Dynamically evaluate service name for message consumers ([#8088](DataDog/dd-trace-java#8088) - [@amarziali](https://github.com/amarziali)) ##### Serverless - 🐛 Add avoid double instrumenting lambda non-streaming handlers. ([#8073](DataDog/dd-trace-java#8073) - [@purple4reina](https://github.com/purple4reina)) ##### Instrumentations ##### AWS SDK instrumentation - 💡 Instrument EMR's relocated AWS SDK ([#8157](DataDog/dd-trace-java#8157) - [@mcculls](https://github.com/mcculls)) ##### Eclipse Vert.x instrumentation - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### JDBC instrumentation - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Jetty instrumentation - 🐛 Ensure jetty 12 has servlet.path starting with / ([#8093](DataDog/dd-trace-java#8093) - [@github-actions](https://github.com/github-actions)\[bot]) ##### JMS instrumentation - 🧹 Re-use `javax` JMS module for `jakarta` namespace ([#8155](DataDog/dd-trace-java#8155) - [@mcculls](https://github.com/mcculls)) - 🧹 Group `javax.jms` instrumentations under a single module ([#8154](DataDog/dd-trace-java#8154) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛 Reactor: early propagate span in context when subscribing ([#8166](DataDog/dd-trace-java#8166) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: ba2355aa4e2e39ab1fee27319cc4176238efd90b

jandro996 requested a review from a team as a code owner December 12, 2024 09:11

jandro996 requested a review from PerfectSlayer December 12, 2024 09:11

jandro996 requested review from smola, manuel-alvarez-alvarez, ValentinZakharov and Mariovido December 12, 2024 09:12

jandro996 changed the title ~~Add configurable Dependency service resolution period~~ [SCA] - Add configurable Dependency service resolution period Dec 12, 2024

jandro996 added the comp: asm iast Application Security Management (IAST) label Dec 12, 2024

smola reviewed Dec 12, 2024

View reviewed changes

internal-api/src/main/java/datadog/trace/api/Config.java Show resolved Hide resolved

smola added comp: telemetry Telemetry and removed comp: asm iast Application Security Management (IAST) labels Dec 12, 2024

jandro996 requested a review from smola December 12, 2024 09:41

PerfectSlayer added the type: enhancement label Dec 12, 2024

jandro996 changed the title ~~[SCA] - Add configurable Dependency service resolution period~~ Add configurable Dependency service resolution period Dec 12, 2024

smola approved these changes Dec 12, 2024

View reviewed changes

Ad config via env var to Dependency service resolution period

7b102dc

jandro996 force-pushed the alejandro.gonzalez/sca-jar-delay branch from 517441e to 7b102dc Compare December 12, 2024 15:13

jandro996 merged commit fd1f40f into master Dec 12, 2024
150 checks passed

jandro996 deleted the alejandro.gonzalez/sca-jar-delay branch December 12, 2024 16:45

github-actions bot added this to the 1.45.0 milestone Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add configurable Dependency service resolution period #8079

Add configurable Dependency service resolution period #8079

jandro996 commented Dec 12, 2024

github-actions bot commented Dec 12, 2024 •

edited

Loading

pr-commenter bot commented Dec 12, 2024 •

edited

Loading

Add configurable Dependency service resolution period #8079

Add configurable Dependency service resolution period #8079

Conversation

jandro996 commented Dec 12, 2024

What Does This Do

Motivation

Additional Notes

Contributor Checklist

github-actions bot commented Dec 12, 2024 • edited Loading

pr-commenter bot commented Dec 12, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

github-actions bot commented Dec 12, 2024 •

edited

Loading

pr-commenter bot commented Dec 12, 2024 •

edited

Loading