-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration tests - remove libgcc test reference #7743
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~ea48c531e3, baseline=1.41.0-SNAPSHOT~f59673129f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068956
Total [baseline] (10.326 s) : 0, 10326312
Agent [candidate] (1.067 s) : 0, 1066985
Total [candidate] (10.387 s) : 0, 10386635
section appsec
Agent [baseline] (1.213 s) : 0, 1212932
Total [baseline] (10.614 s) : 0, 10613966
Agent [candidate] (1.205 s) : 0, 1205208
Total [candidate] (10.569 s) : 0, 10569438
section iast
Agent [baseline] (1.197 s) : 0, 1197084
Total [baseline] (10.867 s) : 0, 10867227
Agent [candidate] (1.195 s) : 0, 1194899
Total [candidate] (10.836 s) : 0, 10835910
section profiling
Agent [baseline] (1.274 s) : 0, 1274407
Total [baseline] (10.648 s) : 0, 10648341
Agent [candidate] (1.267 s) : 0, 1267308
Total [candidate] (10.623 s) : 0, 10623284
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~ea48c531e3, baseline=1.41.0-SNAPSHOT~f59673129f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.251 ms) : 0, 682251
BytebuddyAgent [candidate] (681.103 ms) : 0, 681103
GlobalTracer [baseline] (310.814 ms) : 0, 310814
GlobalTracer [candidate] (310.506 ms) : 0, 310506
AppSec [baseline] (53.927 ms) : 0, 53927
AppSec [candidate] (53.504 ms) : 0, 53504
Remote Config [baseline] (660.329 µs) : 0, 660
Remote Config [candidate] (646.426 µs) : 0, 646
Telemetry [baseline] (7.658 ms) : 0, 7658
Telemetry [candidate] (7.542 ms) : 0, 7542
section appsec
BytebuddyAgent [baseline] (705.352 ms) : 0, 705352
BytebuddyAgent [candidate] (701.05 ms) : 0, 701050
GlobalTracer [baseline] (310.563 ms) : 0, 310563
GlobalTracer [candidate] (308.338 ms) : 0, 308338
AppSec [baseline] (163.644 ms) : 0, 163644
AppSec [candidate] (162.142 ms) : 0, 162142
Remote Config [baseline] (643.453 µs) : 0, 643
Remote Config [candidate] (640.72 µs) : 0, 641
Telemetry [baseline] (8.827 ms) : 0, 8827
Telemetry [candidate] (8.215 ms) : 0, 8215
IAST [baseline] (20.298 ms) : 0, 20298
IAST [candidate] (22.221 ms) : 0, 22221
section iast
BytebuddyAgent [baseline] (797.773 ms) : 0, 797773
BytebuddyAgent [candidate] (796.21 ms) : 0, 796210
GlobalTracer [baseline] (299.947 ms) : 0, 299947
GlobalTracer [candidate] (299.584 ms) : 0, 299584
AppSec [baseline] (55.937 ms) : 0, 55937
AppSec [candidate] (54.462 ms) : 0, 54462
Remote Config [baseline] (592.867 µs) : 0, 593
Remote Config [candidate] (605.456 µs) : 0, 605
Telemetry [baseline] (7.126 ms) : 0, 7126
Telemetry [candidate] (7.08 ms) : 0, 7080
IAST [baseline] (22.057 ms) : 0, 22057
IAST [candidate] (23.257 ms) : 0, 23257
section profiling
BytebuddyAgent [baseline] (680.585 ms) : 0, 680585
BytebuddyAgent [candidate] (675.934 ms) : 0, 675934
GlobalTracer [baseline] (395.293 ms) : 0, 395293
GlobalTracer [candidate] (393.724 ms) : 0, 393724
AppSec [baseline] (54.534 ms) : 0, 54534
AppSec [candidate] (54.446 ms) : 0, 54446
Remote Config [baseline] (660.674 µs) : 0, 661
Remote Config [candidate] (649.691 µs) : 0, 650
Telemetry [baseline] (7.456 ms) : 0, 7456
Telemetry [candidate] (7.42 ms) : 0, 7420
ProfilingAgent [baseline] (97.059 ms) : 0, 97059
ProfilingAgent [candidate] (96.538 ms) : 0, 96538
Profiling [baseline] (97.083 ms) : 0, 97083
Profiling [candidate] (96.561 ms) : 0, 96561
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~ea48c531e3, baseline=1.41.0-SNAPSHOT~f59673129f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1070227
Total [baseline] (8.563 s) : 0, 8563326
Agent [candidate] (1.073 s) : 0, 1073459
Total [candidate] (8.572 s) : 0, 8571584
section iast
Agent [baseline] (1.196 s) : 0, 1195953
Total [baseline] (9.115 s) : 0, 9115362
Agent [candidate] (1.206 s) : 0, 1205647
Total [candidate] (9.111 s) : 0, 9110554
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1199417
Total [baseline] (9.058 s) : 0, 9057952
Agent [candidate] (1.204 s) : 0, 1203534
Total [candidate] (9.089 s) : 0, 9088667
section iast_TELEMETRY_OFF
Agent [baseline] (1.191 s) : 0, 1190657
Total [baseline] (9.041 s) : 0, 9040702
Agent [candidate] (1.2 s) : 0, 1199893
Total [candidate] (9.113 s) : 0, 9112557
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~ea48c531e3, baseline=1.41.0-SNAPSHOT~f59673129f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.379 ms) : 0, 683379
BytebuddyAgent [candidate] (685.201 ms) : 0, 685201
GlobalTracer [baseline] (311.275 ms) : 0, 311275
GlobalTracer [candidate] (312.051 ms) : 0, 312051
AppSec [baseline] (53.612 ms) : 0, 53612
AppSec [candidate] (54.141 ms) : 0, 54141
Remote Config [baseline] (660.215 µs) : 0, 660
Remote Config [candidate] (666.965 µs) : 0, 667
Telemetry [baseline] (7.611 ms) : 0, 7611
Telemetry [candidate] (7.613 ms) : 0, 7613
section iast
BytebuddyAgent [baseline] (796.51 ms) : 0, 796510
BytebuddyAgent [candidate] (803.024 ms) : 0, 803024
GlobalTracer [baseline] (299.738 ms) : 0, 299738
GlobalTracer [candidate] (302.272 ms) : 0, 302272
AppSec [baseline] (55.43 ms) : 0, 55430
AppSec [candidate] (54.978 ms) : 0, 54978
IAST [baseline] (22.915 ms) : 0, 22915
IAST [candidate] (22.945 ms) : 0, 22945
Remote Config [baseline] (606.612 µs) : 0, 607
Remote Config [candidate] (620.06 µs) : 0, 620
Telemetry [baseline] (7.068 ms) : 0, 7068
Telemetry [candidate] (7.948 ms) : 0, 7948
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.941 ms) : 0, 797941
BytebuddyAgent [candidate] (801.564 ms) : 0, 801564
GlobalTracer [baseline] (301.436 ms) : 0, 301436
GlobalTracer [candidate] (301.789 ms) : 0, 301789
AppSec [baseline] (54.896 ms) : 0, 54896
AppSec [candidate] (52.825 ms) : 0, 52825
IAST [baseline] (23.663 ms) : 0, 23663
IAST [candidate] (25.877 ms) : 0, 25877
Remote Config [baseline] (608.974 µs) : 0, 609
Remote Config [candidate] (595.814 µs) : 0, 596
Telemetry [baseline] (7.139 ms) : 0, 7139
Telemetry [candidate] (7.095 ms) : 0, 7095
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.958 ms) : 0, 792958
BytebuddyAgent [candidate] (799.566 ms) : 0, 799566
GlobalTracer [baseline] (299.007 ms) : 0, 299007
GlobalTracer [candidate] (301.03 ms) : 0, 301030
AppSec [baseline] (56.105 ms) : 0, 56105
AppSec [candidate] (53.849 ms) : 0, 53849
IAST [baseline] (21.344 ms) : 0, 21344
IAST [candidate] (24.092 ms) : 0, 24092
Remote Config [baseline] (608.682 µs) : 0, 609
Remote Config [candidate] (607.407 µs) : 0, 607
Telemetry [baseline] (6.963 ms) : 0, 6963
Telemetry [candidate] (6.916 ms) : 0, 6916
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~ea48c531e3, baseline=1.41.0-SNAPSHOT~f59673129f
dateFormat X
axisFormat %s
section baseline
no_agent (1.341 ms) : 1321, 1361
. : milestone, 1341,
appsec (1.731 ms) : 1706, 1755
. : milestone, 1731,
appsec_no_iast (1.699 ms) : 1674, 1724
. : milestone, 1699,
iast (1.479 ms) : 1456, 1502
. : milestone, 1479,
profiling (1.476 ms) : 1451, 1500
. : milestone, 1476,
tracing (1.472 ms) : 1448, 1496
. : milestone, 1472,
section candidate
no_agent (1.332 ms) : 1313, 1352
. : milestone, 1332,
appsec (1.713 ms) : 1688, 1737
. : milestone, 1713,
appsec_no_iast (1.729 ms) : 1705, 1753
. : milestone, 1729,
iast (1.471 ms) : 1448, 1494
. : milestone, 1471,
profiling (1.479 ms) : 1454, 1503
. : milestone, 1479,
tracing (1.48 ms) : 1456, 1505
. : milestone, 1480,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~ea48c531e3, baseline=1.41.0-SNAPSHOT~f59673129f
dateFormat X
axisFormat %s
section baseline
no_agent (370.769 µs) : 349, 392
. : milestone, 371,
iast (485.205 µs) : 464, 507
. : milestone, 485,
iast_FULL (550.593 µs) : 529, 572
. : milestone, 551,
iast_GLOBAL (503.445 µs) : 482, 525
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (489.341 µs) : 468, 511
. : milestone, 489,
iast_INACTIVE (449.621 µs) : 428, 471
. : milestone, 450,
iast_TELEMETRY_OFF (477.893 µs) : 457, 499
. : milestone, 478,
tracing (445.377 µs) : 425, 466
. : milestone, 445,
section candidate
no_agent (375.71 µs) : 356, 396
. : milestone, 376,
iast (476.69 µs) : 456, 498
. : milestone, 477,
iast_FULL (556.441 µs) : 535, 578
. : milestone, 556,
iast_GLOBAL (521.599 µs) : 499, 544
. : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (484.243 µs) : 463, 505
. : milestone, 484,
iast_INACTIVE (456.613 µs) : 436, 477
. : milestone, 457,
iast_TELEMETRY_OFF (473.221 µs) : 451, 495
. : milestone, 473,
tracing (443.533 µs) : 423, 464
. : milestone, 444,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~ea48c531e3, baseline=1.41.0-SNAPSHOT~f59673129f
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.336 ms) : 2295, 2376
. : milestone, 2336,
iast (2.076 ms) : 2025, 2128
. : milestone, 2076,
iast_GLOBAL (2.131 ms) : 2079, 2182
. : milestone, 2131,
profiling (1.945 ms) : 1903, 1987
. : milestone, 1945,
tracing (1.92 ms) : 1880, 1959
. : milestone, 1920,
section candidate
no_agent (1.468 ms) : 1457, 1479
. : milestone, 1468,
appsec (2.333 ms) : 2293, 2374
. : milestone, 2333,
iast (2.076 ms) : 2024, 2128
. : milestone, 2076,
iast_GLOBAL (2.114 ms) : 2062, 2167
. : milestone, 2114,
profiling (1.942 ms) : 1902, 1983
. : milestone, 1942,
tracing (1.918 ms) : 1880, 1957
. : milestone, 1918,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~ea48c531e3, baseline=1.41.0-SNAPSHOT~f59673129f
dateFormat X
axisFormat %s
section baseline
no_agent (15.474 s) : 15474000, 15474000
. : milestone, 15474000,
appsec (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
iast (18.602 s) : 18602000, 18602000
. : milestone, 18602000,
iast_GLOBAL (18.024 s) : 18024000, 18024000
. : milestone, 18024000,
profiling (15.469 s) : 15469000, 15469000
. : milestone, 15469000,
tracing (15.189 s) : 15189000, 15189000
. : milestone, 15189000,
section candidate
no_agent (15.874 s) : 15874000, 15874000
. : milestone, 15874000,
appsec (15.416 s) : 15416000, 15416000
. : milestone, 15416000,
iast (19.164 s) : 19164000, 19164000
. : milestone, 19164000,
iast_GLOBAL (18.045 s) : 18045000, 18045000
. : milestone, 18045000,
profiling (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
tracing (15.227 s) : 15227000, 15227000
. : milestone, 15227000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
libgcc scenario got removed as the injector does not require libgcc anymore DataDog/system-tests#3174
I missed that the tracer reference it. Here's a broken pipeline
![image](https://private-user-images.githubusercontent.com/22001182/374327447-5637c625-696a-4c75-9945-846716503e85.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTAyNjEsIm5iZiI6MTczOTE4OTk2MSwicGF0aCI6Ii8yMjAwMTE4Mi8zNzQzMjc0NDctNTYzN2M2MjUtNjk2YS00Yzc1LTk5NDUtODQ2NzE2NTAzZTg1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEyMTkyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIxOTkyMmMxNTBiMzFmZmZiNmExNDQxMWU2MjlhYTYzZjE4NzJhMzBkNDg5Y2EyZjc0YjE3OTNiODQ2MDM2MWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.K_YiDain-MO5m0HHo5tkjAzIhyEFjvVJReBgmu_huNY)