-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gradle dependencies #7739
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066482
Total [baseline] (10.428 s) : 0, 10428168
Agent [candidate] (1.067 s) : 0, 1067158
Total [candidate] (10.354 s) : 0, 10353659
section appsec
Agent [baseline] (1.206 s) : 0, 1205805
Total [baseline] (10.538 s) : 0, 10537877
Agent [candidate] (1.201 s) : 0, 1201484
Total [candidate] (10.587 s) : 0, 10587426
section iast
Agent [baseline] (1.203 s) : 0, 1202767
Total [baseline] (10.828 s) : 0, 10827823
Agent [candidate] (1.196 s) : 0, 1195794
Total [candidate] (10.829 s) : 0, 10829323
section profiling
Agent [baseline] (1.266 s) : 0, 1266344
Total [baseline] (10.631 s) : 0, 10631088
Agent [candidate] (1.266 s) : 0, 1266332
Total [candidate] (10.522 s) : 0, 10521789
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.869 ms) : 0, 680869
BytebuddyAgent [candidate] (681.384 ms) : 0, 681384
GlobalTracer [baseline] (309.881 ms) : 0, 309881
GlobalTracer [candidate] (310.17 ms) : 0, 310170
AppSec [baseline] (53.94 ms) : 0, 53940
AppSec [candidate] (53.722 ms) : 0, 53722
Remote Config [baseline] (655.369 µs) : 0, 655
Remote Config [candidate] (663.976 µs) : 0, 664
Telemetry [baseline] (7.522 ms) : 0, 7522
Telemetry [candidate] (7.595 ms) : 0, 7595
section appsec
BytebuddyAgent [baseline] (701.866 ms) : 0, 701866
BytebuddyAgent [candidate] (698.283 ms) : 0, 698283
GlobalTracer [baseline] (307.967 ms) : 0, 307967
GlobalTracer [candidate] (306.595 ms) : 0, 306595
AppSec [baseline] (163.022 ms) : 0, 163022
AppSec [candidate] (163.047 ms) : 0, 163047
Remote Config [baseline] (645.777 µs) : 0, 646
Remote Config [candidate] (644.752 µs) : 0, 645
Telemetry [baseline] (8.567 ms) : 0, 8567
Telemetry [candidate] (8.181 ms) : 0, 8181
IAST [baseline] (20.151 ms) : 0, 20151
IAST [candidate] (22.233 ms) : 0, 22233
section iast
BytebuddyAgent [baseline] (801.791 ms) : 0, 801791
BytebuddyAgent [candidate] (797.036 ms) : 0, 797036
GlobalTracer [baseline] (300.501 ms) : 0, 300501
GlobalTracer [candidate] (298.937 ms) : 0, 298937
AppSec [baseline] (53.667 ms) : 0, 53667
AppSec [candidate] (54.866 ms) : 0, 54866
Remote Config [baseline] (608.337 µs) : 0, 608
Remote Config [candidate] (606.4 µs) : 0, 606
Telemetry [baseline] (7.078 ms) : 0, 7078
Telemetry [candidate] (7.036 ms) : 0, 7036
IAST [baseline] (25.374 ms) : 0, 25374
IAST [candidate] (23.686 ms) : 0, 23686
section profiling
ProfilingAgent [baseline] (96.711 ms) : 0, 96711
ProfilingAgent [candidate] (96.378 ms) : 0, 96378
BytebuddyAgent [baseline] (675.506 ms) : 0, 675506
BytebuddyAgent [candidate] (675.654 ms) : 0, 675654
GlobalTracer [baseline] (392.861 ms) : 0, 392861
GlobalTracer [candidate] (392.939 ms) : 0, 392939
AppSec [baseline] (54.653 ms) : 0, 54653
AppSec [candidate] (54.671 ms) : 0, 54671
Remote Config [baseline] (661.615 µs) : 0, 662
Remote Config [candidate] (651.361 µs) : 0, 651
Telemetry [baseline] (7.466 ms) : 0, 7466
Telemetry [candidate] (7.429 ms) : 0, 7429
Profiling [baseline] (96.734 ms) : 0, 96734
Profiling [candidate] (96.401 ms) : 0, 96401
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1070001
Total [baseline] (8.541 s) : 0, 8541333
Agent [candidate] (1.064 s) : 0, 1063959
Total [candidate] (8.525 s) : 0, 8524678
section iast
Agent [baseline] (1.194 s) : 0, 1194295
Total [baseline] (9.081 s) : 0, 9080588
Agent [candidate] (1.201 s) : 0, 1201037
Total [candidate] (9.087 s) : 0, 9086617
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.201 s) : 0, 1200504
Total [baseline] (9.042 s) : 0, 9042362
Agent [candidate] (1.199 s) : 0, 1199150
Total [candidate] (9.101 s) : 0, 9100780
section iast_TELEMETRY_OFF
Agent [baseline] (1.188 s) : 0, 1188442
Total [baseline] (9.07 s) : 0, 9069693
Agent [candidate] (1.188 s) : 0, 1188456
Total [candidate] (9.067 s) : 0, 9067232
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.746 ms) : 0, 683746
BytebuddyAgent [candidate] (679.684 ms) : 0, 679684
GlobalTracer [baseline] (310.62 ms) : 0, 310620
GlobalTracer [candidate] (308.791 ms) : 0, 308791
AppSec [baseline] (53.673 ms) : 0, 53673
AppSec [candidate] (53.656 ms) : 0, 53656
Remote Config [baseline] (662.367 µs) : 0, 662
Remote Config [candidate] (660.437 µs) : 0, 660
Telemetry [baseline] (7.648 ms) : 0, 7648
Telemetry [candidate] (7.559 ms) : 0, 7559
section iast
BytebuddyAgent [baseline] (795.957 ms) : 0, 795957
BytebuddyAgent [candidate] (800.914 ms) : 0, 800914
GlobalTracer [baseline] (298.897 ms) : 0, 298897
GlobalTracer [candidate] (299.984 ms) : 0, 299984
AppSec [baseline] (53.961 ms) : 0, 53961
AppSec [candidate] (57.256 ms) : 0, 57256
IAST [baseline] (24.204 ms) : 0, 24204
IAST [candidate] (21.395 ms) : 0, 21395
Remote Config [baseline] (598.542 µs) : 0, 599
Remote Config [candidate] (606.387 µs) : 0, 606
Telemetry [baseline] (7.008 ms) : 0, 7008
Telemetry [candidate] (7.116 ms) : 0, 7116
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.946 ms) : 0, 800946
BytebuddyAgent [candidate] (800.97 ms) : 0, 800970
GlobalTracer [baseline] (300.041 ms) : 0, 300041
GlobalTracer [candidate] (298.685 ms) : 0, 298685
AppSec [baseline] (53.244 ms) : 0, 53244
AppSec [candidate] (54.618 ms) : 0, 54618
IAST [baseline] (25.012 ms) : 0, 25012
IAST [candidate] (22.651 ms) : 0, 22651
Remote Config [baseline] (590.904 µs) : 0, 591
Remote Config [candidate] (603.213 µs) : 0, 603
Telemetry [baseline] (6.945 ms) : 0, 6945
Telemetry [candidate] (7.818 ms) : 0, 7818
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.397 ms) : 0, 791397
BytebuddyAgent [candidate] (791.237 ms) : 0, 791237
GlobalTracer [baseline] (298.111 ms) : 0, 298111
GlobalTracer [candidate] (297.937 ms) : 0, 297937
AppSec [baseline] (56.835 ms) : 0, 56835
AppSec [candidate] (53.197 ms) : 0, 53197
IAST [baseline] (20.811 ms) : 0, 20811
IAST [candidate] (24.898 ms) : 0, 24898
Remote Config [baseline] (628.81 µs) : 0, 629
Remote Config [candidate] (607.132 µs) : 0, 607
Telemetry [baseline] (7.02 ms) : 0, 7020
Telemetry [candidate] (6.909 ms) : 0, 6909
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c
dateFormat X
axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1365
. : milestone, 1346,
appsec (1.715 ms) : 1692, 1739
. : milestone, 1715,
appsec_no_iast (1.716 ms) : 1692, 1741
. : milestone, 1716,
iast (1.49 ms) : 1468, 1513
. : milestone, 1490,
profiling (1.5 ms) : 1476, 1524
. : milestone, 1500,
tracing (1.464 ms) : 1439, 1489
. : milestone, 1464,
section candidate
no_agent (1.342 ms) : 1323, 1362
. : milestone, 1342,
appsec (1.71 ms) : 1686, 1733
. : milestone, 1710,
appsec_no_iast (1.731 ms) : 1707, 1754
. : milestone, 1731,
iast (1.461 ms) : 1439, 1484
. : milestone, 1461,
profiling (1.471 ms) : 1446, 1495
. : milestone, 1471,
tracing (1.489 ms) : 1465, 1512
. : milestone, 1489,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c
dateFormat X
axisFormat %s
section baseline
no_agent (370.277 µs) : 350, 391
. : milestone, 370,
iast (486.736 µs) : 465, 508
. : milestone, 487,
iast_FULL (555.075 µs) : 534, 576
. : milestone, 555,
iast_GLOBAL (506.788 µs) : 485, 528
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (479.494 µs) : 458, 501
. : milestone, 479,
iast_INACTIVE (446.917 µs) : 426, 468
. : milestone, 447,
iast_TELEMETRY_OFF (474.246 µs) : 453, 496
. : milestone, 474,
tracing (449.451 µs) : 428, 471
. : milestone, 449,
section candidate
no_agent (373.634 µs) : 354, 393
. : milestone, 374,
iast (481.363 µs) : 460, 503
. : milestone, 481,
iast_FULL (553.502 µs) : 532, 575
. : milestone, 554,
iast_GLOBAL (513.669 µs) : 491, 536
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (486.521 µs) : 465, 508
. : milestone, 487,
iast_INACTIVE (445.585 µs) : 425, 466
. : milestone, 446,
iast_TELEMETRY_OFF (474.091 µs) : 453, 496
. : milestone, 474,
tracing (447.279 µs) : 427, 468
. : milestone, 447,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c
dateFormat X
axisFormat %s
section baseline
no_agent (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
appsec (14.867 s) : 14867000, 14867000
. : milestone, 14867000,
iast (18.821 s) : 18821000, 18821000
. : milestone, 18821000,
iast_GLOBAL (17.988 s) : 17988000, 17988000
. : milestone, 17988000,
profiling (15.082 s) : 15082000, 15082000
. : milestone, 15082000,
tracing (15.259 s) : 15259000, 15259000
. : milestone, 15259000,
section candidate
no_agent (15.743 s) : 15743000, 15743000
. : milestone, 15743000,
appsec (15.136 s) : 15136000, 15136000
. : milestone, 15136000,
iast (18.984 s) : 18984000, 18984000
. : milestone, 18984000,
iast_GLOBAL (18.041 s) : 18041000, 18041000
. : milestone, 18041000,
profiling (15.907 s) : 15907000, 15907000
. : milestone, 15907000,
tracing (15.269 s) : 15269000, 15269000
. : milestone, 15269000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c
dateFormat X
axisFormat %s
section baseline
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.309 ms) : 2268, 2349
. : milestone, 2309,
iast (2.049 ms) : 1999, 2100
. : milestone, 2049,
iast_GLOBAL (2.1 ms) : 2049, 2152
. : milestone, 2100,
profiling (1.934 ms) : 1891, 1976
. : milestone, 1934,
tracing (1.906 ms) : 1867, 1945
. : milestone, 1906,
section candidate
no_agent (1.462 ms) : 1450, 1473
. : milestone, 1462,
appsec (2.326 ms) : 2285, 2366
. : milestone, 2326,
iast (2.068 ms) : 2016, 2120
. : milestone, 2068,
iast_GLOBAL (2.103 ms) : 2051, 2155
. : milestone, 2103,
profiling (2.371 ms) : 2136, 2606
. : milestone, 2371,
tracing (1.905 ms) : 1866, 1943
. : milestone, 1905,
|
I updated the mongo server version that we use to run the tests, because the latest client uses a new wire version to talk to it, so we need a server that can understand wire version 7. |
Release 5.2.0 of the java client includes this PR which adds an extra parameter to a method we instrumented, shifting the position of the argument we were relying on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
using the server image v5 changes how the client spans look for the v4.3 of the client only I think 🤔 (tests on v4.10 pass and on v4.0.1 pass as well). |
* chore: Update Gradle dependencies * chore: Update Gradle dependencies * chore: Update Gradle dependencies * chore: Update Gradle dependencies * chore: Update Gradle dependencies * chore: Update Gradle dependencies * chore: Update Gradle dependencies * update mongo container used to run tests against * apply advice to method with new parameter ordering * downgrade server image to v4 because v5 causes issues with tests on client 4.3 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Raphaël Vandon <[email protected]>
This PR updates the Gradle dependencies.⚠️ Don't forget to squash commits before merging. ⚠️