-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config provider alias priority test #7706
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~0de0fb01eb, baseline=1.41.0-SNAPSHOT~0a80d676b0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064555
Total [baseline] (8.55 s) : 0, 8550072
Agent [candidate] (1.066 s) : 0, 1065619
Total [candidate] (8.553 s) : 0, 8552737
section iast
Agent [baseline] (1.203 s) : 0, 1202806
Total [baseline] (9.095 s) : 0, 9095155
Agent [candidate] (1.201 s) : 0, 1200913
Total [candidate] (9.116 s) : 0, 9116102
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.207 s) : 0, 1207298
Total [baseline] (9.078 s) : 0, 9078373
Agent [candidate] (1.195 s) : 0, 1195434
Total [candidate] (9.091 s) : 0, 9090800
section iast_TELEMETRY_OFF
Agent [baseline] (1.2 s) : 0, 1199611
Total [baseline] (9.102 s) : 0, 9102137
Agent [candidate] (1.203 s) : 0, 1202670
Total [candidate] (9.075 s) : 0, 9074580
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~0de0fb01eb, baseline=1.41.0-SNAPSHOT~0a80d676b0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.936 ms) : 0, 679936
BytebuddyAgent [candidate] (680.491 ms) : 0, 680491
GlobalTracer [baseline] (308.972 ms) : 0, 308972
GlobalTracer [candidate] (309.608 ms) : 0, 309608
AppSec [baseline] (53.757 ms) : 0, 53757
AppSec [candidate] (53.618 ms) : 0, 53618
Remote Config [baseline] (666.201 µs) : 0, 666
Remote Config [candidate] (663.814 µs) : 0, 664
Telemetry [baseline] (7.647 ms) : 0, 7647
Telemetry [candidate] (7.635 ms) : 0, 7635
section iast
BytebuddyAgent [baseline] (802.149 ms) : 0, 802149
BytebuddyAgent [candidate] (800.06 ms) : 0, 800060
GlobalTracer [baseline] (300.778 ms) : 0, 300778
GlobalTracer [candidate] (300.835 ms) : 0, 300835
AppSec [baseline] (53.321 ms) : 0, 53321
AppSec [candidate] (53.98 ms) : 0, 53980
IAST [baseline] (25.159 ms) : 0, 25159
IAST [candidate] (24.575 ms) : 0, 24575
Remote Config [baseline] (611.136 µs) : 0, 611
Remote Config [candidate] (620.981 µs) : 0, 621
Telemetry [baseline] (7.058 ms) : 0, 7058
Telemetry [candidate] (7.083 ms) : 0, 7083
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.555 ms) : 0, 807555
BytebuddyAgent [candidate] (795.805 ms) : 0, 795805
GlobalTracer [baseline] (300.488 ms) : 0, 300488
GlobalTracer [candidate] (300.017 ms) : 0, 300017
AppSec [baseline] (56.481 ms) : 0, 56481
AppSec [candidate] (53.756 ms) : 0, 53756
IAST [baseline] (21.158 ms) : 0, 21158
IAST [candidate] (22.83 ms) : 0, 22830
Remote Config [baseline] (620.77 µs) : 0, 621
Remote Config [candidate] (620.929 µs) : 0, 621
Telemetry [baseline] (7.143 ms) : 0, 7143
Telemetry [candidate] (8.655 ms) : 0, 8655
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.053 ms) : 0, 799053
BytebuddyAgent [candidate] (799.601 ms) : 0, 799601
GlobalTracer [baseline] (300.789 ms) : 0, 300789
GlobalTracer [candidate] (302.871 ms) : 0, 302871
AppSec [baseline] (55.184 ms) : 0, 55184
AppSec [candidate] (55.311 ms) : 0, 55311
IAST [baseline] (23.208 ms) : 0, 23208
IAST [candidate] (23.49 ms) : 0, 23490
Remote Config [baseline] (609.899 µs) : 0, 610
Remote Config [candidate] (614.127 µs) : 0, 614
Telemetry [baseline] (6.983 ms) : 0, 6983
Telemetry [candidate] (6.92 ms) : 0, 6920
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~0de0fb01eb, baseline=1.41.0-SNAPSHOT~0a80d676b0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067058
Total [baseline] (10.392 s) : 0, 10392422
Agent [candidate] (1.068 s) : 0, 1068007
Total [candidate] (10.337 s) : 0, 10337213
section appsec
Agent [baseline] (1.208 s) : 0, 1207755
Total [baseline] (10.618 s) : 0, 10618136
Agent [candidate] (1.21 s) : 0, 1210241
Total [candidate] (10.65 s) : 0, 10649944
section iast
Agent [baseline] (1.208 s) : 0, 1208340
Total [baseline] (10.849 s) : 0, 10848624
Agent [candidate] (1.196 s) : 0, 1195755
Total [candidate] (10.906 s) : 0, 10906314
section profiling
Agent [baseline] (1.274 s) : 0, 1273630
Total [baseline] (10.621 s) : 0, 10621099
Agent [candidate] (1.274 s) : 0, 1274157
Total [candidate] (10.593 s) : 0, 10593170
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~0de0fb01eb, baseline=1.41.0-SNAPSHOT~0a80d676b0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.307 ms) : 0, 681307
BytebuddyAgent [candidate] (681.685 ms) : 0, 681685
GlobalTracer [baseline] (310.296 ms) : 0, 310296
GlobalTracer [candidate] (310.697 ms) : 0, 310697
AppSec [baseline] (53.618 ms) : 0, 53618
AppSec [candidate] (53.676 ms) : 0, 53676
Remote Config [baseline] (667.748 µs) : 0, 668
Remote Config [candidate] (664.363 µs) : 0, 664
Telemetry [baseline] (7.544 ms) : 0, 7544
Telemetry [candidate] (7.646 ms) : 0, 7646
section appsec
BytebuddyAgent [baseline] (702.665 ms) : 0, 702665
BytebuddyAgent [candidate] (704.749 ms) : 0, 704749
GlobalTracer [baseline] (308.28 ms) : 0, 308280
GlobalTracer [candidate] (309.41 ms) : 0, 309410
AppSec [baseline] (161.621 ms) : 0, 161621
AppSec [candidate] (163.337 ms) : 0, 163337
IAST [baseline] (21.78 ms) : 0, 21780
IAST [candidate] (20.159 ms) : 0, 20159
Remote Config [baseline] (636.576 µs) : 0, 637
Remote Config [candidate] (650.142 µs) : 0, 650
Telemetry [baseline] (9.976 ms) : 0, 9976
Telemetry [candidate] (8.265 ms) : 0, 8265
section iast
BytebuddyAgent [baseline] (806.484 ms) : 0, 806484
BytebuddyAgent [candidate] (796.317 ms) : 0, 796317
GlobalTracer [baseline] (302.28 ms) : 0, 302280
GlobalTracer [candidate] (299.848 ms) : 0, 299848
AppSec [baseline] (54.631 ms) : 0, 54631
AppSec [candidate] (53.781 ms) : 0, 53781
IAST [baseline] (23.508 ms) : 0, 23508
IAST [candidate] (24.521 ms) : 0, 24521
Remote Config [baseline] (614.181 µs) : 0, 614
Remote Config [candidate] (624.936 µs) : 0, 625
Telemetry [baseline] (7.053 ms) : 0, 7053
Telemetry [candidate] (7.001 ms) : 0, 7001
section profiling
BytebuddyAgent [baseline] (679.187 ms) : 0, 679187
BytebuddyAgent [candidate] (680.414 ms) : 0, 680414
GlobalTracer [baseline] (395.736 ms) : 0, 395736
GlobalTracer [candidate] (394.569 ms) : 0, 394569
AppSec [baseline] (54.773 ms) : 0, 54773
AppSec [candidate] (54.941 ms) : 0, 54941
Remote Config [baseline] (659.356 µs) : 0, 659
Remote Config [candidate] (668.928 µs) : 0, 669
Telemetry [baseline] (7.461 ms) : 0, 7461
Telemetry [candidate] (7.494 ms) : 0, 7494
ProfilingAgent [baseline] (96.96 ms) : 0, 96960
ProfilingAgent [candidate] (97.267 ms) : 0, 97267
Profiling [baseline] (96.984 ms) : 0, 96984
Profiling [candidate] (97.291 ms) : 0, 97291
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~0de0fb01eb, baseline=1.41.0-SNAPSHOT~0a80d676b0
dateFormat X
axisFormat %s
section baseline
no_agent (1.361 ms) : 1341, 1381
. : milestone, 1361,
appsec (1.735 ms) : 1711, 1760
. : milestone, 1735,
appsec_no_iast (1.707 ms) : 1682, 1732
. : milestone, 1707,
iast (1.482 ms) : 1459, 1504
. : milestone, 1482,
profiling (1.486 ms) : 1463, 1509
. : milestone, 1486,
tracing (1.476 ms) : 1451, 1500
. : milestone, 1476,
section candidate
no_agent (1.344 ms) : 1323, 1364
. : milestone, 1344,
appsec (1.726 ms) : 1702, 1750
. : milestone, 1726,
appsec_no_iast (1.74 ms) : 1715, 1764
. : milestone, 1740,
iast (1.476 ms) : 1453, 1499
. : milestone, 1476,
profiling (1.494 ms) : 1470, 1519
. : milestone, 1494,
tracing (1.46 ms) : 1435, 1485
. : milestone, 1460,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~0de0fb01eb, baseline=1.41.0-SNAPSHOT~0a80d676b0
dateFormat X
axisFormat %s
section baseline
no_agent (376.333 µs) : 357, 396
. : milestone, 376,
iast (490.467 µs) : 469, 512
. : milestone, 490,
iast_FULL (560.264 µs) : 539, 582
. : milestone, 560,
iast_GLOBAL (501.417 µs) : 480, 522
. : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (484.873 µs) : 463, 506
. : milestone, 485,
iast_INACTIVE (446.345 µs) : 426, 467
. : milestone, 446,
iast_TELEMETRY_OFF (479.459 µs) : 458, 501
. : milestone, 479,
tracing (450.629 µs) : 430, 471
. : milestone, 451,
section candidate
no_agent (379.903 µs) : 358, 402
. : milestone, 380,
iast (489.289 µs) : 468, 510
. : milestone, 489,
iast_FULL (554.946 µs) : 534, 576
. : milestone, 555,
iast_GLOBAL (505.47 µs) : 484, 527
. : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (490.158 µs) : 469, 512
. : milestone, 490,
iast_INACTIVE (447.876 µs) : 427, 469
. : milestone, 448,
iast_TELEMETRY_OFF (479.572 µs) : 458, 501
. : milestone, 480,
tracing (445.136 µs) : 424, 466
. : milestone, 445,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~0de0fb01eb, baseline=1.41.0-SNAPSHOT~0a80d676b0
dateFormat X
axisFormat %s
section baseline
no_agent (15.092 s) : 15092000, 15092000
. : milestone, 15092000,
appsec (15.406 s) : 15406000, 15406000
. : milestone, 15406000,
iast (18.893 s) : 18893000, 18893000
. : milestone, 18893000,
iast_GLOBAL (18.021 s) : 18021000, 18021000
. : milestone, 18021000,
profiling (15.271 s) : 15271000, 15271000
. : milestone, 15271000,
tracing (15.278 s) : 15278000, 15278000
. : milestone, 15278000,
section candidate
no_agent (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
appsec (15.111 s) : 15111000, 15111000
. : milestone, 15111000,
iast (18.922 s) : 18922000, 18922000
. : milestone, 18922000,
iast_GLOBAL (18.327 s) : 18327000, 18327000
. : milestone, 18327000,
profiling (15.368 s) : 15368000, 15368000
. : milestone, 15368000,
tracing (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~0de0fb01eb, baseline=1.41.0-SNAPSHOT~0a80d676b0
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.303 ms) : 2263, 2344
. : milestone, 2303,
iast (2.064 ms) : 2013, 2116
. : milestone, 2064,
iast_GLOBAL (2.105 ms) : 2053, 2157
. : milestone, 2105,
profiling (1.93 ms) : 1889, 1970
. : milestone, 1930,
tracing (1.91 ms) : 1871, 1949
. : milestone, 1910,
section candidate
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.313 ms) : 2273, 2353
. : milestone, 2313,
iast (2.064 ms) : 2012, 2116
. : milestone, 2064,
iast_GLOBAL (2.099 ms) : 2048, 2150
. : milestone, 2099,
profiling (1.923 ms) : 1881, 1964
. : milestone, 1923,
tracing (1.92 ms) : 1881, 1959
. : milestone, 1920,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What Does This Do
Add missing tests useful to #7694
Motivation
Config aliases were untested and should not be tested for every feature that use it but rather in config tests.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]