-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the DebuggerProbe #7460
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 8 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (312.346 µs) : 239, 386
. : milestone, 312,
basic (302.426 µs) : 283, 322
. : milestone, 302,
loop (10.979 ms) : 10954, 11004
. : milestone, 10979,
section candidate
noprobe (289.115 µs) : 260, 318
. : milestone, 289,
basic (288.676 µs) : 281, 296
. : milestone, 289,
loop (10.278 ms) : 10247, 10309
. : milestone, 10278,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~8cd4b402a8, baseline=1.40.0-SNAPSHOT~1d59e612a6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059142
Total [baseline] (10.349 s) : 0, 10349193
Agent [candidate] (1.053 s) : 0, 1053155
Total [candidate] (10.411 s) : 0, 10411476
section appsec
Agent [baseline] (1.184 s) : 0, 1183955
Total [baseline] (10.569 s) : 0, 10569320
Agent [candidate] (1.19 s) : 0, 1189832
Total [candidate] (10.625 s) : 0, 10624593
section iast
Agent [baseline] (1.186 s) : 0, 1186480
Total [baseline] (10.835 s) : 0, 10835417
Agent [candidate] (1.184 s) : 0, 1184150
Total [candidate] (10.846 s) : 0, 10845650
section profiling
Agent [baseline] (1.249 s) : 0, 1248736
Total [baseline] (10.558 s) : 0, 10557563
Agent [candidate] (1.265 s) : 0, 1265169
Total [candidate] (10.695 s) : 0, 10695076
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~8cd4b402a8, baseline=1.40.0-SNAPSHOT~1d59e612a6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (676.067 ms) : 0, 676067
BytebuddyAgent [candidate] (672.145 ms) : 0, 672145
GlobalTracer [baseline] (309.47 ms) : 0, 309470
GlobalTracer [candidate] (307.905 ms) : 0, 307905
AppSec [baseline] (51.729 ms) : 0, 51729
AppSec [candidate] (51.319 ms) : 0, 51319
Remote Config [baseline] (703.345 µs) : 0, 703
Remote Config [candidate] (676.127 µs) : 0, 676
Telemetry [baseline] (7.501 ms) : 0, 7501
Telemetry [candidate] (7.492 ms) : 0, 7492
section appsec
BytebuddyAgent [baseline] (691.845 ms) : 0, 691845
BytebuddyAgent [candidate] (694.825 ms) : 0, 694825
GlobalTracer [baseline] (299.895 ms) : 0, 299895
GlobalTracer [candidate] (302.417 ms) : 0, 302417
AppSec [baseline] (159.683 ms) : 0, 159683
AppSec [candidate] (159.262 ms) : 0, 159262
IAST [baseline] (20.927 ms) : 0, 20927
IAST [candidate] (19.986 ms) : 0, 19986
Remote Config [baseline] (628.228 µs) : 0, 628
Remote Config [candidate] (634.634 µs) : 0, 635
Telemetry [baseline] (7.856 ms) : 0, 7856
Telemetry [candidate] (9.051 ms) : 0, 9051
section iast
BytebuddyAgent [baseline] (788.769 ms) : 0, 788769
BytebuddyAgent [candidate] (787.669 ms) : 0, 787669
GlobalTracer [baseline] (298.994 ms) : 0, 298994
GlobalTracer [candidate] (298.408 ms) : 0, 298408
AppSec [baseline] (53.418 ms) : 0, 53418
AppSec [candidate] (52.83 ms) : 0, 52830
IAST [baseline] (23.587 ms) : 0, 23587
IAST [candidate] (23.6 ms) : 0, 23600
Remote Config [baseline] (624.05 µs) : 0, 624
Remote Config [candidate] (593.811 µs) : 0, 594
Telemetry [baseline] (7.407 ms) : 0, 7407
Telemetry [candidate] (7.364 ms) : 0, 7364
section profiling
BytebuddyAgent [baseline] (665.87 ms) : 0, 665870
BytebuddyAgent [candidate] (674.908 ms) : 0, 674908
GlobalTracer [baseline] (390.275 ms) : 0, 390275
GlobalTracer [candidate] (393.59 ms) : 0, 393590
AppSec [baseline] (52.0 ms) : 0, 52000
AppSec [candidate] (52.762 ms) : 0, 52762
Remote Config [baseline] (684.649 µs) : 0, 685
Remote Config [candidate] (705.63 µs) : 0, 706
Telemetry [baseline] (7.341 ms) : 0, 7341
Telemetry [candidate] (7.497 ms) : 0, 7497
ProfilingAgent [baseline] (94.806 ms) : 0, 94806
ProfilingAgent [candidate] (97.358 ms) : 0, 97358
Profiling [baseline] (94.83 ms) : 0, 94830
Profiling [candidate] (97.383 ms) : 0, 97383
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~8cd4b402a8, baseline=1.40.0-SNAPSHOT~1d59e612a6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062310
Total [baseline] (8.595 s) : 0, 8595271
Agent [candidate] (1.055 s) : 0, 1054677
Total [candidate] (8.556 s) : 0, 8556182
section iast
Agent [baseline] (1.181 s) : 0, 1181288
Total [baseline] (9.016 s) : 0, 9016374
Agent [candidate] (1.186 s) : 0, 1185693
Total [candidate] (9.03 s) : 0, 9030019
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1177101
Total [baseline] (8.949 s) : 0, 8948623
Agent [candidate] (1.18 s) : 0, 1180358
Total [candidate] (8.993 s) : 0, 8992546
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170301
Total [baseline] (8.972 s) : 0, 8972376
Agent [candidate] (1.182 s) : 0, 1182047
Total [candidate] (8.988 s) : 0, 8987806
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~8cd4b402a8, baseline=1.40.0-SNAPSHOT~1d59e612a6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.395 ms) : 0, 678395
BytebuddyAgent [candidate] (672.907 ms) : 0, 672907
GlobalTracer [baseline] (310.07 ms) : 0, 310070
GlobalTracer [candidate] (308.678 ms) : 0, 308678
AppSec [baseline] (51.846 ms) : 0, 51846
AppSec [candidate] (51.29 ms) : 0, 51290
Remote Config [baseline] (691.244 µs) : 0, 691
Remote Config [candidate] (682.651 µs) : 0, 683
Telemetry [baseline] (7.58 ms) : 0, 7580
Telemetry [candidate] (7.493 ms) : 0, 7493
section iast
BytebuddyAgent [baseline] (784.854 ms) : 0, 784854
BytebuddyAgent [candidate] (788.496 ms) : 0, 788496
GlobalTracer [baseline] (298.307 ms) : 0, 298307
GlobalTracer [candidate] (298.515 ms) : 0, 298515
AppSec [baseline] (52.882 ms) : 0, 52882
AppSec [candidate] (54.934 ms) : 0, 54934
IAST [baseline] (23.57 ms) : 0, 23570
IAST [candidate] (21.162 ms) : 0, 21162
Remote Config [baseline] (660.639 µs) : 0, 661
Remote Config [candidate] (1.342 ms) : 0, 1342
Telemetry [baseline] (7.392 ms) : 0, 7392
Telemetry [candidate] (7.469 ms) : 0, 7469
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (782.385 ms) : 0, 782385
BytebuddyAgent [candidate] (784.46 ms) : 0, 784460
GlobalTracer [baseline] (296.909 ms) : 0, 296909
GlobalTracer [candidate] (297.669 ms) : 0, 297669
AppSec [baseline] (53.632 ms) : 0, 53632
AppSec [candidate] (52.06 ms) : 0, 52060
IAST [baseline] (21.87 ms) : 0, 21870
IAST [candidate] (23.741 ms) : 0, 23741
Remote Config [baseline] (592.28 µs) : 0, 592
Remote Config [candidate] (602.243 µs) : 0, 602
Telemetry [baseline] (8.109 ms) : 0, 8109
Telemetry [candidate] (8.157 ms) : 0, 8157
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.037 ms) : 0, 777037
BytebuddyAgent [candidate] (785.188 ms) : 0, 785188
GlobalTracer [baseline] (295.831 ms) : 0, 295831
GlobalTracer [candidate] (298.731 ms) : 0, 298731
AppSec [baseline] (52.726 ms) : 0, 52726
AppSec [candidate] (53.922 ms) : 0, 53922
IAST [baseline] (20.997 ms) : 0, 20997
IAST [candidate] (20.229 ms) : 0, 20229
Remote Config [baseline] (603.64 µs) : 0, 604
Remote Config [candidate] (605.802 µs) : 0, 606
Telemetry [baseline] (9.559 ms) : 0, 9559
Telemetry [candidate] (9.62 ms) : 0, 9620
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~8cd4b402a8, baseline=1.40.0-SNAPSHOT~1d59e612a6
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1333, 1372
. : milestone, 1353,
appsec (1.739 ms) : 1716, 1762
. : milestone, 1739,
appsec_no_iast (1.709 ms) : 1685, 1734
. : milestone, 1709,
iast (1.477 ms) : 1454, 1499
. : milestone, 1477,
profiling (1.481 ms) : 1457, 1506
. : milestone, 1481,
tracing (1.475 ms) : 1451, 1499
. : milestone, 1475,
section candidate
no_agent (1.351 ms) : 1332, 1370
. : milestone, 1351,
appsec (1.729 ms) : 1704, 1753
. : milestone, 1729,
appsec_no_iast (1.714 ms) : 1689, 1738
. : milestone, 1714,
iast (1.484 ms) : 1462, 1507
. : milestone, 1484,
profiling (1.476 ms) : 1453, 1498
. : milestone, 1476,
tracing (1.451 ms) : 1426, 1476
. : milestone, 1451,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~8cd4b402a8, baseline=1.40.0-SNAPSHOT~1d59e612a6
dateFormat X
axisFormat %s
section baseline
no_agent (364.53 µs) : 344, 385
. : milestone, 365,
iast (482.178 µs) : 460, 504
. : milestone, 482,
iast_FULL (546.165 µs) : 525, 567
. : milestone, 546,
iast_GLOBAL (512.308 µs) : 490, 534
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (484.423 µs) : 463, 505
. : milestone, 484,
iast_INACTIVE (443.786 µs) : 423, 465
. : milestone, 444,
iast_TELEMETRY_OFF (472.951 µs) : 450, 496
. : milestone, 473,
tracing (439.375 µs) : 419, 460
. : milestone, 439,
section candidate
no_agent (370.632 µs) : 350, 391
. : milestone, 371,
iast (478.95 µs) : 457, 501
. : milestone, 479,
iast_FULL (555.245 µs) : 534, 577
. : milestone, 555,
iast_GLOBAL (505.803 µs) : 484, 528
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (480.949 µs) : 459, 503
. : milestone, 481,
iast_INACTIVE (442.558 µs) : 422, 463
. : milestone, 443,
iast_TELEMETRY_OFF (466.236 µs) : 444, 489
. : milestone, 466,
tracing (439.046 µs) : 419, 459
. : milestone, 439,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~8cd4b402a8, baseline=1.40.0-SNAPSHOT~1d59e612a6
dateFormat X
axisFormat %s
section baseline
no_agent (15.548 s) : 15548000, 15548000
. : milestone, 15548000,
appsec (15.417 s) : 15417000, 15417000
. : milestone, 15417000,
iast (18.977 s) : 18977000, 18977000
. : milestone, 18977000,
iast_GLOBAL (17.83 s) : 17830000, 17830000
. : milestone, 17830000,
profiling (15.955 s) : 15955000, 15955000
. : milestone, 15955000,
tracing (14.878 s) : 14878000, 14878000
. : milestone, 14878000,
section candidate
no_agent (15.514 s) : 15514000, 15514000
. : milestone, 15514000,
appsec (15.189 s) : 15189000, 15189000
. : milestone, 15189000,
iast (19.099 s) : 19099000, 19099000
. : milestone, 19099000,
iast_GLOBAL (18.077 s) : 18077000, 18077000
. : milestone, 18077000,
profiling (15.371 s) : 15371000, 15371000
. : milestone, 15371000,
tracing (15.276 s) : 15276000, 15276000
. : milestone, 15276000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~8cd4b402a8, baseline=1.40.0-SNAPSHOT~1d59e612a6
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.241 ms) : 2206, 2277
. : milestone, 2241,
iast (1.989 ms) : 1945, 2032
. : milestone, 1989,
iast_GLOBAL (2.021 ms) : 1978, 2065
. : milestone, 2021,
profiling (1.876 ms) : 1841, 1910
. : milestone, 1876,
tracing (1.855 ms) : 1822, 1888
. : milestone, 1855,
section candidate
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.227 ms) : 2192, 2263
. : milestone, 2227,
iast (1.984 ms) : 1941, 2027
. : milestone, 1984,
iast_GLOBAL (2.028 ms) : 1984, 2072
. : milestone, 2028,
profiling (1.877 ms) : 1841, 1912
. : milestone, 1877,
tracing (1.853 ms) : 1820, 1887
. : milestone, 1853,
|
dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/DebuggerProbe.java
Show resolved
Hide resolved
dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/Configuration.java
Show resolved
Hide resolved
dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/DebuggerProbe.java
Show resolved
Hide resolved
.../agent-debugger/src/main/java/com/datadog/debugger/agent/DebuggerProductChangesListener.java
Show resolved
Hide resolved
df83442
to
9b6cc13
Compare
What Does This Do
Implement the DebuggerProbe as defined in the RFC as well as some related changes from the Code Origin for Spans RFC
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-2719