Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump integrations-core submodule to 7.51.0 #6750

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Bump integrations-core submodule to 7.51.0 #6750

merged 1 commit into from
Feb 28, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Feb 28, 2024 •
edited
Loading

Motivation

Pulls the latest metrics configuration files into the Java tracer (previously we pulled in 7.50.0)

The only change of interest was to kafka/datadog_checks/kafka/data/metrics.yaml

Add kafka metric kafka.consumer.fetch_rate

@mcculls mcculls added the comp: jmx-fetch JMX fetch label Feb 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited by mcculls
Loading

Hi! 👋 Looks like you updated a Git Submodule.

This was intentional :)

@mcculls mcculls marked this pull request as ready for review February 28, 2024 09:45
@mcculls mcculls requested a review from a team as a code owner February 28, 2024 09:45
@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/integrations-core-7.51.0
git_commit_date 1709101358 1709112811
git_commit_sha 0c76db1 576a884
release_version 1.31.0-SNAPSHOT~0c76db1530 1.31.0-SNAPSHOT~576a884c42
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1709115702 1709115702
ci_job_id 445534206 445534206
ci_pipeline_id 29100355 29100355
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.31.0-SNAPSHOT~576a884c42, baseline=1.31.0-SNAPSHOT~0c76db1530

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077975
Total [baseline] (9.206 s) : 0, 9205959
Agent [candidate] (1.092 s) : 0, 1092370
Total [candidate] (9.272 s) : 0, 9271981
section appsec
Agent [baseline] (1.176 s) : 0, 1176206
Total [baseline] (9.337 s) : 0, 9336700
Agent [candidate] (1.18 s) : 0, 1180480
Total [candidate] (9.334 s) : 0, 9334086
section iast
Agent [baseline] (1.207 s) : 0, 1206886
Total [baseline] (9.38 s) : 0, 9379569
Agent [candidate] (1.212 s) : 0, 1212133
Total [candidate] (9.396 s) : 0, 9395722
section profiling
Agent [baseline] (1.278 s) : 0, 1277740
Total [baseline] (9.39 s) : 0, 9390015
Agent [candidate] (1.283 s) : 0, 1282603
Total [candidate] (9.431 s) : 0, 9431274
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.176 s 98.231 ms (9.1%)
Agent iast 1.207 s 128.911 ms (12.0%)
Agent profiling 1.278 s 199.765 ms (18.5%)
Total tracing 9.206 s -
Total appsec 9.337 s 130.741 ms (1.4%)
Total iast 9.38 s 173.609 ms (1.9%)
Total profiling 9.39 s 184.056 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.18 s 88.11 ms (8.1%)
Agent iast 1.212 s 119.763 ms (11.0%)
Agent profiling 1.283 s 190.233 ms (17.4%)
Total tracing 9.272 s -
Total appsec 9.334 s 62.104 ms (0.7%)
Total iast 9.396 s 123.741 ms (1.3%)
Total profiling 9.431 s 159.293 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.31.0-SNAPSHOT~576a884c42, baseline=1.31.0-SNAPSHOT~0c76db1530

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.783 ms) : 0, 686783
BytebuddyAgent [candidate] (695.142 ms) : 0, 695142
GlobalTracer [baseline] (297.161 ms) : 0, 297161
GlobalTracer [candidate] (301.937 ms) : 0, 301937
AppSec [baseline] (51.176 ms) : 0, 51176
AppSec [candidate] (51.994 ms) : 0, 51994
Remote Config [baseline] (708.146 µs) : 0, 708
Remote Config [candidate] (732.849 µs) : 0, 733
Telemetry [baseline] (7.814 ms) : 0, 7814
Telemetry [candidate] (7.97 ms) : 0, 7970
section appsec
BytebuddyAgent [baseline] (687.196 ms) : 0, 687196
BytebuddyAgent [candidate] (688.32 ms) : 0, 688320
GlobalTracer [baseline] (296.652 ms) : 0, 296652
GlobalTracer [candidate] (298.358 ms) : 0, 298358
AppSec [baseline] (150.415 ms) : 0, 150415
AppSec [candidate] (151.846 ms) : 0, 151846
Remote Config [baseline] (639.752 µs) : 0, 640
Remote Config [candidate] (635.301 µs) : 0, 635
Telemetry [baseline] (6.923 ms) : 0, 6923
Telemetry [candidate] (6.967 ms) : 0, 6967
section iast
BytebuddyAgent [baseline] (800.17 ms) : 0, 800170
BytebuddyAgent [candidate] (803.626 ms) : 0, 803626
GlobalTracer [baseline] (289.018 ms) : 0, 289018
GlobalTracer [candidate] (290.524 ms) : 0, 290524
AppSec [baseline] (51.173 ms) : 0, 51173
AppSec [candidate] (51.332 ms) : 0, 51332
Remote Config [baseline] (598.71 µs) : 0, 599
Remote Config [candidate] (609.503 µs) : 0, 610
Telemetry [baseline] (6.642 ms) : 0, 6642
Telemetry [candidate] (6.742 ms) : 0, 6742
IAST [baseline] (24.977 ms) : 0, 24977
IAST [candidate] (24.963 ms) : 0, 24963
section profiling
BytebuddyAgent [baseline] (682.457 ms) : 0, 682457
BytebuddyAgent [candidate] (684.988 ms) : 0, 684988
GlobalTracer [baseline] (381.882 ms) : 0, 381882
GlobalTracer [candidate] (383.785 ms) : 0, 383785
AppSec [baseline] (53.203 ms) : 0, 53203
AppSec [candidate] (53.028 ms) : 0, 53028
Remote Config [baseline] (784.568 µs) : 0, 785
Remote Config [candidate] (777.655 µs) : 0, 778
Telemetry [baseline] (10.398 ms) : 0, 10398
Telemetry [candidate] (9.888 ms) : 0, 9888
ProfilingAgent [baseline] (92.484 ms) : 0, 92484
ProfilingAgent [candidate] (93.612 ms) : 0, 93612
Profiling [baseline] (92.508 ms) : 0, 92508
Profiling [candidate] (93.636 ms) : 0, 93636
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-02-28T09:57:58 2024-02-28T10:16:40
git_branch master mcculls/integrations-core-7.51.0
git_commit_date 1709101358 1709112811
git_commit_sha 0c76db1 576a884
release_version 1.31.0-SNAPSHOT~0c76db1530 1.31.0-SNAPSHOT~576a884c42
start_time 2024-02-28T09:57:45 2024-02-28T10:16:26
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1709115702 1709115702
ci_job_id 445534206 445534206
ci_pipeline_id 29100355 29100355
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 14 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~576a884c42, baseline=1.31.0-SNAPSHOT~0c76db1530
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.362 ms) : 1343, 1380
.   : milestone, 1362,
appsec (1.793 ms) : 1769, 1817
.   : milestone, 1793,
iast (1.525 ms) : 1501, 1548
.   : milestone, 1525,
profiling (1.554 ms) : 1529, 1579
.   : milestone, 1554,
tracing (1.508 ms) : 1485, 1531
.   : milestone, 1508,
section candidate
no_agent (1.381 ms) : 1361, 1401
.   : milestone, 1381,
appsec (1.773 ms) : 1749, 1796
.   : milestone, 1773,
iast (1.528 ms) : 1504, 1552
.   : milestone, 1528,
profiling (1.544 ms) : 1521, 1567
.   : milestone, 1544,
tracing (1.532 ms) : 1509, 1555
.   : milestone, 1532,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.343 ms, 1.38 ms] -
appsec 1.793 ms [1.769 ms, 1.817 ms] 431.357 µs (31.7%)
iast 1.525 ms [1.501 ms, 1.548 ms] 162.993 µs (12.0%)
profiling 1.554 ms [1.529 ms, 1.579 ms] 192.774 µs (14.2%)
tracing 1.508 ms [1.485 ms, 1.531 ms] 146.496 µs (10.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.381 ms [1.361 ms, 1.401 ms] -
appsec 1.773 ms [1.749 ms, 1.796 ms] 391.592 µs (28.4%)
iast 1.528 ms [1.504 ms, 1.552 ms] 147.328 µs (10.7%)
profiling 1.544 ms [1.521 ms, 1.567 ms] 163.091 µs (11.8%)
tracing 1.532 ms [1.509 ms, 1.555 ms] 150.941 µs (10.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~576a884c42, baseline=1.31.0-SNAPSHOT~0c76db1530
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.115 µs) : 349, 389
.   : milestone, 369,
iast (476.557 µs) : 456, 497
.   : milestone, 477,
iast_FULL (545.244 µs) : 525, 566
.   : milestone, 545,
iast_GLOBAL (501.895 µs) : 481, 522
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (482.904 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (447.815 µs) : 428, 468
.   : milestone, 448,
iast_TELEMETRY_OFF (478.168 µs) : 457, 499
.   : milestone, 478,
tracing (453.989 µs) : 432, 476
.   : milestone, 454,
section candidate
no_agent (370.093 µs) : 350, 390
.   : milestone, 370,
iast (485.85 µs) : 465, 507
.   : milestone, 486,
iast_FULL (546.777 µs) : 526, 567
.   : milestone, 547,
iast_GLOBAL (499.195 µs) : 478, 520
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (480.293 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (451.037 µs) : 431, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (482.142 µs) : 462, 502
.   : milestone, 482,
tracing (449.217 µs) : 429, 470
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.115 µs [349.438 µs, 388.792 µs] -
iast 476.557 µs [456.255 µs, 496.86 µs] 107.442 µs (29.1%)
iast_FULL 545.244 µs [524.8 µs, 565.689 µs] 176.129 µs (47.7%)
iast_GLOBAL 501.895 µs [481.389 µs, 522.401 µs] 132.78 µs (36.0%)
iast_HARDCODED_SECRET_DISABLED 482.904 µs [462.026 µs, 503.782 µs] 113.789 µs (30.8%)
iast_INACTIVE 447.815 µs [427.652 µs, 467.978 µs] 78.7 µs (21.3%)
iast_TELEMETRY_OFF 478.168 µs [457.275 µs, 499.062 µs] 109.053 µs (29.5%)
tracing 453.989 µs [432.47 µs, 475.507 µs] 84.874 µs (23.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.093 µs [349.955 µs, 390.231 µs] -
iast 485.85 µs [464.553 µs, 507.148 µs] 115.758 µs (31.3%)
iast_FULL 546.777 µs [526.13 µs, 567.425 µs] 176.685 µs (47.7%)
iast_GLOBAL 499.195 µs [478.183 µs, 520.208 µs] 129.103 µs (34.9%)
iast_HARDCODED_SECRET_DISABLED 480.293 µs [459.394 µs, 501.193 µs] 110.201 µs (29.8%)
iast_INACTIVE 451.037 µs [430.569 µs, 471.504 µs] 80.944 µs (21.9%)
iast_TELEMETRY_OFF 482.142 µs [461.856 µs, 502.428 µs] 112.049 µs (30.3%)
tracing 449.217 µs [428.753 µs, 469.68 µs] 79.124 µs (21.4%)

@mcculls mcculls merged commit 15de16c into master Feb 28, 2024
82 checks passed
@mcculls mcculls deleted the mcculls/integrations-core-7.51.0 branch February 28, 2024 10:25
@github-actions github-actions bot added this to the 1.31.0 milestone Feb 28, 2024
jandro996 pushed a commit that referenced this pull request Feb 29, 2024
@mcculls @jandro996
Bump integrations-core submodule to 7.51.0 (#6750)
ed330ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

@smola smola smola approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: jmx-fetch JMX fetch
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mcculls @smola @jbachorik