Embedding existing jmx integrations with git submodule #639
Conversation
| @@ -0,0 +1,5 @@ | |||
| activemq.yaml | |||
There was a problem hiding this comment.
Could you please add readme file in this directory explaining its contents and where those files are coming from?
There was a problem hiding this comment.
Done. Does the new readme look ok?
|
LGTM |
|
Can't merge this until we get a new version of jmxfetch. |
There was a problem hiding this comment.
Can we come up with a more automated way to pull these files in? Generally I'd like to be able to specify a sha/tag in integrations-core and get the matching jxm files into the build or into our repo. If we copy-paste it will be tricky to track down the integrations-core version these files originated from.
We can sync up offline and I can take you through a potential solution.
|
@realark That was fully my intention. This was just intended to demonstrate the flow after those files were brought in and to validate the changes I made to jmxfetch. Sorry if that wasn't more clear. |
|
@tylerbenson Oh sure. I'll remove my review in that case. |
Using copy/paste from integrations-core. Will depend on a new jmxfetch release with DataDog/jmxfetch#205 before this will work.
tylerbenson
force-pushed
the
tyler/jmxfetch
branch
from
5a9fbf8 to
8e5fc48
Compare
tylerbenson
changed the title
tylerbenson
force-pushed
the
tyler/jmxfetch
branch
from
8e5fc48 to
3696337
Compare
tylerbenson
force-pushed
the
tyler/jmxfetch
branch
from
3696337 to
f63d40f
Compare
| task submodulesUpdate(type:Exec) { | ||
| group 'Build Setup' | ||
| description 'Initializes and updates integrations-core git submodule' | ||
| commandLine 'git', 'submodule', 'update', '--init', 'integrations-core' |
There was a problem hiding this comment.
Update here just means populating the directory with the repo contents, it doesn't change the commit the submodule is based off of.
This includes the ability to load config from resources.
|
@mar-kolya This is ready for review now that we have the proper version of jmxfetch. |
Now uses a git submodule to load the integrations from
integrations-core.Will depend on a new jmxfetch release with DataDog/jmxfetch#205 before this will work.