Skip to content

Safely handle Files.exist on discovery and config when a Security Manager is present #10009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2025
Merged

Safely handle Files.exist on discovery and config when a Security Manager is present #10009

merged 4 commits into from
Nov 21, 2025

Conversation

@amarziali
Copy link
Contributor

@amarziali amarziali commented Nov 21, 2025 •
edited
Loading

What Does This Do

This PR introduces a new filesystem utility module. The Files class provides a safe way to check for file existence, properly handling SecurityException when it occurs.

The main motivation is to allow the agent to start under a SecurityManager while preserving as much functionality as possible. Previously, when starting the agent with APM disabled but JmxFetch enabled, JmxFetch could fail to start because its discovery process checked for file existence without catching SecurityException, causing JmxFetch startup to break.

Example exception:

Caused by: java.security.AccessControlException: access denied ("[java.io](http://java.io/).FilePermission" "/var/run/datadog/dsd.socket" "read")
	at java.base/java.security.AccessControlContext.checkPermission(AccessControlContext.java:488)
	at java.base/java.security.AccessController.checkPermission(AccessController.java:1071)
	at java.base/java.lang.SecurityManager.checkPermission(SecurityManager.java:411)
	at java.base/java.lang.SecurityManager.checkRead(SecurityManager.java:742)
	at java.base/java.io.File.exists(File.java:831)
	at datadog.communication.monitor.DDAgentStatsDConnection.discoverConnectionSettings(DDAgentStatsDConnection.java:189)

Note: This PR does not replace all calls to File.exists(). Handling other occurrences can be addressed in a separate PR.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner November 21, 2025 09:16
@amarziali amarziali added type: bug Bug report and fix comp: core Tracer core labels Nov 21, 2025
@amarziali amarziali requested a review from mcculls November 21, 2025 09:17
@amarziali amarziali enabled auto-merge (squash) November 21, 2025 10:01
@amarziali amarziali disabled auto-merge November 21, 2025 10:07
@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/discovery-safe
git_commit_date 1763710237 1763740143
git_commit_sha 6b32bdd fd8b3e9
release_version 1.57.0-SNAPSHOT~6b32bddf07 1.57.0-SNAPSHOT~fd8b3e96d7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1763742031 1763742031
ci_job_id 1251074899 1251074899
ci_pipeline_id 83614396 83614396
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-3-bfa7tjzn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-3-bfa7tjzn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~fd8b3e96d7, baseline=1.57.0-SNAPSHOT~6b32bddf07

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.123 s) : 0, 1123448
Total [baseline] (11.004 s) : 0, 11004386
Agent [candidate] (1.104 s) : 0, 1103799
Total [candidate] (10.928 s) : 0, 10928276
section appsec
Agent [baseline] (1.29 s) : 0, 1290059
Total [baseline] (11.128 s) : 0, 11128069
Agent [candidate] (1.296 s) : 0, 1296183
Total [candidate] (11.226 s) : 0, 11226122
section iast
Agent [baseline] (1.244 s) : 0, 1243819
Total [baseline] (11.301 s) : 0, 11300706
Agent [candidate] (1.246 s) : 0, 1245552
Total [candidate] (11.326 s) : 0, 11325597
section profiling
Agent [baseline] (1.242 s) : 0, 1241811
Total [baseline] (11.316 s) : 0, 11315549
Agent [candidate] (1.234 s) : 0, 1234072
Total [candidate] (11.155 s) : 0, 11155447
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.123 s -
Agent appsec 1.29 s 166.611 ms (14.8%)
Agent iast 1.244 s 120.371 ms (10.7%)
Agent profiling 1.242 s 118.363 ms (10.5%)
Total tracing 11.004 s -
Total appsec 11.128 s 123.683 ms (1.1%)
Total iast 11.301 s 296.32 ms (2.7%)
Total profiling 11.316 s 311.163 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.104 s -
Agent appsec 1.296 s 192.384 ms (17.4%)
Agent iast 1.246 s 141.753 ms (12.8%)
Agent profiling 1.234 s 130.273 ms (11.8%)
Total tracing 10.928 s -
Total appsec 11.226 s 297.846 ms (2.7%)
Total iast 11.326 s 397.321 ms (3.6%)
Total profiling 11.155 s 227.171 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~fd8b3e96d7, baseline=1.57.0-SNAPSHOT~6b32bddf07

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.516 ms) : 0, 1516
crashtracking [candidate] (1.501 ms) : 0, 1501
BytebuddyAgent [baseline] (720.752 ms) : 0, 720752
BytebuddyAgent [candidate] (708.78 ms) : 0, 708780
GlobalTracer [baseline] (254.43 ms) : 0, 254430
GlobalTracer [candidate] (249.788 ms) : 0, 249788
AppSec [baseline] (33.098 ms) : 0, 33098
AppSec [candidate] (31.922 ms) : 0, 31922
Debugger [baseline] (65.489 ms) : 0, 65489
Debugger [candidate] (64.283 ms) : 0, 64283
Remote Config [baseline] (645.275 µs) : 0, 645
Remote Config [candidate] (626.169 µs) : 0, 626
Telemetry [baseline] (8.41 ms) : 0, 8410
Telemetry [candidate] (8.326 ms) : 0, 8326
Flare Poller [baseline] (3.796 ms) : 0, 3796
Flare Poller [candidate] (3.762 ms) : 0, 3762
section appsec
crashtracking [baseline] (1.501 ms) : 0, 1501
crashtracking [candidate] (1.517 ms) : 0, 1517
BytebuddyAgent [baseline] (735.103 ms) : 0, 735103
BytebuddyAgent [candidate] (739.903 ms) : 0, 739903
GlobalTracer [baseline] (242.575 ms) : 0, 242575
GlobalTracer [candidate] (243.444 ms) : 0, 243444
AppSec [baseline] (175.924 ms) : 0, 175924
AppSec [candidate] (175.8 ms) : 0, 175800
Debugger [baseline] (61.825 ms) : 0, 61825
Debugger [candidate] (62.263 ms) : 0, 62263
Remote Config [baseline] (676.813 µs) : 0, 677
Remote Config [candidate] (675.785 µs) : 0, 676
Telemetry [baseline] (8.267 ms) : 0, 8267
Telemetry [candidate] (8.444 ms) : 0, 8444
Flare Poller [baseline] (3.962 ms) : 0, 3962
Flare Poller [candidate] (3.931 ms) : 0, 3931
IAST [baseline] (25.185 ms) : 0, 25185
IAST [candidate] (25.056 ms) : 0, 25056
section iast
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.502 ms) : 0, 1502
BytebuddyAgent [baseline] (835.363 ms) : 0, 835363
BytebuddyAgent [candidate] (835.446 ms) : 0, 835446
GlobalTracer [baseline] (238.385 ms) : 0, 238385
GlobalTracer [candidate] (239.128 ms) : 0, 239128
AppSec [baseline] (32.204 ms) : 0, 32204
AppSec [candidate] (33.41 ms) : 0, 33410
Debugger [baseline] (60.504 ms) : 0, 60504
Debugger [candidate] (60.881 ms) : 0, 60881
Remote Config [baseline] (538.8 µs) : 0, 539
Remote Config [candidate] (536.12 µs) : 0, 536
Telemetry [baseline] (7.611 ms) : 0, 7611
Telemetry [candidate] (7.678 ms) : 0, 7678
Flare Poller [baseline] (3.501 ms) : 0, 3501
Flare Poller [candidate] (3.528 ms) : 0, 3528
IAST [baseline] (29.267 ms) : 0, 29267
IAST [candidate] (28.517 ms) : 0, 28517
section profiling
ProfilingAgent [baseline] (98.43 ms) : 0, 98430
ProfilingAgent [candidate] (96.766 ms) : 0, 96766
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (740.437 ms) : 0, 740437
BytebuddyAgent [candidate] (735.932 ms) : 0, 735932
GlobalTracer [baseline] (223.484 ms) : 0, 223484
GlobalTracer [candidate] (223.347 ms) : 0, 223347
AppSec [baseline] (32.483 ms) : 0, 32483
AppSec [candidate] (31.929 ms) : 0, 31929
Debugger [baseline] (63.495 ms) : 0, 63495
Debugger [candidate] (62.988 ms) : 0, 62988
Remote Config [baseline] (648.71 µs) : 0, 649
Remote Config [candidate] (654.644 µs) : 0, 655
Telemetry [baseline] (8.001 ms) : 0, 8001
Telemetry [candidate] (8.063 ms) : 0, 8063
Flare Poller [baseline] (3.787 ms) : 0, 3787
Flare Poller [candidate] (3.825 ms) : 0, 3825
Profiling [baseline] (99.045 ms) : 0, 99045
Profiling [candidate] (97.35 ms) : 0, 97350
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~fd8b3e96d7, baseline=1.57.0-SNAPSHOT~6b32bddf07

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.102 s) : 0, 1101706
Total [baseline] (8.875 s) : 0, 8874949
Agent [candidate] (1.102 s) : 0, 1102119
Total [candidate] (8.858 s) : 0, 8857607
section iast
Agent [baseline] (1.247 s) : 0, 1247379
Total [baseline] (9.592 s) : 0, 9591765
Agent [candidate] (1.247 s) : 0, 1247248
Total [candidate] (9.58 s) : 0, 9579992
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.102 s -
Agent iast 1.247 s 145.673 ms (13.2%)
Total tracing 8.875 s -
Total iast 9.592 s 716.816 ms (8.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.102 s -
Agent iast 1.247 s 145.129 ms (13.2%)
Total tracing 8.858 s -
Total iast 9.58 s 722.384 ms (8.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~fd8b3e96d7, baseline=1.57.0-SNAPSHOT~6b32bddf07

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.526 ms) : 0, 1526
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (707.268 ms) : 0, 707268
BytebuddyAgent [candidate] (708.536 ms) : 0, 708536
GlobalTracer [baseline] (249.836 ms) : 0, 249836
GlobalTracer [candidate] (249.385 ms) : 0, 249385
AppSec [baseline] (32.109 ms) : 0, 32109
AppSec [candidate] (31.954 ms) : 0, 31954
Debugger [baseline] (63.423 ms) : 0, 63423
Debugger [candidate] (63.265 ms) : 0, 63265
Remote Config [baseline] (644.287 µs) : 0, 644
Remote Config [candidate] (628.011 µs) : 0, 628
Telemetry [baseline] (8.271 ms) : 0, 8271
Telemetry [candidate] (8.288 ms) : 0, 8288
Flare Poller [baseline] (3.701 ms) : 0, 3701
Flare Poller [candidate] (3.728 ms) : 0, 3728
section iast
crashtracking [baseline] (1.506 ms) : 0, 1506
crashtracking [candidate] (1.491 ms) : 0, 1491
BytebuddyAgent [baseline] (839.313 ms) : 0, 839313
BytebuddyAgent [candidate] (838.869 ms) : 0, 838869
GlobalTracer [baseline] (238.13 ms) : 0, 238130
GlobalTracer [candidate] (239.182 ms) : 0, 239182
IAST [baseline] (29.122 ms) : 0, 29122
IAST [candidate] (28.848 ms) : 0, 28848
AppSec [baseline] (32.426 ms) : 0, 32426
AppSec [candidate] (32.371 ms) : 0, 32371
Debugger [baseline] (60.207 ms) : 0, 60207
Debugger [candidate] (59.814 ms) : 0, 59814
Remote Config [baseline] (538.365 µs) : 0, 538
Remote Config [candidate] (535.533 µs) : 0, 536
Telemetry [baseline] (7.578 ms) : 0, 7578
Telemetry [candidate] (7.561 ms) : 0, 7561
Flare Poller [baseline] (3.48 ms) : 0, 3480
Flare Poller [candidate] (3.42 ms) : 0, 3420
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/discovery-safe
git_commit_date 1763710237 1763740143
git_commit_sha 6b32bdd fd8b3e9
release_version 1.57.0-SNAPSHOT~6b32bddf07 1.57.0-SNAPSHOT~fd8b3e96d7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1763742512 1763742512
ci_job_id 1251074901 1251074901
ci_pipeline_id 83614396 83614396
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-4-a0l535vg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-4-a0l535vg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:profiling:high_load better
[-155.985µs; -52.554µs] or [-9.232%; -3.111%]		 unstable
[-892.204µs; -196.758µs] or [-18.800%; -4.146%]		 unstable
[-97.941op/s; +470.691op/s] or [-4.487%; +21.564%]		 1.585ms 4.201ms 2369.156op/s 1.690ms 4.746ms 2182.781op/s
scenario:load:petclinic:appsec:high_load better
[-1.813ms; -0.854ms] or [-9.228%; -4.348%]		 better
[-2.349ms; -0.692ms] or [-7.517%; -2.214%]		 unstable
[-12.372op/s; +43.310op/s] or [-5.263%; +18.422%]		 18.314ms 29.727ms 250.562op/s 19.648ms 31.247ms 235.094op/s
scenario:load:petclinic:code_origins:high_load worse
[+0.818ms; +1.638ms] or [+4.754%; +9.518%]		 worse
[+0.621ms; +2.115ms] or [+2.211%; +7.530%]		 unstable
[-46.981op/s; +12.106op/s] or [-17.649%; +4.548%]		 18.440ms 29.463ms 248.750op/s 17.212ms 28.094ms 266.188op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~fd8b3e96d7, baseline=1.57.0-SNAPSHOT~6b32bddf07
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.078 ms) : 18883, 19272
.   : milestone, 19078,
appsec (19.858 ms) : 19656, 20061
.   : milestone, 19858,
code_origins (17.529 ms) : 17358, 17700
.   : milestone, 17529,
iast (17.714 ms) : 17539, 17889
.   : milestone, 17714,
profiling (19.462 ms) : 19266, 19657
.   : milestone, 19462,
tracing (18.088 ms) : 17906, 18270
.   : milestone, 18088,
section candidate
no_agent (18.143 ms) : 17959, 18327
.   : milestone, 18143,
appsec (18.627 ms) : 18437, 18816
.   : milestone, 18627,
code_origins (18.759 ms) : 18571, 18948
.   : milestone, 18759,
iast (17.669 ms) : 17498, 17841
.   : milestone, 17669,
profiling (20.421 ms) : 20212, 20630
.   : milestone, 20421,
tracing (17.614 ms) : 17438, 17790
.   : milestone, 17614,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.078 ms [18.883 ms, 19.272 ms] -
appsec 19.858 ms [19.656 ms, 20.061 ms] 780.689 µs (4.1%)
code_origins 17.529 ms [17.358 ms, 17.7 ms] -1.549 ms (-8.1%)
iast 17.714 ms [17.539 ms, 17.889 ms] -1.364 ms (-7.1%)
profiling 19.462 ms [19.266 ms, 19.657 ms] 383.825 µs (2.0%)
tracing 18.088 ms [17.906 ms, 18.27 ms] -989.675 µs (-5.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.143 ms [17.959 ms, 18.327 ms] -
appsec 18.627 ms [18.437 ms, 18.816 ms] 483.655 µs (2.7%)
code_origins 18.759 ms [18.571 ms, 18.948 ms] 616.21 µs (3.4%)
iast 17.669 ms [17.498 ms, 17.841 ms] -473.758 µs (-2.6%)
profiling 20.421 ms [20.212 ms, 20.63 ms] 2.278 ms (12.6%)
tracing 17.614 ms [17.438 ms, 17.79 ms] -529.024 µs (-2.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~fd8b3e96d7, baseline=1.57.0-SNAPSHOT~6b32bddf07
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.201 ms) : 1189, 1212
.   : milestone, 1201,
iast (3.151 ms) : 3111, 3191
.   : milestone, 3151,
iast_FULL (5.637 ms) : 5580, 5693
.   : milestone, 5637,
iast_GLOBAL (3.557 ms) : 3501, 3613
.   : milestone, 3557,
profiling (2.071 ms) : 2051, 2090
.   : milestone, 2071,
tracing (1.828 ms) : 1814, 1843
.   : milestone, 1828,
section candidate
no_agent (1.203 ms) : 1192, 1215
.   : milestone, 1203,
iast (3.156 ms) : 3116, 3195
.   : milestone, 3156,
iast_FULL (5.754 ms) : 5697, 5812
.   : milestone, 5754,
iast_GLOBAL (3.701 ms) : 3637, 3765
.   : milestone, 3701,
profiling (1.902 ms) : 1887, 1917
.   : milestone, 1902,
tracing (1.816 ms) : 1801, 1831
.   : milestone, 1816,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.201 ms [1.189 ms, 1.212 ms] -
iast 3.151 ms [3.111 ms, 3.191 ms] 1.95 ms (162.4%)
iast_FULL 5.637 ms [5.58 ms, 5.693 ms] 4.436 ms (369.4%)
iast_GLOBAL 3.557 ms [3.501 ms, 3.613 ms] 2.356 ms (196.3%)
profiling 2.071 ms [2.051 ms, 2.09 ms] 869.803 µs (72.4%)
tracing 1.828 ms [1.814 ms, 1.843 ms] 627.676 µs (52.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.203 ms [1.192 ms, 1.215 ms] -
iast 3.156 ms [3.116 ms, 3.195 ms] 1.952 ms (162.2%)
iast_FULL 5.754 ms [5.697 ms, 5.812 ms] 4.551 ms (378.2%)
iast_GLOBAL 3.701 ms [3.637 ms, 3.765 ms] 2.497 ms (207.5%)
profiling 1.902 ms [1.887 ms, 1.917 ms] 698.216 µs (58.0%)
tracing 1.816 ms [1.801 ms, 1.831 ms] 612.651 µs (50.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/discovery-safe
git_commit_date 1763710237 1763740143
git_commit_sha 6b32bdd fd8b3e9
release_version 1.57.0-SNAPSHOT~6b32bddf07 1.57.0-SNAPSHOT~fd8b3e96d7
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1763742207 1763742207
ci_job_id 1251074903 1251074903
ci_pipeline_id 83614396 83614396
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-7-qv8qfpr6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-7-qv8qfpr6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~fd8b3e96d7, baseline=1.57.0-SNAPSHOT~6b32bddf07
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.488 ms) : 1477, 1500
.   : milestone, 1488,
appsec (3.675 ms) : 3458, 3893
.   : milestone, 3675,
iast (2.236 ms) : 2171, 2302
.   : milestone, 2236,
iast_GLOBAL (2.276 ms) : 2211, 2342
.   : milestone, 2276,
profiling (2.105 ms) : 2051, 2160
.   : milestone, 2105,
tracing (2.068 ms) : 2016, 2120
.   : milestone, 2068,
section candidate
no_agent (1.489 ms) : 1478, 1501
.   : milestone, 1489,
appsec (3.756 ms) : 3536, 3975
.   : milestone, 3756,
iast (2.239 ms) : 2173, 2304
.   : milestone, 2239,
iast_GLOBAL (2.275 ms) : 2210, 2341
.   : milestone, 2275,
profiling (2.114 ms) : 2059, 2169
.   : milestone, 2114,
tracing (2.076 ms) : 2025, 2128
.   : milestone, 2076,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.488 ms [1.477 ms, 1.5 ms] -
appsec 3.675 ms [3.458 ms, 3.893 ms] 2.187 ms (146.9%)
iast 2.236 ms [2.171 ms, 2.302 ms] 748.056 µs (50.3%)
iast_GLOBAL 2.276 ms [2.211 ms, 2.342 ms] 787.749 µs (52.9%)
profiling 2.105 ms [2.051 ms, 2.16 ms] 616.888 µs (41.4%)
tracing 2.068 ms [2.016 ms, 2.12 ms] 579.741 µs (38.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.489 ms [1.478 ms, 1.501 ms] -
appsec 3.756 ms [3.536 ms, 3.975 ms] 2.266 ms (152.1%)
iast 2.239 ms [2.173 ms, 2.304 ms] 749.166 µs (50.3%)
iast_GLOBAL 2.275 ms [2.21 ms, 2.341 ms] 785.957 µs (52.8%)
profiling 2.114 ms [2.059 ms, 2.169 ms] 624.531 µs (41.9%)
tracing 2.076 ms [2.025 ms, 2.128 ms] 587.011 µs (39.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~fd8b3e96d7, baseline=1.57.0-SNAPSHOT~6b32bddf07
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.652 s) : 15652000, 15652000
.   : milestone, 15652000,
appsec (14.888 s) : 14888000, 14888000
.   : milestone, 14888000,
iast (18.372 s) : 18372000, 18372000
.   : milestone, 18372000,
iast_GLOBAL (17.847 s) : 17847000, 17847000
.   : milestone, 17847000,
profiling (15.1 s) : 15100000, 15100000
.   : milestone, 15100000,
tracing (14.844 s) : 14844000, 14844000
.   : milestone, 14844000,
section candidate
no_agent (15.064 s) : 15064000, 15064000
.   : milestone, 15064000,
appsec (14.972 s) : 14972000, 14972000
.   : milestone, 14972000,
iast (18.35 s) : 18350000, 18350000
.   : milestone, 18350000,
iast_GLOBAL (18.166 s) : 18166000, 18166000
.   : milestone, 18166000,
profiling (14.923 s) : 14923000, 14923000
.   : milestone, 14923000,
tracing (14.866 s) : 14866000, 14866000
.   : milestone, 14866000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.652 s [15.652 s, 15.652 s] -
appsec 14.888 s [14.888 s, 14.888 s] -764.0 ms (-4.9%)
iast 18.372 s [18.372 s, 18.372 s] 2.72 s (17.4%)
iast_GLOBAL 17.847 s [17.847 s, 17.847 s] 2.195 s (14.0%)
profiling 15.1 s [15.1 s, 15.1 s] -552.0 ms (-3.5%)
tracing 14.844 s [14.844 s, 14.844 s] -808.0 ms (-5.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.064 s [15.064 s, 15.064 s] -
appsec 14.972 s [14.972 s, 14.972 s] -92.0 ms (-0.6%)
iast 18.35 s [18.35 s, 18.35 s] 3.286 s (21.8%)
iast_GLOBAL 18.166 s [18.166 s, 18.166 s] 3.102 s (20.6%)
profiling 14.923 s [14.923 s, 14.923 s] -141.0 ms (-0.9%)
tracing 14.866 s [14.866 s, 14.866 s] -198.0 ms (-1.3%)

@amarziali amarziali enabled auto-merge (squash) November 21, 2025 10:33
PerfectSlayer
PerfectSlayer approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements. Left minor comments.

AlexeyKuznetsov-DD
AlexeyKuznetsov-DD reviewed Nov 21, 2025
View reviewed changes
utils/filesystem-utils/src/test/java/datadog/common/filesystem/FilesTest.java
}

@Test
@DisabledIf("isJava18OrLater")
Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, in our code base I can see @DisabledIf applied without using methods, for example:

  @DisabledIf(
      value = "datadog.environment.JavaVirtualMachine#isJ9",
      disabledReason = "Bug in J9: no LocalVariableTable for ClassFileTransformer")

Is it possible to configure same way?

@amarziali amarziali merged commit b65a3ce into master Nov 21, 2025
538 checks passed
@amarziali amarziali deleted the andrea.marziali/discovery-safe branch November 21, 2025 17:05
@github-actions github-actions bot added this to the 1.57.0 milestone Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes

@mcculls mcculls mcculls approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: core Tracer core type: bug Bug report and fix

Projects

None yet

Milestone

1.57.0

Development

Successfully merging this pull request may close these issues.

5 participants

@amarziali @mcculls @PerfectSlayer @AlexeyKuznetsov-DD