-
Notifications
You must be signed in to change notification settings - Fork 318
Minor code cleanup. #10008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Minor code cleanup. #10008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahchen6
approved these changes
Nov 21, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~67a53927ac, baseline=1.57.0-SNAPSHOT~632fb11d4e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1102755
Total [baseline] (10.779 s) : 0, 10779379
Agent [candidate] (1.113 s) : 0, 1113225
Total [candidate] (10.892 s) : 0, 10892361
section appsec
Agent [baseline] (1.288 s) : 0, 1287553
Total [baseline] (11.146 s) : 0, 11146119
Agent [candidate] (1.285 s) : 0, 1284864
Total [candidate] (11.129 s) : 0, 11129120
section iast
Agent [baseline] (1.245 s) : 0, 1244900
Total [baseline] (11.282 s) : 0, 11281776
Agent [candidate] (1.242 s) : 0, 1241778
Total [candidate] (11.33 s) : 0, 11330119
section profiling
Agent [baseline] (1.242 s) : 0, 1242407
Total [baseline] (11.149 s) : 0, 11148888
Agent [candidate] (1.243 s) : 0, 1243395
Total [candidate] (11.104 s) : 0, 11104383
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~67a53927ac, baseline=1.57.0-SNAPSHOT~632fb11d4e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (707.967 ms) : 0, 707967
BytebuddyAgent [candidate] (714.565 ms) : 0, 714565
GlobalTracer [baseline] (249.147 ms) : 0, 249147
GlobalTracer [candidate] (252.754 ms) : 0, 252754
AppSec [baseline] (32.255 ms) : 0, 32255
AppSec [candidate] (32.376 ms) : 0, 32376
Debugger [baseline] (64.2 ms) : 0, 64200
Debugger [candidate] (64.303 ms) : 0, 64303
Remote Config [baseline] (642.24 µs) : 0, 642
Remote Config [candidate] (644.31 µs) : 0, 644
Telemetry [baseline] (8.409 ms) : 0, 8409
Telemetry [candidate] (8.311 ms) : 0, 8311
Flare Poller [baseline] (3.777 ms) : 0, 3777
Flare Poller [candidate] (3.742 ms) : 0, 3742
section appsec
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (734.996 ms) : 0, 734996
BytebuddyAgent [candidate] (733.173 ms) : 0, 733173
GlobalTracer [baseline] (241.754 ms) : 0, 241754
GlobalTracer [candidate] (240.962 ms) : 0, 240962
IAST [baseline] (24.926 ms) : 0, 24926
IAST [candidate] (24.657 ms) : 0, 24657
AppSec [baseline] (174.244 ms) : 0, 174244
AppSec [candidate] (174.555 ms) : 0, 174555
Debugger [baseline] (62.2 ms) : 0, 62200
Debugger [candidate] (62.09 ms) : 0, 62090
Remote Config [baseline] (666.895 µs) : 0, 667
Remote Config [candidate] (686.951 µs) : 0, 687
Telemetry [baseline] (8.277 ms) : 0, 8277
Telemetry [candidate] (8.294 ms) : 0, 8294
Flare Poller [baseline] (3.987 ms) : 0, 3987
Flare Poller [candidate] (3.963 ms) : 0, 3963
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (835.42 ms) : 0, 835420
BytebuddyAgent [candidate] (832.436 ms) : 0, 832436
GlobalTracer [baseline] (238.997 ms) : 0, 238997
GlobalTracer [candidate] (238.134 ms) : 0, 238134
IAST [baseline] (26.593 ms) : 0, 26593
IAST [candidate] (28.5 ms) : 0, 28500
AppSec [baseline] (34.8 ms) : 0, 34800
AppSec [candidate] (33.133 ms) : 0, 33133
Debugger [baseline] (60.839 ms) : 0, 60839
Debugger [candidate] (61.211 ms) : 0, 61211
Remote Config [baseline] (536.954 µs) : 0, 537
Remote Config [candidate] (563.629 µs) : 0, 564
Telemetry [baseline] (7.647 ms) : 0, 7647
Telemetry [candidate] (7.74 ms) : 0, 7740
Flare Poller [baseline] (3.489 ms) : 0, 3489
Flare Poller [candidate] (3.525 ms) : 0, 3525
section profiling
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (741.39 ms) : 0, 741390
BytebuddyAgent [candidate] (741.541 ms) : 0, 741541
GlobalTracer [baseline] (223.742 ms) : 0, 223742
GlobalTracer [candidate] (223.479 ms) : 0, 223479
AppSec [baseline] (32.661 ms) : 0, 32661
AppSec [candidate] (32.595 ms) : 0, 32595
Debugger [baseline] (63.308 ms) : 0, 63308
Debugger [candidate] (63.618 ms) : 0, 63618
Remote Config [baseline] (658.142 µs) : 0, 658
Remote Config [candidate] (651.108 µs) : 0, 651
Telemetry [baseline] (7.951 ms) : 0, 7951
Telemetry [candidate] (7.98 ms) : 0, 7980
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (3.802 ms) : 0, 3802
ProfilingAgent [baseline] (97.289 ms) : 0, 97289
ProfilingAgent [candidate] (98.165 ms) : 0, 98165
Profiling [baseline] (97.885 ms) : 0, 97885
Profiling [candidate] (98.765 ms) : 0, 98765
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~67a53927ac, baseline=1.57.0-SNAPSHOT~632fb11d4e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1100936
Total [baseline] (8.83 s) : 0, 8830103
Agent [candidate] (1.105 s) : 0, 1104639
Total [candidate] (8.849 s) : 0, 8849164
section iast
Agent [baseline] (1.251 s) : 0, 1251067
Total [baseline] (9.564 s) : 0, 9564257
Agent [candidate] (1.248 s) : 0, 1248157
Total [candidate] (9.544 s) : 0, 9543554
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~67a53927ac, baseline=1.57.0-SNAPSHOT~632fb11d4e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (707.422 ms) : 0, 707422
BytebuddyAgent [candidate] (710.482 ms) : 0, 710482
GlobalTracer [baseline] (248.923 ms) : 0, 248923
GlobalTracer [candidate] (250.22 ms) : 0, 250220
AppSec [baseline] (32.195 ms) : 0, 32195
AppSec [candidate] (32.054 ms) : 0, 32054
Debugger [baseline] (63.444 ms) : 0, 63444
Debugger [candidate] (63.036 ms) : 0, 63036
Remote Config [baseline] (643.019 µs) : 0, 643
Remote Config [candidate] (620.496 µs) : 0, 620
Telemetry [baseline] (8.29 ms) : 0, 8290
Telemetry [candidate] (8.18 ms) : 0, 8180
Flare Poller [baseline] (3.695 ms) : 0, 3695
Flare Poller [candidate] (3.645 ms) : 0, 3645
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (841.153 ms) : 0, 841153
BytebuddyAgent [candidate] (838.076 ms) : 0, 838076
GlobalTracer [baseline] (238.914 ms) : 0, 238914
GlobalTracer [candidate] (239.693 ms) : 0, 239693
IAST [baseline] (28.539 ms) : 0, 28539
IAST [candidate] (28.568 ms) : 0, 28568
AppSec [baseline] (33.421 ms) : 0, 33421
AppSec [candidate] (33.265 ms) : 0, 33265
Debugger [baseline] (60.69 ms) : 0, 60690
Debugger [candidate] (60.389 ms) : 0, 60389
Remote Config [baseline] (545.282 µs) : 0, 545
Remote Config [candidate] (533.679 µs) : 0, 534
Telemetry [baseline] (7.651 ms) : 0, 7651
Telemetry [candidate] (7.651 ms) : 0, 7651
Flare Poller [baseline] (3.529 ms) : 0, 3529
Flare Poller [candidate] (3.512 ms) : 0, 3512
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~67a53927ac, baseline=1.57.0-SNAPSHOT~632fb11d4e
dateFormat X
axisFormat %s
section baseline
no_agent (1.211 ms) : 1199, 1222
. : milestone, 1211,
iast (3.274 ms) : 3229, 3319
. : milestone, 3274,
iast_FULL (5.922 ms) : 5863, 5982
. : milestone, 5922,
iast_GLOBAL (3.65 ms) : 3601, 3698
. : milestone, 3650,
profiling (2.141 ms) : 2121, 2160
. : milestone, 2141,
tracing (1.876 ms) : 1861, 1891
. : milestone, 1876,
section candidate
no_agent (1.216 ms) : 1204, 1228
. : milestone, 1216,
iast (3.212 ms) : 3169, 3255
. : milestone, 3212,
iast_FULL (5.773 ms) : 5715, 5830
. : milestone, 5773,
iast_GLOBAL (3.721 ms) : 3671, 3772
. : milestone, 3721,
profiling (2.223 ms) : 2203, 2244
. : milestone, 2223,
tracing (1.814 ms) : 1799, 1830
. : milestone, 1814,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~67a53927ac, baseline=1.57.0-SNAPSHOT~632fb11d4e
dateFormat X
axisFormat %s
section baseline
no_agent (18.021 ms) : 17836, 18206
. : milestone, 18021,
appsec (18.33 ms) : 18145, 18515
. : milestone, 18330,
code_origins (17.745 ms) : 17570, 17920
. : milestone, 17745,
iast (17.533 ms) : 17361, 17705
. : milestone, 17533,
profiling (19.775 ms) : 19575, 19975
. : milestone, 19775,
tracing (17.807 ms) : 17632, 17982
. : milestone, 17807,
section candidate
no_agent (17.515 ms) : 17336, 17695
. : milestone, 17515,
appsec (18.491 ms) : 18304, 18677
. : milestone, 18491,
code_origins (17.985 ms) : 17803, 18166
. : milestone, 17985,
iast (18.119 ms) : 17934, 18303
. : milestone, 18119,
profiling (19.944 ms) : 19738, 20150
. : milestone, 19944,
tracing (17.86 ms) : 17682, 18037
. : milestone, 17860,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~67a53927ac, baseline=1.57.0-SNAPSHOT~632fb11d4e
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.457 ms) : 2405, 2509
. : milestone, 2457,
iast (2.215 ms) : 2150, 2280
. : milestone, 2215,
iast_GLOBAL (2.249 ms) : 2184, 2313
. : milestone, 2249,
profiling (2.083 ms) : 2029, 2136
. : milestone, 2083,
tracing (2.044 ms) : 1993, 2095
. : milestone, 2044,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.681 ms) : 3463, 3898
. : milestone, 3681,
iast (2.213 ms) : 2149, 2278
. : milestone, 2213,
iast_GLOBAL (2.242 ms) : 2177, 2306
. : milestone, 2242,
profiling (2.091 ms) : 2037, 2146
. : milestone, 2091,
tracing (2.035 ms) : 1985, 2086
. : milestone, 2035,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~67a53927ac, baseline=1.57.0-SNAPSHOT~632fb11d4e
dateFormat X
axisFormat %s
section baseline
no_agent (15.113 s) : 15113000, 15113000
. : milestone, 15113000,
appsec (14.944 s) : 14944000, 14944000
. : milestone, 14944000,
iast (18.052 s) : 18052000, 18052000
. : milestone, 18052000,
iast_GLOBAL (17.839 s) : 17839000, 17839000
. : milestone, 17839000,
profiling (14.952 s) : 14952000, 14952000
. : milestone, 14952000,
tracing (14.695 s) : 14695000, 14695000
. : milestone, 14695000,
section candidate
no_agent (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
appsec (14.666 s) : 14666000, 14666000
. : milestone, 14666000,
iast (19.097 s) : 19097000, 19097000
. : milestone, 19097000,
iast_GLOBAL (17.899 s) : 17899000, 17899000
. : milestone, 17899000,
profiling (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
tracing (14.846 s) : 14846000, 14846000
. : milestone, 14846000,
|
amarziali
approved these changes
Nov 21, 2025
amarziali
pushed a commit
that referenced
this pull request
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Minor code cleanup.
Motivation
Clean code.
Additional Notes
Several minor fixes I found during code reviews.